[GitHub] [plc4x] hutcheb commented on pull request #348: Started with the PlcReadRequest

2022-04-13 Thread GitBox
hutcheb commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1098356403 I think an intermediary 'client' object makes more sense. I've pulled out the PlcResponse and PlcRequest stuff from the opposite class. In the Java version there's a PlcRequestContainer w

[GitHub] [plc4x] ottlukas commented on pull request #348: Started with the PlcReadRequest

2022-04-13 Thread GitBox
ottlukas commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1098349503 > https://softwareengineering.stackexchange.com/questions/369146/how-to-avoid-bidirectional-class-and-module-dependencies I liked accepted answer: - Hide it with interfaces

[GitHub] [plc4x] sruehl commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-13 Thread GitBox
sruehl commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1097955426 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4

2022-04-13 Thread GitBox
sruehl commented on PR #340: URL: https://github.com/apache/plc4x/pull/340#issuecomment-1097955323 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0

2022-04-13 Thread GitBox
sruehl commented on PR #346: URL: https://github.com/apache/plc4x/pull/346#issuecomment-1097955199 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4

2022-04-13 Thread GitBox
sruehl commented on PR #349: URL: https://github.com/apache/plc4x/pull/349#issuecomment-1097955065 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20

2022-04-13 Thread GitBox
sruehl commented on PR #350: URL: https://github.com/apache/plc4x/pull/350#issuecomment-1097954949 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns