Re: [PR] fix(plc4j/drivers/s7): Delete 2 duplicate classes

2024-11-08 Thread via GitHub
glcj commented on PR #1878: URL: https://github.com/apache/plc4x/pull/1878#issuecomment-2465017950 Hi, S7Mux is actually an interface. Normally it should be in a ".api" package. Its purpose is to be able to implement with a second instance of "S7MuxImpl", the case of four commu

[BUILD-UNSTABLE]: Job 'PLC4X/PLC4X/develop [develop] [2338]'

2024-11-08 Thread Apache Jenkins Server
BUILD-UNSTABLE: Job 'PLC4X/PLC4X/develop [develop] [2338]': Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/2338/";>PLC4X/PLC4X/develop [develop] [2338]"

Re: [PR] build(deps): bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 from 2.18.0 to 2.18.1

2024-11-08 Thread via GitHub
sruehl merged PR #1875: URL: https://github.com/apache/plc4x/pull/1875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump groovy.version from 4.0.23 to 4.0.24

2024-11-08 Thread via GitHub
sruehl merged PR #1876: URL: https://github.com/apache/plc4x/pull/1876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump com.googlecode.maven-download-plugin:download-maven-plugin from 1.9.0 to 1.11.2

2024-11-08 Thread via GitHub
sruehl merged PR #1874: URL: https://github.com/apache/plc4x/pull/1874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] build(deps): bump golang.org/x/text from 0.19.0 to 0.20.0 in /plc4go

2024-11-08 Thread via GitHub
sruehl merged PR #1877: URL: https://github.com/apache/plc4x/pull/1877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

Re: [PR] fix(plc4j/drivers/s7): Delete 2 duplicate classes

2024-11-08 Thread via GitHub
sruehl commented on PR #1878: URL: https://github.com/apache/plc4x/pull/1878#issuecomment-2464617683 @glcj why are those files in both locations? Fix looks fine, can't judge where they are supposed to be... -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] fix(plc4j/drivers/s7): fix Camel tries to reconnect immediately because of event order

2024-11-08 Thread via GitHub
sruehl commented on PR #1879: URL: https://github.com/apache/plc4x/pull/1879#issuecomment-2464614065 thanks for your PR, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] fix(plc4j/drivers/s7): fix Camel tries to reconnect immediately because of event order

2024-11-08 Thread via GitHub
jmeierhofer opened a new pull request, #1879: URL: https://github.com/apache/plc4x/pull/1879 This PR fixes an ordering issue for the user event listeners. The isConnected method does return false for less than 1ms which causes an exception because the connection is discared immediately, ign

[PR] fix(plc4j/drivers/s7): Delete 2 duplicate classes

2024-11-08 Thread via GitHub
jmeierhofer opened a new pull request, #1878: URL: https://github.com/apache/plc4x/pull/1878 Delete 2 duplicate classes, the used ones are located in org.apache.plc4x.java.s7.readwrite.protocol. ![image](https://github.com/user-attachments/assets/be51925a-891c-463a-bf6b-96b9d7947fe9)