[GitHub] [plc4x] sruehl merged pull request #376: chore(deps): bump actions/github-script from 5.0.0 to 6.1.0

2022-06-10 Thread GitBox
sruehl merged PR #376: URL: https://github.com/apache/plc4x/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] sruehl commented on pull request #367: EIP adding read/write for STRINGS and LINT

2022-06-10 Thread GitBox
sruehl commented on PR #367: URL: https://github.com/apache/plc4x/pull/367#issuecomment-1152278009 thanks for the PR  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl merged pull request #367: EIP adding read/write for STRINGS and LINT

2022-06-10 Thread GitBox
sruehl merged PR #367: URL: https://github.com/apache/plc4x/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] sruehl merged pull request #370: chore(deps): bump BobAnkh/auto-generate-changelog from 1.1.0 to 1.1.1

2022-06-10 Thread GitBox
sruehl merged PR #370: URL: https://github.com/apache/plc4x/pull/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] sruehl merged pull request #372: chore(deps): bump actions/setup-java from 2 to 3

2022-06-10 Thread GitBox
sruehl merged PR #372: URL: https://github.com/apache/plc4x/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] sruehl merged pull request #371: chore(deps): bump github/codeql-action from 1 to 2

2022-06-10 Thread GitBox
sruehl merged PR #371: URL: https://github.com/apache/plc4x/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] sruehl merged pull request #369: chore(deps): bump actions/checkout from 2 to 3

2022-06-10 Thread GitBox
sruehl merged PR #369: URL: https://github.com/apache/plc4x/pull/369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #376: chore(deps): bump actions/github-script from 5.0.0 to 6.1.0

2022-06-10 Thread GitBox
dependabot[bot] opened a new pull request, #376: URL: https://github.com/apache/plc4x/pull/376 Bumps [actions/github-script](https://github.com/actions/github-script) from 5.0.0 to 6.1.0. Release notes Sourced from

[GitHub] [plc4x] sruehl merged pull request #368: chore(deps): bump actions/cache from 2 to 3

2022-06-10 Thread GitBox
sruehl merged PR #368: URL: https://github.com/apache/plc4x/pull/368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #375: chore(deps): bump github.com/rs/zerolog from 1.20.0 to 1.27.0 in /plc4go

2022-06-10 Thread GitBox
dependabot[bot] opened a new pull request, #375: URL: https://github.com/apache/plc4x/pull/375 Bumps [github.com/rs/zerolog](https://github.com/rs/zerolog) from 1.20.0 to 1.27.0. Commits https://github.com/rs/zerolog/commit/e9344a8c507b5f25a4962ff022526be0ddab8e72;>e9344a8

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #374: chore(deps): bump github.com/stretchr/testify from 1.7.1 to 1.7.2 in /plc4go

2022-06-10 Thread GitBox
dependabot[bot] opened a new pull request, #374: URL: https://github.com/apache/plc4x/pull/374 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.7.2. Commits

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #373: chore(deps): bump github.com/icza/bitio from 1.0.0 to 1.1.0 in /plc4go

2022-06-10 Thread GitBox
dependabot[bot] opened a new pull request, #373: URL: https://github.com/apache/plc4x/pull/373 Bumps [github.com/icza/bitio](https://github.com/icza/bitio) from 1.0.0 to 1.1.0. Commits https://github.com/icza/bitio/commit/9ae536dae7462f974fe22d2db7214a4e28154dcc;>9ae536d

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #372: chore(deps): bump actions/setup-java from 2 to 3

2022-06-10 Thread GitBox
dependabot[bot] opened a new pull request, #372: URL: https://github.com/apache/plc4x/pull/372 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2 to 3. Release notes Sourced from https://github.com/actions/setup-java/releases;>actions/setup-java's releases.

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #371: chore(deps): bump github/codeql-action from 1 to 2

2022-06-10 Thread GitBox
dependabot[bot] opened a new pull request, #371: URL: https://github.com/apache/plc4x/pull/371 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2. Changelog Sourced from

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #370: chore(deps): bump BobAnkh/auto-generate-changelog from 1.1.0 to 1.1.1

2022-06-10 Thread GitBox
dependabot[bot] opened a new pull request, #370: URL: https://github.com/apache/plc4x/pull/370 Bumps [BobAnkh/auto-generate-changelog](https://github.com/BobAnkh/auto-generate-changelog) from 1.1.0 to 1.1.1. Release notes Sourced from

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #369: chore(deps): bump actions/checkout from 2 to 3

2022-06-10 Thread GitBox
dependabot[bot] opened a new pull request, #369: URL: https://github.com/apache/plc4x/pull/369 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases.

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #368: chore(deps): bump actions/cache from 2 to 3

2022-06-10 Thread GitBox
dependabot[bot] opened a new pull request, #368: URL: https://github.com/apache/plc4x/pull/368 Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases. v3.0.0

[GitHub] [plc4x] AndyGrebe opened a new pull request, #367: EIP adding read/write for STRINGS and LINT

2022-06-09 Thread GitBox
AndyGrebe opened a new pull request, #367: URL: https://github.com/apache/plc4x/pull/367 Jira PLC4X-341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [plc4x] JulianFeinauer merged pull request #366: Feature/plc4rs 2

2022-06-09 Thread GitBox
JulianFeinauer merged PR #366: URL: https://github.com/apache/plc4x/pull/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #365: chore(deps): bump maven-dependency-tree from 3.1.0 to 3.1.1

2022-05-25 Thread GitBox
dependabot[bot] opened a new pull request, #365: URL: https://github.com/apache/plc4x/pull/365 Bumps [maven-dependency-tree](https://github.com/apache/maven-dependency-tree) from 3.1.0 to 3.1.1. Release notes Sourced from

[GitHub] [plc4x] dependabot[bot] closed pull request #360: build(deps): bump calcite-core.version from 1.28.0 to 1.30.0

2022-05-25 Thread GitBox
dependabot[bot] closed pull request #360: build(deps): bump calcite-core.version from 1.28.0 to 1.30.0 URL: https://github.com/apache/plc4x/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [plc4x] dependabot[bot] commented on pull request #360: build(deps): bump calcite-core.version from 1.28.0 to 1.30.0

2022-05-25 Thread GitBox
dependabot[bot] commented on PR #360: URL: https://github.com/apache/plc4x/pull/360#issuecomment-1137838164 Looks like these dependencies are up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [plc4x] sarguments closed pull request #364: Correct an invalid example in `modbus.adoc`

2022-05-16 Thread GitBox
sarguments closed pull request #364: Correct an invalid example in `modbus.adoc` URL: https://github.com/apache/plc4x/pull/364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [plc4x] sarguments opened a new pull request, #364: Correct an invalid example in `modbus.adoc`

2022-05-16 Thread GitBox
sarguments opened a new pull request, #364: URL: https://github.com/apache/plc4x/pull/364 Corrected an invalid example as follows: `modbus-tcp:tcp://127.0.0.1:502` -> `modbus:tcp://127.0.0.1:502` -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [plc4x] sruehl commented on pull request #363: fix(plc4go): fix the error of value out of range when converting an i…

2022-05-12 Thread GitBox
sruehl commented on PR #363: URL: https://github.com/apache/plc4x/pull/363#issuecomment-1124751557 thx for the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl merged pull request #363: fix(plc4go): fix the error of value out of range when converting an i…

2022-05-12 Thread GitBox
sruehl merged PR #363: URL: https://github.com/apache/plc4x/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] hongjinlin opened a new pull request, #363: fix(plc4go): fix the error of value out of range when converting an i…

2022-05-12 Thread GitBox
hongjinlin opened a new pull request, #363: URL: https://github.com/apache/plc4x/pull/363 …n-range number string to IEC61131 unsigned integer or WORD-related type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [plc4x] hutcheb merged pull request #358: Plc4py/plc field

2022-04-27 Thread GitBox
hutcheb merged PR #358: URL: https://github.com/apache/plc4x/pull/358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #361: build(deps): bump kafka.version from 3.1.0 to 7.1.1-ce

2022-04-26 Thread GitBox
dependabot[bot] opened a new pull request, #361: URL: https://github.com/apache/plc4x/pull/361 Bumps `kafka.version` from 3.1.0 to 7.1.1-ce. Updates `kafka-clients` from 3.1.0 to 7.1.1-ce Updates `connect-api` from 3.1.0 to 7.1.1-ce Dependabot will resolve any conflicts

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #360: build(deps): bump calcite-core.version from 1.28.0 to 1.30.0

2022-04-26 Thread GitBox
dependabot[bot] opened a new pull request, #360: URL: https://github.com/apache/plc4x/pull/360 Bumps `calcite-core.version` from 1.28.0 to 1.30.0. Updates `calcite-core` from 1.28.0 to 1.30.0 Commits

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #359: build(deps): bump maven-artifact from 3.6.3 to 3.8.5

2022-04-26 Thread GitBox
dependabot[bot] opened a new pull request, #359: URL: https://github.com/apache/plc4x/pull/359 Bumps [maven-artifact](https://github.com/apache/maven) from 3.6.3 to 3.8.5. Release notes Sourced from https://github.com/apache/maven/releases;>maven-artifact's releases. 3.8.5

[GitHub] [plc4x] splatch commented on a diff in pull request #352: "Modbus plus"

2022-04-23 Thread GitBox
splatch commented on code in PR #352: URL: https://github.com/apache/plc4x/pull/352#discussion_r857035719 ## protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec: ## @@ -416,6 +416,15 @@ ['WCHAR' List [array uint 16 value count

[GitHub] [plc4x] hutcheb opened a new pull request, #358: Plc4py/plc field

2022-04-22 Thread GitBox
hutcheb opened a new pull request, #358: URL: https://github.com/apache/plc4x/pull/358 Started to update the PlcField and look at how to handle async functions. Common problem I've found with using the Future class is there's no way to specify a timeout. This can cause issues with

[GitHub] [plc4x] hutcheb closed pull request #354: Fix/plc4py_pipenv

2022-04-22 Thread GitBox
hutcheb closed pull request #354: Fix/plc4py_pipenv URL: https://github.com/apache/plc4x/pull/354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [plc4x] hutcheb commented on pull request #354: Fix/plc4py_pipenv

2022-04-22 Thread GitBox
hutcheb commented on PR #354: URL: https://github.com/apache/plc4x/pull/354#issuecomment-1106816845 Using pipenv to build is too slow and adds an unnecessary dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [plc4x] hutcheb merged pull request #355: Fix/plc4py venv

2022-04-22 Thread GitBox
hutcheb merged PR #355: URL: https://github.com/apache/plc4x/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #357: build(deps): bump jacoco-maven-plugin from 0.8.7 to 0.8.8

2022-04-22 Thread GitBox
dependabot[bot] opened a new pull request, #357: URL: https://github.com/apache/plc4x/pull/357 Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.7 to 0.8.8. Release notes Sourced from https://github.com/jacoco/jacoco/releases;>jacoco-maven-plugin's releases.

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #356: build(deps): bump spock-bom from 2.0-groovy-3.0 to 2.1-groovy-3.0

2022-04-22 Thread GitBox
dependabot[bot] opened a new pull request, #356: URL: https://github.com/apache/plc4x/pull/356 Bumps spock-bom from 2.0-groovy-3.0 to 2.1-groovy-3.0. [![Dependabot compatibility

[GitHub] [plc4x-build-tools] dependabot[bot] closed pull request #24: chore(deps): bump maven-site-plugin from 3.9.1 to 3.11.0

2022-04-21 Thread GitBox
dependabot[bot] closed pull request #24: chore(deps): bump maven-site-plugin from 3.9.1 to 3.11.0 URL: https://github.com/apache/plc4x-build-tools/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request, #30: chore(deps): bump maven-site-plugin from 3.9.1 to 3.12.0

2022-04-21 Thread GitBox
dependabot[bot] opened a new pull request, #30: URL: https://github.com/apache/plc4x-build-tools/pull/30 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.9.1 to 3.12.0. Release notes Sourced from

[GitHub] [plc4x-build-tools] dependabot[bot] commented on pull request #24: chore(deps): bump maven-site-plugin from 3.9.1 to 3.11.0

2022-04-21 Thread GitBox
dependabot[bot] commented on PR #24: URL: https://github.com/apache/plc4x-build-tools/pull/24#issuecomment-1105966297 Superseded by #30. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [plc4x] hutcheb opened a new pull request, #355: Fix/plc4py venv

2022-04-21 Thread GitBox
hutcheb opened a new pull request, #355: URL: https://github.com/apache/plc4x/pull/355 Alternative build using venv. Using maven for this simplifies a lot, however you can still use pipenv, virtualenv or venv to install and build it locally if you choose. -- This is an automated

[GitHub] [plc4x] sruehl merged pull request #353: build(deps): bump kotlin.version from 1.6.20 to 1.6.21

2022-04-20 Thread GitBox
sruehl merged PR #353: URL: https://github.com/apache/plc4x/pull/353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #353: build(deps): bump kotlin.version from 1.6.20 to 1.6.21

2022-04-20 Thread GitBox
dependabot[bot] opened a new pull request, #353: URL: https://github.com/apache/plc4x/pull/353 Bumps `kotlin.version` from 1.6.20 to 1.6.21. Updates `kotlin-stdlib` from 1.6.20 to 1.6.21 Release notes Sourced from https://github.com/JetBrains/kotlin/releases;>kotlin-stdlib's

[GitHub] [plc4x] dependabot[bot] closed pull request #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20

2022-04-20 Thread GitBox
dependabot[bot] closed pull request #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20 URL: https://github.com/apache/plc4x/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [plc4x] dependabot[bot] commented on pull request #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20

2022-04-20 Thread GitBox
dependabot[bot] commented on PR #350: URL: https://github.com/apache/plc4x/pull/350#issuecomment-1103880524 Looks like these dependencies are updatable in another way, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [plc4x] dependabot[bot] commented on pull request #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4

2022-04-20 Thread GitBox
dependabot[bot] commented on PR #349: URL: https://github.com/apache/plc4x/pull/349#issuecomment-1103869416 Looks like org.checkerframework:checker-qual is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [plc4x] dependabot[bot] closed pull request #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4

2022-04-20 Thread GitBox
dependabot[bot] closed pull request #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4 URL: https://github.com/apache/plc4x/pull/349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [plc4x] dependabot[bot] closed pull request #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0

2022-04-20 Thread GitBox
dependabot[bot] closed pull request #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0 URL: https://github.com/apache/plc4x/pull/346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [plc4x] dependabot[bot] commented on pull request #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0

2022-04-20 Thread GitBox
dependabot[bot] commented on PR #346: URL: https://github.com/apache/plc4x/pull/346#issuecomment-1103869185 Looks like org.codehaus.mojo:build-helper-maven-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [plc4x] chrisdutz commented on pull request #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20

2022-04-20 Thread GitBox
chrisdutz commented on PR #350: URL: https://github.com/apache/plc4x/pull/350#issuecomment-1103860536 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] chrisdutz commented on pull request #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4

2022-04-20 Thread GitBox
chrisdutz commented on PR #349: URL: https://github.com/apache/plc4x/pull/349#issuecomment-1103860442 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] chrisdutz commented on pull request #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0

2022-04-20 Thread GitBox
chrisdutz commented on PR #346: URL: https://github.com/apache/plc4x/pull/346#issuecomment-1103860308 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [plc4x] dependabot[bot] closed pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4

2022-04-20 Thread GitBox
dependabot[bot] closed pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4 URL: https://github.com/apache/plc4x/pull/340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [plc4x] dependabot[bot] commented on pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4

2022-04-20 Thread GitBox
dependabot[bot] commented on PR #340: URL: https://github.com/apache/plc4x/pull/340#issuecomment-1103838404 Looks like org.owasp:dependency-check-maven is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
chrisdutz commented on code in PR #352: URL: https://github.com/apache/plc4x/pull/352#discussion_r854032379 ## protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec: ## @@ -416,6 +416,15 @@ ['WCHAR' List [array uint 16 value count

[GitHub] [plc4x] chrisdutz commented on pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4

2022-04-20 Thread GitBox
chrisdutz commented on PR #340: URL: https://github.com/apache/plc4x/pull/340#issuecomment-1103830029 https://github.com/dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [plc4x] splatch commented on a diff in pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
splatch commented on code in PR #352: URL: https://github.com/apache/plc4x/pull/352#discussion_r854031480 ## protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec: ## @@ -416,6 +416,15 @@ ['WCHAR' List [array uint 16 value count

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
chrisdutz commented on code in PR #352: URL: https://github.com/apache/plc4x/pull/352#discussion_r854001057 ## protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec: ## @@ -416,6 +416,15 @@ ['WCHAR' List [array uint 16 value count

[GitHub] [plc4x] splatch commented on a diff in pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
splatch commented on code in PR #352: URL: https://github.com/apache/plc4x/pull/352#discussion_r853998595 ## protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec: ## @@ -416,6 +416,15 @@ ['WCHAR' List [array uint 16 value count

[GitHub] [plc4x] chrisdutz commented on a diff in pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
chrisdutz commented on code in PR #352: URL: https://github.com/apache/plc4x/pull/352#discussion_r853995262 ## protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec: ## @@ -416,6 +416,15 @@ ['WCHAR' List [array uint 16 value count

[GitHub] [plc4x] splatch commented on pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
splatch commented on PR #352: URL: https://github.com/apache/plc4x/pull/352#issuecomment-1103792196 I get your point as it is tricky. For me with high level language it makes sense to avoid construction of a `String[] {"a", "b", "c", "d" }` and return directly a String "abcd" to the

[GitHub] [plc4x] chrisdutz commented on pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
chrisdutz commented on PR #352: URL: https://github.com/apache/plc4x/pull/352#issuecomment-1103789461 "List" would require a field of type array labeled "value" So I think this should be "STRING" instead ... but the variable of the length I can't see where it's coming from. --

[GitHub] [plc4x] splatch commented on pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
splatch commented on PR #352: URL: https://github.com/apache/plc4x/pull/352#issuecomment-1103789374 > Your mspec fragment looks a bit fishy in general ... the type you define as "List" and not as "String" and where does the "numberOfValues" come from? Its being called when you

[GitHub] [plc4x] chrisdutz commented on pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
chrisdutz commented on PR #352: URL: https://github.com/apache/plc4x/pull/352#issuecomment-1103788275 Your mspec fragment looks a bit fishy in general ... the type you define as "List" and not as "String" and where does the "numberOfValues" come from? -- This is an automated message from

[GitHub] [plc4x] splatch commented on pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
splatch commented on PR #352: URL: https://github.com/apache/plc4x/pull/352#issuecomment-1103774437 > Ther test.mspec contains vstring fields ... could you please elaborate on what is actually not working? In this case the test.mspec should be extended with an example that doesn't work.

[GitHub] [plc4x] chrisdutz commented on pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
chrisdutz commented on PR #352: URL: https://github.com/apache/plc4x/pull/352#issuecomment-1103743231 Ther test.mspec contains vstring fields ... could you please elaborate on what is actually not working? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [plc4x] splatch commented on pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
splatch commented on PR #352: URL: https://github.com/apache/plc4x/pull/352#issuecomment-1103733105 Seems C templates needs to be updated as well to handle string fields. Sadly I can't handle that part. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [plc4x] splatch opened a new pull request, #352: "Modbus plus"

2022-04-19 Thread GitBox
splatch opened a new pull request, #352: URL: https://github.com/apache/plc4x/pull/352 This pull request solves few errors I spotted while trying to use plc4j modbus stuff. First of all, it adds support for String outputs from modbus requests, so `holding:3000:STRING[30]` will bring

[GitHub] [plc4x] ottlukas commented on pull request #348: Started with the PlcReadRequest

2022-04-19 Thread GitBox
ottlukas commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1103033451 > Having trouble with pycharm and poetry for some reason, I'll merge this and swap to using a new build system. Ok then lets bring this change to the mailing list - we already

[GitHub] [plc4x] hutcheb merged pull request #348: Started with the PlcReadRequest

2022-04-19 Thread GitBox
hutcheb merged PR #348: URL: https://github.com/apache/plc4x/pull/348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] hutcheb commented on pull request #348: Started with the PlcReadRequest

2022-04-19 Thread GitBox
hutcheb commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1103029682 Having trouble with pycharm and poetry for some reason, I'll merge this and swap to using a new build system. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [plc4x] dependabot[bot] commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-19 Thread GitBox
dependabot[bot] commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1102339191 OK, I won't notify you about version 3.3.x again, unless you re-open this PR or update to a 3.3.x release yourself. -- This is an automated message from the Apache Git Service. To

[GitHub] [plc4x] chrisdutz commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-19 Thread GitBox
chrisdutz commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1102339127 @dependabot ignore this minor version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [plc4x] chrisdutz commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-19 Thread GitBox
chrisdutz commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1102338322 The newer versions of the dependency-plugin still produce the false negatives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [plc4x] dependabot[bot] commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-19 Thread GitBox
dependabot[bot] commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1102338418 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [plc4x] chrisdutz closed pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-19 Thread GitBox
chrisdutz closed pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0 URL: https://github.com/apache/plc4x/pull/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [plc4x] chrisdutz merged pull request #351: Bug Fix. Open too many files after complete

2022-04-19 Thread GitBox
chrisdutz merged PR #351: URL: https://github.com/apache/plc4x/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [plc4x] Dustone-JavaWeb opened a new pull request, #351: Bug Fix. Open too many files after complete

2022-04-18 Thread GitBox
Dustone-JavaWeb opened a new pull request, #351: URL: https://github.com/apache/plc4x/pull/351 Shutdown the workergroup. remove the final tag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [plc4x] hutcheb commented on pull request #348: Started with the PlcReadRequest

2022-04-13 Thread GitBox
hutcheb commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1098356403 I think an intermediary 'client' object makes more sense. I've pulled out the PlcResponse and PlcRequest stuff from the opposite class. In the Java version there's a PlcRequestContainer

[GitHub] [plc4x] ottlukas commented on pull request #348: Started with the PlcReadRequest

2022-04-13 Thread GitBox
ottlukas commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1098349503 > https://softwareengineering.stackexchange.com/questions/369146/how-to-avoid-bidirectional-class-and-module-dependencies I liked accepted answer: - Hide it with interfaces

[GitHub] [plc4x] sruehl commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-13 Thread GitBox
sruehl commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1097955426 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl commented on pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4

2022-04-13 Thread GitBox
sruehl commented on PR #340: URL: https://github.com/apache/plc4x/pull/340#issuecomment-1097955323 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl commented on pull request #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0

2022-04-13 Thread GitBox
sruehl commented on PR #346: URL: https://github.com/apache/plc4x/pull/346#issuecomment-1097955199 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl commented on pull request #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4

2022-04-13 Thread GitBox
sruehl commented on PR #349: URL: https://github.com/apache/plc4x/pull/349#issuecomment-1097955065 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl commented on pull request #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20

2022-04-13 Thread GitBox
sruehl commented on PR #350: URL: https://github.com/apache/plc4x/pull/350#issuecomment-1097954949 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] hutcheb commented on pull request #348: Started with the PlcReadRequest

2022-04-12 Thread GitBox
hutcheb commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1097279842 https://softwareengineering.stackexchange.com/questions/369146/how-to-avoid-bidirectional-class-and-module-dependencies -- This is an automated message from the Apache Git Service. To

[GitHub] [plc4x] hutcheb commented on pull request #348: Started with the PlcReadRequest

2022-04-12 Thread GitBox
hutcheb commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1097270741 I also hate Circular dependancies, running into it with the PlcResponse and PlcRequest classes -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [plc4x] hutcheb commented on pull request #348: Started with the PlcReadRequest

2022-04-12 Thread GitBox
hutcheb commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1097232038 So I've ended up with abstract class such as this which allow you to pass return types, in this case it goes 3 or 4 deep before I create a concrete class. It seems to work but feels a bit

[GitHub] [plc4x] sruehl commented on pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4

2022-04-12 Thread GitBox
sruehl commented on PR #340: URL: https://github.com/apache/plc4x/pull/340#issuecomment-1096906343 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-12 Thread GitBox
sruehl commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1096906486 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl commented on pull request #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0

2022-04-12 Thread GitBox
sruehl commented on PR #346: URL: https://github.com/apache/plc4x/pull/346#issuecomment-1096906163 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl commented on pull request #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20

2022-04-12 Thread GitBox
sruehl commented on PR #350: URL: https://github.com/apache/plc4x/pull/350#issuecomment-1096905761 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] sruehl commented on pull request #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4

2022-04-12 Thread GitBox
sruehl commented on PR #349: URL: https://github.com/apache/plc4x/pull/349#issuecomment-1096905887 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20

2022-04-12 Thread GitBox
dependabot[bot] opened a new pull request, #350: URL: https://github.com/apache/plc4x/pull/350 Bumps `kotlin.version` from 1.6.10 to 1.6.20. Updates `kotlin-stdlib` from 1.6.10 to 1.6.20 Release notes Sourced from https://github.com/JetBrains/kotlin/releases;>kotlin-stdlib's

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4

2022-04-12 Thread GitBox
dependabot[bot] opened a new pull request, #349: URL: https://github.com/apache/plc4x/pull/349 Bumps [checker-qual](https://github.com/typetools/checker-framework) from 3.10.0 to 3.21.4. Release notes Sourced from

[GitHub] [plc4x] chrisdutz commented on pull request #347: build(deps): bump maven-site-plugin from 3.9.1 to 3.11.0

2022-04-11 Thread GitBox
chrisdutz commented on PR #347: URL: https://github.com/apache/plc4x/pull/347#issuecomment-1095487191 We can't update the site plugin as the asciidoctor plugin needs an update first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [plc4x] chrisdutz closed pull request #347: build(deps): bump maven-site-plugin from 3.9.1 to 3.11.0

2022-04-11 Thread GitBox
chrisdutz closed pull request #347: build(deps): bump maven-site-plugin from 3.9.1 to 3.11.0 URL: https://github.com/apache/plc4x/pull/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #347: build(deps): bump maven-site-plugin from 3.9.1 to 3.11.0

2022-04-11 Thread GitBox
dependabot[bot] opened a new pull request, #347: URL: https://github.com/apache/plc4x/pull/347 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.9.1 to 3.11.0. Release notes Sourced from

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0

2022-04-11 Thread GitBox
dependabot[bot] opened a new pull request, #346: URL: https://github.com/apache/plc4x/pull/346 Bumps [build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin) from 3.2.0 to 3.3.0. Release notes Sourced from

<    4   5   6   7   8   9   10   11   12   13   >