[GitHub] [plc4x] chrisdutz commented on pull request #384: Updated java CIP write dataSize to match read dataSize

2022-06-20 Thread GitBox
chrisdutz commented on PR #384: URL: https://github.com/apache/plc4x/pull/384#issuecomment-1160368966 I think the contribution is small enough to be ok to merge without ... however if you plan on actively contributing more (which I really hope), then it would be cool, if you could file an I

[GitHub] [plc4x] chrisdutz commented on pull request #384: Updated java CIP write dataSize to match read dataSize

2022-06-19 Thread GitBox
chrisdutz commented on PR #384: URL: https://github.com/apache/plc4x/pull/384#issuecomment-1159680532 So is this in a mergable state? I think you're probably the best to say anything about this. If it is ... please be so kind an merge it. -- This is an automated message from the Apache Gi

[GitHub] [plc4x] chrisdutz commented on pull request #384: Updated java CIP write dataSize to match read dataSize

2022-06-18 Thread GitBox
chrisdutz commented on PR #384: URL: https://github.com/apache/plc4x/pull/384#issuecomment-1159473079 Could you please add a bit more information in this PR (here in Github) to what the PR addresses? -- This is an automated message from the Apache Git Service. To respond to the message, p