[GitHub] [plc4x] hutcheb commented on pull request #384: Updated java CIP write dataSize to match read dataSize

2022-06-19 Thread GitBox
hutcheb commented on PR #384: URL: https://github.com/apache/plc4x/pull/384#issuecomment-1159805372 Hi Andy, Yeah the PR looks good., thank you. It looks like this is your first contribution to not only the ASF but also open source on GitHub, Congratulations. As part of the AS

[GitHub] [plc4x] hutcheb commented on pull request #384: Updated java CIP write dataSize to match read dataSize

2022-06-18 Thread GitBox
hutcheb commented on PR #384: URL: https://github.com/apache/plc4x/pull/384#issuecomment-1159564651 It looks like it is trying to handle fields a little better by taking into account members of structures. I had done some work with a logix controller on the logix_develop branch. Came