[GitHub] [plc4x] splatch commented on a diff in pull request #352: "Modbus plus"

2022-04-23 Thread GitBox
splatch commented on code in PR #352: URL: https://github.com/apache/plc4x/pull/352#discussion_r857035719 ## protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec: ## @@ -416,6 +416,15 @@ ['WCHAR' List [array uint 16 value count 'numberOfValues'

[GitHub] [plc4x] splatch commented on a diff in pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
splatch commented on code in PR #352: URL: https://github.com/apache/plc4x/pull/352#discussion_r854031480 ## protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec: ## @@ -416,6 +416,15 @@ ['WCHAR' List [array uint 16 value count 'numberOfValues'

[GitHub] [plc4x] splatch commented on a diff in pull request #352: "Modbus plus"

2022-04-20 Thread GitBox
splatch commented on code in PR #352: URL: https://github.com/apache/plc4x/pull/352#discussion_r853998595 ## protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec: ## @@ -416,6 +416,15 @@ ['WCHAR' List [array uint 16 value count 'numberOfValues'