Re: tests and coverage

2018-02-22 Thread Justin Mclean
Hi, > I don’t think its a issue of focus rather than time and resources (at least > in my case) Fair enough and as I said we have tests (with reasonable coverage) and that's a good thing. > My intention was to bring the ADS branch to master a soon as possible to > encourage contribution (see

Re: tests and coverage

2018-02-22 Thread Sebastian Rühl
Hi Justin, First of all thanks for the Tests (and finding the Bug :). You are absolutely right about your statements but I don’t think its a issue of focus rather than time and resources (at least in my case). My intention was to bring the ADS branch to master a soon as possible to encourage co

Re: tests and coverage

2018-02-19 Thread Christofer Dutz
tests without having to strain your brain too much. Chris Outlook for Android<https://aka.ms/ghei36> herunterladen From: Justin Mclean Sent: Tuesday, February 20, 2018 3:31:15 AM To: dev@plc4x.apache.org Subject: tests and coverage Hi, It looks to me t

tests and coverage

2018-02-19 Thread Justin Mclean
Hi, It looks to me that some of the tests are just here to increase coverage and we seem to be missing unit test for some of the more simple classes. Perhaps there’s a bit too much focus on the happy path and we’re not always checking boundary conditions and the like. Obviously this is a good s