hutcheb commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603093845
##
File path:
build-utils/language-c/src/main/resources/templates/c/pojo-template-c.ftlh
##
@@ -221,7 +227,7 @@ plc4c_return_code
${helper.getCTypeName(type
chrisdutz commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603096172
##
File path: build-utils/language-c/src/test/resources/integration-test/pom.xml
##
@@ -324,65 +312,63 @@
org.apache.plc4x
plc4j-api
-0.9.
chrisdutz commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603096539
##
File path: build-utils/language-go/src/test/resources/plc4go/pom.xml
##
@@ -244,75 +225,61 @@
-
-
org.apache.p
hutcheb commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603111076
##
File path: build-utils/language-go/src/test/resources/plc4go/pom.xml
##
@@ -0,0 +1,323 @@
+
Review comment:
I have added a reference to the parent
hutcheb commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603120355
##
File path:
build-utils/language-java/src/main/resources/templates/java/enum-template.ftlh
##
@@ -59,7 +59,7 @@ import java.util.Map;
public enum ${type.n
hutcheb commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603137491
##
File path:
build-utils/language-java/src/main/resources/templates/java/enum-template.ftlh
##
@@ -59,7 +59,7 @@ import java.util.Map;
public enum ${type.n
hutcheb commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603139119
##
File path: pom.xml
##
@@ -100,7 +100,7 @@
**/generated-sources
-1.4.0
+
1.5.0-SNAPSHOT
Review comment:
Yes there is an feature
hutcheb commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603139882
##
File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec
##
@@ -386,7 +386,7 @@
[array int 8 'data' count 'sampleSize']
]
-[dataIo 'Data
hutcheb commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603140062
##
File path: build-utils/language-go/src/test/resources/plc4go/pom.xml
##
@@ -244,75 +225,61 @@
-
-
org.apache.plc
chrisdutz commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r603140927
##
File path:
build-utils/language-java/src/main/resources/templates/java/enum-template.ftlh
##
@@ -59,7 +59,7 @@ import java.util.Map;
public enum ${type
hutcheb opened a new pull request #5:
URL: https://github.com/apache/plc4x-build-tools/pull/5
Update for the string type reference to use an expression instead of a hard
coded value for it's length
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
sruehl commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r604092304
##
File path: pom.xml
##
@@ -100,7 +100,7 @@
**/generated-sources
-1.4.0
+
1.5.0-SNAPSHOT
Review comment:
@chrisdutz do we need to
sruehl commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r604093236
##
File path: .gitignore
##
@@ -181,3 +181,14 @@ build-iPhoneSimulator/
/sandbox/plc4go/temp/
/plc4go/.idea/
plc4j/examples/hello-storage-elasticsearch/.fac
sruehl commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r604093628
##
File path: build-utils/language-base-freemarker/pom.xml
##
@@ -55,6 +55,12 @@
net.objecthunter
exp4j
+
+ org.apache.plc4x
sruehl commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r604098043
##
File path:
build-utils/language-java/src/main/resources/templates/java/pojo-template.ftlh
##
@@ -95,7 +95,11 @@ public<#if helper.isDiscriminatedParentType
sruehl commented on a change in pull request #230:
URL: https://github.com/apache/plc4x/pull/230#discussion_r604097861
##
File path:
build-utils/language-java/src/main/resources/templates/java/pojo-template.ftlh
##
@@ -95,7 +95,11 @@ public<#if helper.isDiscriminatedParentType
hutcheb merged pull request #5:
URL: https://github.com/apache/plc4x-build-tools/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
hutcheb merged pull request #230:
URL: https://github.com/apache/plc4x/pull/230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
Adito5393 opened a new pull request #234:
URL: https://github.com/apache/plc4x/pull/234
This case is DEVICE_PROPERTIES + DEVICE_OPTIONS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
splatch merged pull request #234:
URL: https://github.com/apache/plc4x/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
sruehl commented on a change in pull request #232:
URL: https://github.com/apache/plc4x/pull/232#discussion_r609965952
##
File path:
build-utils/language-cs/src/main/resources/templates/cs/data-io-template.ftlh
##
@@ -0,0 +1,207 @@
+<#--
+ Licensed to the Apache Software Foun
sruehl commented on a change in pull request #232:
URL: https://github.com/apache/plc4x/pull/232#discussion_r609966179
##
File path:
build-utils/language-cs/src/main/resources/templates/cs/enum-template.ftlh
##
@@ -0,0 +1,85 @@
+<#--
+ Licensed to the Apache Software Foundati
sruehl commented on a change in pull request #232:
URL: https://github.com/apache/plc4x/pull/232#discussion_r609966411
##
File path:
build-utils/language-cs/src/main/resources/templates/cs/model-template.ftlh
##
@@ -0,0 +1,134 @@
+<#--
+ Licensed to the Apache Software Founda
sruehl commented on pull request #219:
URL: https://github.com/apache/plc4x/pull/219#issuecomment-816031169
@ottlukas maybe it might be a good idea to just rebase this branch onto
develop as its really hard to see whats contained within this branch. Should be
fairly easy with the interacti
ottlukas commented on pull request #219:
URL: https://github.com/apache/plc4x/pull/219#issuecomment-816039079
> @ottlukas maybe it might be a good idea to just rebase this branch onto
develop as its really hard to see whats contained within this branch. Should be
fairly easy with the inter
hutcheb opened a new pull request #235:
URL: https://github.com/apache/plc4x/pull/235
Following on from adding variable string length to mspec it was now possible
to more easily add read/write support for strings.
Also removed a lot of the IEC61131 string indentifiers with opcua and
Sim
sruehl commented on pull request #235:
URL: https://github.com/apache/plc4x/pull/235#issuecomment-817077070
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For querie
sruehl merged pull request #235:
URL: https://github.com/apache/plc4x/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
sruehl commented on pull request #233:
URL: https://github.com/apache/plc4x/pull/233#issuecomment-817077288
@thomas169 is this still a WIP/Draft pull request? If yes I can mark it as
such
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
sruehl commented on pull request #201:
URL: https://github.com/apache/plc4x/pull/201#issuecomment-817078332
2 Points reading your comment @splatch:
1. @chrisdutz has a valid point with moving that to the SPI
2. Regarding the "does it compile" comment: Maybe bind/use the fields in
sruehl commented on pull request #177:
URL: https://github.com/apache/plc4x/pull/177#issuecomment-817078429
do we still need this PR? Looks pretty empty to me atm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
sruehl commented on pull request #219:
URL: https://github.com/apache/plc4x/pull/219#issuecomment-817089562
I merge this now into a temporary branch and try to cleanup the history
there,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sruehl merged pull request #219:
URL: https://github.com/apache/plc4x/pull/219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
thomas169 commented on pull request #233:
URL: https://github.com/apache/plc4x/pull/233#issuecomment-817207229
Yeh still WIP. Write arrays (e.g. UINT[2]) work, but not sure the way I
implemented this is how it was intended to be. As write response items are
still unchecked / unused it's st
hutcheb opened a new pull request #236:
URL: https://github.com/apache/plc4x/pull/236
Underestimated the amount of work required for this.
I have another branch fix/modbus_string which has a working implementation
for Java. it uses the format that the S7 driver uses
41:STRING(
hutcheb opened a new pull request #237:
URL: https://github.com/apache/plc4x/pull/237
Java implementation for modbus strings using the format 41:STRING(6)[3]
(6) is the string length
[3] is how many strings to read.
C and Go would need to be updated.
--
This is an autom
hutcheb opened a new pull request #238:
URL: https://github.com/apache/plc4x/pull/238
Following on from Chris's comment about using a standardized commit
comments, What are people thoughts on removing the merge button infavour of
squash when merging PR's?
--
This is an automated message
splatch commented on pull request #201:
URL: https://github.com/apache/plc4x/pull/201#issuecomment-818295134
The SPI is not an valid point, cause within SPI we have things such as
`PlcReader`, `PassiveDiscovery` and other implementation details which are
relevant from *driver* point of vie
splatch closed pull request #201:
URL: https://github.com/apache/plc4x/pull/201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
chrisdutz commented on pull request #233:
URL: https://github.com/apache/plc4x/pull/233#issuecomment-818599697
Hi Thomas,
a general question ... could you be so kind and sign up for the
dev@plc4x.apache.org list and tell us a bit about what you're up to?
Chris
--
This is a
Meng5 opened a new pull request #239:
URL: https://github.com/apache/plc4x/pull/239
fix S7 Driver read type of String with the address copied directly out of
TIA portal bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
thomas169 commented on pull request #233:
URL: https://github.com/apache/plc4x/pull/233#issuecomment-818636113
I already signed up, but sure, will message mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sruehl commented on pull request #239:
URL: https://github.com/apache/plc4x/pull/239#issuecomment-818639526
thanks for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
sruehl merged pull request #239:
URL: https://github.com/apache/plc4x/pull/239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
hutcheb opened a new pull request #240:
URL: https://github.com/apache/plc4x/pull/240
bug: abstract field's getter doesn't get get declared in base type
feat: fix for using virtual fields as discriminators
bug: integration tests can now be skipped with the -DskipTests switch
--
This
hutcheb merged pull request #236:
URL: https://github.com/apache/plc4x/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
sruehl commented on a change in pull request #240:
URL: https://github.com/apache/plc4x/pull/240#discussion_r613243838
##
File path:
build-utils/language-java/src/main/resources/templates/java/pojo-template.java.ftlh
##
@@ -23,7 +23,7 @@
<#-- @ftlvariable name="protocolName"
sruehl commented on a change in pull request #240:
URL: https://github.com/apache/plc4x/pull/240#discussion_r613244147
##
File path:
build-utils/language-java/src/main/resources/templates/java/pojo-template.java.ftlh
##
@@ -23,7 +23,7 @@
<#-- @ftlvariable name="protocolName"
sruehl commented on a change in pull request #240:
URL: https://github.com/apache/plc4x/pull/240#discussion_r613245819
##
File path:
build-utils/protocol-base-mspec/src/main/java/org/apache/plc4x/plugins/codegenerator/language/mspec/model/definitions/DefaultComplexTypeDefinition.java
sruehl merged pull request #240:
URL: https://github.com/apache/plc4x/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
splatch opened a new pull request #241:
URL: https://github.com/apache/plc4x/pull/241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
sruehl commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616418042
##
File path:
plc4j/drivers/canopen/src/main/java/org/apache/plc4x/java/canopen/CANOpenPlcDriver.java
##
@@ -111,8 +112,8 @@ protected BaseOptimizer getOptimi
chrisdutz commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616419965
##
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java
##
@@ -142,31 +141,86 @@ public
SingleProtoc
sruehl commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616445398
##
File path:
plc4j/drivers/canopen/src/main/java/org/apache/plc4x/java/canopen/CANOpenPlcDriver.java
##
@@ -111,8 +112,8 @@ protected BaseOptimizer getOptimi
sruehl commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616449259
##
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java
##
@@ -42,69 +47,57 @@
public class SingleProto
splatch commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616461714
##
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/EventListenerMessageCodec.java
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Fo
splatch commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616462636
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/EventPlcConnection.java
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundatio
splatch commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616462636
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/EventPlcConnection.java
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundatio
splatch commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616467389
##
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java
##
@@ -42,69 +47,57 @@
public class SingleProt
splatch commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616468290
##
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java
##
@@ -142,31 +141,86 @@ public
SingleProtocol
chrisdutz commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616472152
##
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/EventListenerMessageCodec.java
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software
sruehl commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616472268
##
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java
##
@@ -42,69 +47,57 @@
public class SingleProto
chrisdutz commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616474494
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/EventPlcConnection.java
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundat
chrisdutz commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616474494
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/EventPlcConnection.java
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundat
sruehl commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616478823
##
File path:
plc4j/api/src/main/java/org/apache/plc4x/java/api/EventPlcConnection.java
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation
sruehl commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616484062
##
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/connection/SingleProtocolStackConfigurer.java
##
@@ -42,69 +47,57 @@
public class SingleProto
splatch commented on a change in pull request #241:
URL: https://github.com/apache/plc4x/pull/241#discussion_r616485176
##
File path:
plc4j/drivers/canopen/src/main/java/org/apache/plc4x/java/canopen/CANOpenPlcDriver.java
##
@@ -111,8 +112,8 @@ protected BaseOptimizer getOptim
inigoao opened a new pull request #242:
URL: https://github.com/apache/plc4x/pull/242
Alpha version to record oriented Processors for reading PLC values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ottobackwards commented on pull request #242:
URL: https://github.com/apache/plc4x/pull/242#issuecomment-825737507
Can you squash or rebase this into a single commit to start?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
ottobackwards commented on a change in pull request #242:
URL: https://github.com/apache/plc4x/pull/242#discussion_r619312290
##
File path: plc4j/integrations/apache-nifi/README.md
##
@@ -0,0 +1,55 @@
+# PLC4X Apache NiFi Integration
+
+## Plc4xSinkProcessor
+
+## Plc4xSourcePr
ottobackwards commented on pull request #242:
URL: https://github.com/apache/plc4x/pull/242#issuecomment-825776396
Also, these processors should have additionalDetails.html so that there are
the extra help files ( with the information that you have in the readme ) for
each protocol proces
sruehl commented on pull request #238:
URL: https://github.com/apache/plc4x/pull/238#issuecomment-826283423
👍 we could try and in case we need the button back we can always re-enable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sruehl commented on pull request #238:
URL: https://github.com/apache/plc4x/pull/238#issuecomment-826283423
👍 we could try and in case we need the button back we can always re-enable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sruehl commented on pull request #233:
URL: https://github.com/apache/plc4x/pull/233#issuecomment-826740945
out of curiosity: as you marked it for ready for review and added changes to
it 7 days after: is it done done yet? If so maybe I would suggest that
@ottobackwards or @chrisdutz shoul
sruehl edited a comment on pull request #233:
URL: https://github.com/apache/plc4x/pull/233#issuecomment-826740945
out of curiosity: as you (@thomas169) marked it for ready for review and
added changes to it 7 days after: is it done done yet? If so maybe I would
suggest that @ottobackwards
thomas169 commented on pull request #233:
URL: https://github.com/apache/plc4x/pull/233#issuecomment-827089647
its done in relation to the title. But any commits to my fork also come into
this PR, hence the later 3 commits.
--
This is an automated message from the Apache Git Service.
To
inigoao commented on pull request #242:
URL: https://github.com/apache/plc4x/pull/242#issuecomment-827443150
thank you for all your comments @ottobackwards , i will review them and try
to answer and fix all issues.
--
This is an automated message from the Apache Git Service.
To respond
inigoao commented on a change in pull request #242:
URL: https://github.com/apache/plc4x/pull/242#discussion_r621009474
##
File path: plc4j/integrations/apache-nifi/README.md
##
@@ -0,0 +1,55 @@
+# PLC4X Apache NiFi Integration
+
+## Plc4xSinkProcessor
+
+## Plc4xSourceProcesso
hongjinlin opened a new pull request #243:
URL: https://github.com/apache/plc4x/pull/243
…nter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this servi
hutcheb merged pull request #238:
URL: https://github.com/apache/plc4x/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
sruehl merged pull request #243:
URL: https://github.com/apache/plc4x/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
sruehl commented on pull request #243:
URL: https://github.com/apache/plc4x/pull/243#issuecomment-830675041
thx for the PR 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
sruehl closed pull request #177:
URL: https://github.com/apache/plc4x/pull/177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
chrisdutz merged pull request #233:
URL: https://github.com/apache/plc4x/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
thomas169 opened a new pull request #244:
URL: https://github.com/apache/plc4x/pull/244
started resolving memory issues pulled up by valgrind.
Currently all IO leaks so doing IO in while loop crashes after not very long.
--
This is an automated message from the Apache Git Service.
To
thomas169 commented on pull request #244:
URL: https://github.com/apache/plc4x/pull/244#issuecomment-832676994
I have not verified changes to template result in what is needed (commend
mallocs for optional items), but quite sure it will be fine
--
This is an automated message from the Ap
thomas169 commented on pull request #244:
URL: https://github.com/apache/plc4x/pull/244#issuecomment-833558447
can now connect and disconnect wilthout leaks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
thomas169 commented on pull request #244:
URL: https://github.com/apache/plc4x/pull/244#issuecomment-835418261
IO now doesn't leak... so says valgrind.
Lots of changes in PR (I know I can commit now direclty) but would quite
like to keep memory alloc changes in this PR.
--
This is an
dependabot[bot] opened a new pull request #245:
URL: https://github.com/apache/plc4x/pull/245
Bumps karaf-maven-plugin from 4.3.0 to 4.3.2.
[ from 1.6.2
to 1.12.1.
Release notes
Sourced from https://github.com/groovy/GMavenPlus/releases";>gmavenplus-plugin's
relea
dependabot[bot] opened a new pull request #247:
URL: https://github.com/apache/plc4x/pull/247
Bumps zookeeper from 3.4.13 to 3.7.0.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.zookeeper:zookeeper
dependabot[bot] opened a new pull request #248:
URL: https://github.com/apache/plc4x/pull/248
Bumps `streampipes.version` from 0.66.0 to 0.67.0.
Updates `streampipes-wrapper` from 0.66.0 to 0.67.0
Release notes
Sourced from https://github.com/apache/incubator-streampipes/release
dependabot[bot] opened a new pull request #249:
URL: https://github.com/apache/plc4x/pull/249
Bumps jackson-datatype-jdk8 from 2.10.0 to 2.12.3.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.fasterxml.jac
chrisdutz commented on pull request #244:
URL: https://github.com/apache/plc4x/pull/244#issuecomment-846563921
What's the status on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
thomas169 commented on pull request #244:
URL: https://github.com/apache/plc4x/pull/244#issuecomment-846930078
It's finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
chrisdutz commented on pull request #244:
URL: https://github.com/apache/plc4x/pull/244#issuecomment-846937249
Aaah ok... Seems there are some conflicts... I'll have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chrisdutz commented on pull request #244:
URL: https://github.com/apache/plc4x/pull/244#issuecomment-846957194
Ok ... so I just pulled your latest changes and updated the branch with the
latest changes from develop ... it seems you commented out some code in the
code generation for optiona
thomas169 commented on pull request #244:
URL: https://github.com/apache/plc4x/pull/244#issuecomment-846964361
Okay the aim is to comment out optional field allocs in copt_packet.c and
s7_message.c as they get double alloc'd.
If other optional field allocs need to stay then I guess
chrisdutz commented on pull request #244:
URL: https://github.com/apache/plc4x/pull/244#issuecomment-846968624
So I just pushed the merged branches to "feature/plc4x-memory-cleanup" in
the official plc4x repo. As you are now a full committer, I think we should
continue there (makes the rev
chrisdutz commented on pull request #244:
URL: https://github.com/apache/plc4x/pull/244#issuecomment-846969455
Well I think only the parser can know if it needs to alloc memory for the
optional field. But code like this will always produce segfaults:
` //dataUnitReferenceNumber
401 - 500 of 2242 matches
Mail list logo
