hutcheb merged pull request #208:
URL: https://github.com/apache/plc4x/pull/208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
foxpluto opened a new pull request #209:
URL: https://github.com/apache/plc4x/pull/209
Hi,
I have tried to summarise the experience I did using the Cached pool2
library Julian wrote for Plc4x.
Merge with the code if you think this could be helpful.
Regards,
S.
splatch commented on a change in pull request #170:
URL: https://github.com/apache/plc4x/pull/170#discussion_r543316951
##
File path:
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##
@@ -136,32 +154,27 @@ public void
splatch commented on a change in pull request #170:
URL: https://github.com/apache/plc4x/pull/170#discussion_r543316951
##
File path:
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##
@@ -136,32 +154,27 @@ public void
hutcheb commented on a change in pull request #210:
URL: https://github.com/apache/plc4x/pull/210#discussion_r543293832
##
File path:
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java
##
@@ -30,30 +30,34 @@ Licensed to the Apache Software
splatch commented on pull request #201:
URL: https://github.com/apache/plc4x/pull/201#issuecomment-745250414
Ok, code is rebased to current develop and ready for further review.
This is an automated message from the Apache
splatch commented on a change in pull request #170:
URL: https://github.com/apache/plc4x/pull/170#discussion_r543318546
##
File path:
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##
@@ -69,7 +72,7 @@
*/
public class
splatch opened a new pull request #213:
URL: https://github.com/apache/plc4x/pull/213
There are small updates in EIP stuff which shouldn't break anything.
This is an automated message from the Apache Git Service.
To respond
hutcheb merged pull request #210:
URL: https://github.com/apache/plc4x/pull/210
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hutcheb commented on a change in pull request #210:
URL: https://github.com/apache/plc4x/pull/210#discussion_r545787037
##
File path:
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java
##
@@ -30,30 +30,34 @@ Licensed to the Apache Software
ottobackwards commented on a change in pull request #210:
URL: https://github.com/apache/plc4x/pull/210#discussion_r545796204
##
File path:
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java
##
@@ -30,30 +30,34 @@ Licensed to the Apache
hutcheb opened a new pull request #210:
URL: https://github.com/apache/plc4x/pull/210
Add support for data types specifier and add support for writing arrays.
This is an automated message from the Apache Git Service.
To
ottobackwards commented on a change in pull request #210:
URL: https://github.com/apache/plc4x/pull/210#discussion_r541602347
##
File path:
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java
##
@@ -30,30 +30,34 @@ Licensed to the Apache
ottlukas merged pull request #215:
URL: https://github.com/apache/plc4x/pull/215
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ottlukas opened a new pull request #215:
URL: https://github.com/apache/plc4x/pull/215
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ottlukas opened a new pull request #216:
URL: https://github.com/apache/plc4x/pull/216
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ottlukas merged pull request #216:
URL: https://github.com/apache/plc4x/pull/216
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ottobackwards commented on a change in pull request #214:
URL: https://github.com/apache/plc4x/pull/214#discussion_r546252292
##
File path:
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java
##
@@ -68,12 +69,14 @@ public static OpcuaField
hutcheb opened a new pull request #214:
URL: https://github.com/apache/plc4x/pull/214
Fix for connection string optional fields tcp and params.
This is an automated message from the Apache Git Service.
To respond to the
hutcheb commented on a change in pull request #214:
URL: https://github.com/apache/plc4x/pull/214#discussion_r546275899
##
File path:
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java
##
@@ -68,12 +69,14 @@ public static OpcuaField
splatch commented on pull request #211:
URL: https://github.com/apache/plc4x/pull/211#issuecomment-745469826
I've added necessary documentation and links. Awaiting Jenkins to complete
his job :pray:.
This is an automated
splatch merged pull request #211:
URL: https://github.com/apache/plc4x/pull/211
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
splatch edited a comment on pull request #201:
URL: https://github.com/apache/plc4x/pull/201#issuecomment-745244392
> If a user uses the driver module directly and directly instantiates the
custom driver field types, then his code is no longer portable
That's user decision how he
splatch commented on pull request #201:
URL: https://github.com/apache/plc4x/pull/201#issuecomment-745244392
> If a user uses the driver module directly and directly instantiates the
custom driver field types, then his code is no longer portable
That's user decision how he uses
splatch commented on pull request #170:
URL: https://github.com/apache/plc4x/pull/170#issuecomment-745236270
I've updated code so it works with recent develop. Now S7 driver should
properly handle timeouts.
This is an
chrisdutz commented on a change in pull request #170:
URL: https://github.com/apache/plc4x/pull/170#discussion_r543274480
##
File path:
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##
@@ -69,7 +72,7 @@
*/
public class
splatch opened a new pull request #212:
URL: https://github.com/apache/plc4x/pull/212
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ottlukas merged pull request #212:
URL: https://github.com/apache/plc4x/pull/212
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hutcheb merged pull request #214:
URL: https://github.com/apache/plc4x/pull/214
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
splatch opened a new pull request #211:
URL: https://github.com/apache/plc4x/pull/211
This is work in progress to finally merge canopen driver to develop branch.
This is an automated message from the Apache Git Service.
To
chrisdutz commented on a change in pull request #210:
URL: https://github.com/apache/plc4x/pull/210#discussion_r543164459
##
File path:
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java
##
@@ -30,30 +30,34 @@ Licensed to the Apache
hutcheb commented on a change in pull request #210:
URL: https://github.com/apache/plc4x/pull/210#discussion_r542054349
##
File path:
plc4j/drivers/opcua/src/main/java/org/apache/plc4x/java/opcua/protocol/OpcuaField.java
##
@@ -30,30 +30,34 @@ Licensed to the Apache Software
splatch commented on pull request #211:
URL: https://github.com/apache/plc4x/pull/211#issuecomment-745178213
> data-io-template doesn't break anything
It seems not, all the tests are working fine and it is aimed to help with
plain arrays. A lot of canopen stuff is mapped to
chrisdutz merged pull request #67:
URL: https://github.com/apache/plc4x/pull/67
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
splatch opened a new pull request #203:
URL: https://github.com/apache/plc4x/pull/203
I composed two commits - one is fix for missing `onTimeout` calls, second is
one which helped me finding bug.
I know we got couple of extra lines with extra classes in place of lambdas,
however
splatch commented on pull request #170:
URL: https://github.com/apache/plc4x/pull/170#issuecomment-723515410
I actually re-implemented your fixes in #203 . :-/
This is an automated message from the Apache Git Service.
To
splatch closed pull request #203:
URL: https://github.com/apache/plc4x/pull/203
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
splatch commented on pull request #203:
URL: https://github.com/apache/plc4x/pull/203#issuecomment-725743771
I am closing this one as it is now separated in PLC4X-258. Timeout fixes
will go under PLC4X-207.
This is an
splatch commented on pull request #170:
URL: https://github.com/apache/plc4x/pull/170#issuecomment-725745760
I've pushed changes I made for other PR hence this one needs to be
rebased/updated.
This is an automated message
hutcheb commented on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-731090926
Worked through the Confluent checklist as well as added tests and
documentation.
- The schema for the source has remained unchanged, I have brought the sink
connector schema
hutcheb commented on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-731115622
I've been going back and froth between changing the schema for the source
connector and the initial reason for it was so that we don't change the schema.
Avro and the schema
chrisdutz commented on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-731099735
As far as I know nobody is publicly using it ... :-/
This is an automated message from the Apache Git Service.
To
chrisdutz commented on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-731116108
This is definitely a valid scenario, so I would suggest to change it.
This is an automated message from the
chrisdutz edited a comment on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-731099735
As far as I know nobody is publicly using it ... :-/
So I would say: If it would be better to change things ... do it now before
we're actually listed in the
hutcheb merged pull request #204:
URL: https://github.com/apache/plc4x/pull/204
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chrisdutz commented on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-731605335
What do you mean with "their own property"? If it's "their own
configuration" and hereby their own kafka connect "instance" ... I strongly
object. The usecase where we first used
hutcheb commented on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-731599035
It might be a good idea to move all of the fields into their own property.
this way we won't run into issues with having pre-configured names such as
timestamp conflicting with
hutcheb commented on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-731631433
No sorry, something like:-
{
"fields": {
"running": false,
"conveyorStop": true,
..
hutcheb commented on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-731744353
Should be in a position to merge. I'll leave it open for comments for a day
or so.
This is an automated message
chrisdutz commented on a change in pull request #202:
URL: https://github.com/apache/plc4x/pull/202#discussion_r528386416
##
File path: plc4j/integrations/apache-kafka/README.md
##
@@ -60,7 +66,7 @@ In order to start a Kafka Connect system the following steps
have to be
chrisdutz commented on a change in pull request #202:
URL: https://github.com/apache/plc4x/pull/202#discussion_r528570143
##
File path: plc4j/integrations/apache-kafka/README.md
##
@@ -1,82 +1,190 @@
-
-
-# Kafka Connect PLC4X Connector
-
-The PLC4X Connector streams data from
hutcheb opened a new pull request #205:
URL: https://github.com/apache/plc4x/pull/205
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
hutcheb merged pull request #205:
URL: https://github.com/apache/plc4x/pull/205
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hutcheb opened a new pull request #206:
URL: https://github.com/apache/plc4x/pull/206
Testing
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
hutcheb commented on pull request #206:
URL: https://github.com/apache/plc4x/pull/206#issuecomment-732110516
Test Comment
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
hutcheb merged pull request #206:
URL: https://github.com/apache/plc4x/pull/206
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hutcheb merged pull request #202:
URL: https://github.com/apache/plc4x/pull/202
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hutcheb opened a new pull request #204:
URL: https://github.com/apache/plc4x/pull/204
Add support for IEC 61131 data types for the simulated driver.
Added mspec for simulated driver, this allows us to test a bit more of the
logic without having a device available.
ottobackwards commented on a change in pull request #200:
URL: https://github.com/apache/plc4x/pull/200#discussion_r516711853
##
File path:
plc4j/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSourceTask.java
##
@@ -219,7 +220,13 @@ public void stop() {
hutcheb opened a new pull request #200:
URL: https://github.com/apache/plc4x/pull/200
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
splatch opened a new pull request #201:
URL: https://github.com/apache/plc4x/pull/201
This is a follow up for earlier PLC4X-252 PR which brings same semantics to
subscription requests.
@chrisdutz Given that you commented on JIRA issue I believe you are valid
candidate for review.
hutcheb opened a new pull request #196:
URL: https://github.com/apache/plc4x/pull/196
- Setup user password file for OPC UA Server
- Add command line switches to handle creating users/passwords and self
signed certificates.
- OPC UA server encryption now works.
- Bumped Milo to
vemmert opened a new pull request #197:
URL: https://github.com/apache/plc4x/pull/197
Port of S7 Simotion data format to rel/0.6
This is an automated message from the Apache Git Service.
To respond to the message, please log
JulianFeinauer commented on pull request #197:
URL: https://github.com/apache/plc4x/pull/197#issuecomment-713585289
Thank you, @vemmert !
This is an automated message from the Apache Git Service.
To respond to the message,
JulianFeinauer merged pull request #197:
URL: https://github.com/apache/plc4x/pull/197
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ottobackwards merged pull request #200:
URL: https://github.com/apache/plc4x/pull/200
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
hutcheb opened a new pull request #202:
URL: https://github.com/apache/plc4x/pull/202
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ottobackwards commented on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-723055316
not sure what is up with the conflicts?
Also, do we have tests for this? kafka has test server classes etc, I can
point you to some examples
hutcheb commented on a change in pull request #200:
URL: https://github.com/apache/plc4x/pull/200#discussion_r517294440
##
File path:
plc4j/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSourceTask.java
##
@@ -219,7 +220,13 @@ public void stop() {
ottobackwards commented on pull request #202:
URL: https://github.com/apache/plc4x/pull/202#issuecomment-723244529
I think the tests stuff should be a follow on, please open an issue for
adding kafka integration tests
This
chrisdutz commented on pull request #213:
URL: https://github.com/apache/plc4x/pull/213#issuecomment-752657971
Hmm ok ... so you extended the API model classes with explicit serialization
code ... would it be possible to have this sort of outside of the API classes?
If included in the
splatch commented on a change in pull request #213:
URL: https://github.com/apache/plc4x/pull/213#discussion_r550367392
##
File path:
plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/readwrite/field/EipField.java
##
@@ -135,4 +138,27 @@ public String getPlcDataType()
chrisdutz commented on a change in pull request #213:
URL: https://github.com/apache/plc4x/pull/213#discussion_r550339759
##
File path:
plc4j/drivers/eip/src/main/java/org/apache/plc4x/java/eip/readwrite/field/EipField.java
##
@@ -135,4 +138,27 @@ public String
splatch commented on pull request #213:
URL: https://github.com/apache/plc4x/pull/213#issuecomment-752759973
> I would prefer the default Java XML DOM instead of Dom4j
Which place do you mean - plc field implementation or test framework?
JulianFeinauer opened a new pull request #217:
URL: https://github.com/apache/plc4x/pull/217
As discussed on List and Slack merged the repository
github.com/JulianFeinauer/plc4x-pool2/ into develop for Release 0.8.0.
This
ottobackwards commented on a change in pull request #219:
URL: https://github.com/apache/plc4x/pull/219#discussion_r553310611
##
File path: pyproject.toml
##
@@ -0,0 +1,14 @@
+[tool.poetry]
+name = "plc4x"
+version = "0.1.0"
+description = ""
Review comment:
I'm not
vemmert opened a new pull request #220:
URL: https://github.com/apache/plc4x/pull/220
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ottobackwards commented on pull request #220:
URL: https://github.com/apache/plc4x/pull/220#issuecomment-756798077
we are using poetry, you don't need the setup tools
poetry install && poetry build
This is an
ottobackwards commented on pull request #220:
URL: https://github.com/apache/plc4x/pull/220#issuecomment-756845943
As per our discussion, we need to do more to make this work in the scenarios:
new user not using mvn
new user using mvn
subsequent mvn builds
with regards
ottobackwards commented on pull request #220:
URL: https://github.com/apache/plc4x/pull/220#issuecomment-756798077
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hutcheb opened a new pull request #221:
URL: https://github.com/apache/plc4x/pull/221
Added call to disconnect when closing a connection.
This allows the connection to wait for the protocol to cleanly disconnect
before closing the channel.
ottobackwards commented on pull request #221:
URL: https://github.com/apache/plc4x/pull/221#issuecomment-757626947
+1, I think this is correct.
Two points though.
- It is not good that there are no tests for that, but I don't think that
is this PR's responsibility.
- This kind
ottobackwards commented on a change in pull request #225:
URL: https://github.com/apache/plc4x/pull/225#discussion_r561135913
##
File path:
plc4j/integrations/opcua-server/src/main/java/org/apache/plc4x/java/opcuaserver/backend/Plc4xCommunication.java
##
@@ -195,93 +169,110
chrisdutz commented on a change in pull request #225:
URL: https://github.com/apache/plc4x/pull/225#discussion_r561090485
##
File path:
plc4j/integrations/opcua-server/src/main/java/org/apache/plc4x/java/opcuaserver/backend/Plc4xNamespace.java
##
@@ -1,11 +1,20 @@
/*
- *
hutcheb opened a new pull request #222:
URL: https://github.com/apache/plc4x/pull/222
https://repository.apache.org/content/repositories/snapshots/org/apache/plc4x/plc4j-apache-kafka/
This is an automated message from the
hutcheb merged pull request #222:
URL: https://github.com/apache/plc4x/pull/222
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hutcheb commented on a change in pull request #225:
URL: https://github.com/apache/plc4x/pull/225#discussion_r561792144
##
File path:
plc4j/integrations/opcua-server/src/main/java/org/apache/plc4x/java/opcuaserver/backend/Plc4xNamespace.java
##
@@ -1,11 +1,20 @@
/*
- *
hutcheb commented on a change in pull request #225:
URL: https://github.com/apache/plc4x/pull/225#discussion_r561792739
##
File path:
plc4j/integrations/opcua-server/src/main/java/org/apache/plc4x/java/opcuaserver/backend/Plc4xCommunication.java
##
@@ -115,9 +71,27 @@
hutcheb commented on pull request #225:
URL: https://github.com/apache/plc4x/pull/225#issuecomment-764564895
Otto, all good ideas, I have updated the code.
This is an automated message from the Apache Git Service.
To
hutcheb merged pull request #225:
URL: https://github.com/apache/plc4x/pull/225
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ottobackwards commented on a change in pull request #225:
URL: https://github.com/apache/plc4x/pull/225#discussion_r561843725
##
File path:
plc4j/integrations/opcua-server/src/main/java/org/apache/plc4x/java/opcuaserver/backend/Plc4xCommunication.java
##
@@ -65,6 +65,7 @@
chrisdutz commented on a change in pull request #223:
URL: https://github.com/apache/plc4x/pull/223#discussion_r558948467
##
File path: pom.xml
##
@@ -679,10 +679,13 @@
**/UNLICENSE
**/Expression.g4
+
hutcheb opened a new pull request #224:
URL: https://github.com/apache/plc4x/pull/224
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
hutcheb opened a new pull request #223:
URL: https://github.com/apache/plc4x/pull/223
To take into account for derivative works licenses under EPL 2.0
This is an automated message from the Apache Git Service.
To respond to
chrisdutz merged pull request #223:
URL: https://github.com/apache/plc4x/pull/223
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ottobackwards commented on a change in pull request #225:
URL: https://github.com/apache/plc4x/pull/225#discussion_r561843725
##
File path:
plc4j/integrations/opcua-server/src/main/java/org/apache/plc4x/java/opcuaserver/backend/Plc4xCommunication.java
##
@@ -65,6 +65,7 @@
hutcheb commented on pull request #225:
URL: https://github.com/apache/plc4x/pull/225#issuecomment-764564895
Otto, all good ideas, I have updated the code.
This is an automated message from the Apache Git Service.
To
hutcheb merged pull request #225:
URL: https://github.com/apache/plc4x/pull/225
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hutcheb commented on a change in pull request #225:
URL: https://github.com/apache/plc4x/pull/225#discussion_r561792144
##
File path:
plc4j/integrations/opcua-server/src/main/java/org/apache/plc4x/java/opcuaserver/backend/Plc4xNamespace.java
##
@@ -1,11 +1,20 @@
/*
- *
hutcheb opened a new pull request #225:
URL: https://github.com/apache/plc4x/pull/225
I've added the Encryption handler for the OPC UA server and re-wrote some of
the logic. I have worked on a add just what we need to the logic, we can build
from here.
If an error occurs, in some
501 - 600 of 2116 matches
Mail list logo
