[GitHub] [plc4x] inigoao commented on a change in pull request #257: Feature/nifi record

2021-10-25 Thread GitBox
inigoao commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r735692177 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessorTest.java ## @@ -0,0 +1,104

[GitHub] [plc4x] inigoao commented on a change in pull request #257: Feature/nifi record

2021-10-25 Thread GitBox
inigoao commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r735693008 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessorTest.java ## @@ -0,0 +1,104

[GitHub] [plc4x] inigoao commented on a change in pull request #257: Feature/nifi record

2021-10-25 Thread GitBox
inigoao commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r735693457 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/record/Plc4xReadResponseRecordSet.java ## @@ -0,0 +1,1

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-10-29 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r739580930 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/BasePlc4xProcessor.java ## @@ -89,13 +110,13 @@

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-10-29 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r739581708 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/BasePlc4xProcessor.java ## @@ -142,6 +163,7 @@ p

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-10-29 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r739581790 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessor.java ## @@ -154,11 +1

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-10-29 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r739581853 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/main/java/org/apache/plc4x/nifi/Plc4xSourceRecordProcessor.java ## @@ -180,18 +2

[GitHub] [plc4x] ottobackwards commented on a change in pull request #257: Feature/nifi record

2021-10-29 Thread GitBox
ottobackwards commented on a change in pull request #257: URL: https://github.com/apache/plc4x/pull/257#discussion_r739582483 ## File path: plc4j/integrations/apache-nifi/nifi-plc4x-processors/src/test/java/org/apache/plc4x/nifi/util/Plc4xSchemaTest.java ## @@ -0,0 +1,125 @@ +

[GitHub] [plc4x] hutcheb opened a new pull request #284: Fix/PLC4X 303

2021-11-09 Thread GitBox
hutcheb opened a new pull request #284: URL: https://github.com/apache/plc4x/pull/284 Add back the support for the discovery parameter so that a different host name can be used than the one returned by the server within the endpoint description. Add initial skeleton for the XMlDrive

[GitHub] [plc4x-build-tools] hutcheb commented on pull request #7: fix typo

2021-11-09 Thread GitBox
hutcheb commented on pull request #7: URL: https://github.com/apache/plc4x-build-tools/pull/7#issuecomment-964460919 Hi @hboutemy, Thanks for picking this up. I checked the main PLC4X project and it isn't being used there, might be worth checking on the mailing list to confirm nobod

[GitHub] [plc4x] hutcheb opened a new pull request #285: Matching Pull request from type PR from the build tools.

2021-11-09 Thread GitBox
hutcheb opened a new pull request #285: URL: https://github.com/apache/plc4x/pull/285 Thought there was more than these typos for the generaton issue on the build tools -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [plc4x-build-tools] hutcheb merged pull request #7: fix typo

2021-11-10 Thread GitBox
hutcheb merged pull request #7: URL: https://github.com/apache/plc4x-build-tools/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [plc4x] hutcheb merged pull request #285: Matching Pull request from type PR from the build tools.

2021-11-10 Thread GitBox
hutcheb merged pull request #285: URL: https://github.com/apache/plc4x/pull/285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pl

[GitHub] [plc4x] rmeister commented on pull request #265: Subscriptions for ADS in PLC4J

2021-11-12 Thread GitBox
rmeister commented on pull request #265: URL: https://github.com/apache/plc4x/pull/265#issuecomment-967259531 Finally, I had some time to come back to this. Our TwinCat version is 2.11.0 (Build 2623). @splatch I took your test code with this handler: ``` r.getSubscriptionHandl

[GitHub] [plc4x] rmeister edited a comment on pull request #265: Subscriptions for ADS in PLC4J

2021-11-12 Thread GitBox
rmeister edited a comment on pull request #265: URL: https://github.com/apache/plc4x/pull/265#issuecomment-967259531 Finally, I had some time to come back to this. Our TwinCat version is 2.11.2306 @splatch I took your test code with this handler: ``` r.getSubscriptionHandle("f

[GitHub] [plc4x] splatch commented on pull request #265: Subscriptions for ADS in PLC4J

2021-11-12 Thread GitBox
splatch commented on pull request #265: URL: https://github.com/apache/plc4x/pull/265#issuecomment-967282739 > Finally, I had some time to come back to this. Our TwinCat version is 2.11.2306 > > @splatch I took your test code with this handler: > > ``` > r.getSubscriptionHa

[GitHub] [plc4x] rmeister opened a new pull request #286: plc4j-protocol-ads: fix encodeBigInteger in LittleEndianEncoder

2021-11-15 Thread GitBox
rmeister opened a new pull request #286: URL: https://github.com/apache/plc4x/pull/286 Hi, writing some WORDs with ADS gave me odd results. This is how I've tested my fix: ``` byte[] convertToByteArrayLE(BigInteger bigIntValue, int targetSize){ byte[] bytes = bigIntValu

[GitHub] [plc4x] glcj opened a new pull request #287: S7szl

2021-11-16 Thread GitBox
glcj opened a new pull request #287: URL: https://github.com/apache/plc4x/pull/287 Add the possibility of: 1. Subscribe to Alarm8. 2. Recognition of events. 3. Alarm text processing. 4. Subscription to cyclical values. 5. Diagnostic Record Readings (SZL). 6. Proposal for do

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #8: Bump maven.version from 3.3.9 to 3.8.3

2021-11-17 Thread GitBox
dependabot[bot] opened a new pull request #8: URL: https://github.com/apache/plc4x-build-tools/pull/8 Bumps `maven.version` from 3.3.9 to 3.8.3. Updates `maven-plugin-api` from 3.3.9 to 3.8.3 Commits https://github.com/apache/maven/commit/ff8e977a158738155dc465c6a97ffaf31982

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #9: Bump junit from 4.12 to 4.13.2

2021-11-18 Thread GitBox
dependabot[bot] opened a new pull request #9: URL: https://github.com/apache/plc4x-build-tools/pull/9 Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.2. Release notes Sourced from https://github.com/junit-team/junit4/releases";>junit's releases. JUnit

[GitHub] [plc4x-build-tools] dependabot[bot] commented on pull request #8: Bump maven.version from 3.3.9 to 3.8.3

2021-11-21 Thread GitBox
dependabot[bot] commented on pull request #8: URL: https://github.com/apache/plc4x-build-tools/pull/8#issuecomment-975067343 Superseded by #10. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #10: Bump maven.version from 3.3.9 to 3.8.4

2021-11-21 Thread GitBox
dependabot[bot] opened a new pull request #10: URL: https://github.com/apache/plc4x-build-tools/pull/10 Bumps `maven.version` from 3.3.9 to 3.8.4. Updates `maven-plugin-api` from 3.3.9 to 3.8.4 Commits https://github.com/apache/maven/commit/9b656c72d54e5bacbed989b64718c159fe

[GitHub] [plc4x-build-tools] dependabot[bot] closed pull request #8: Bump maven.version from 3.3.9 to 3.8.3

2021-11-21 Thread GitBox
dependabot[bot] closed pull request #8: URL: https://github.com/apache/plc4x-build-tools/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #11: Bump commons-lang3 from 3.9 to 3.12.0

2021-11-22 Thread GitBox
dependabot[bot] opened a new pull request #11: URL: https://github.com/apache/plc4x-build-tools/pull/11 Bumps commons-lang3 from 3.9 to 3.12.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.commons

[GitHub] [plc4x-build-tools] sruehl merged pull request #9: Bump junit from 4.12 to 4.13.2

2021-11-24 Thread GitBox
sruehl merged pull request #9: URL: https://github.com/apache/plc4x-build-tools/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[GitHub] [plc4x-build-tools] sruehl merged pull request #10: Bump maven.version from 3.3.9 to 3.8.4

2021-11-24 Thread GitBox
sruehl merged pull request #10: URL: https://github.com/apache/plc4x-build-tools/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [plc4x-build-tools] sruehl merged pull request #11: Bump commons-lang3 from 3.9 to 3.12.0

2021-11-24 Thread GitBox
sruehl merged pull request #11: URL: https://github.com/apache/plc4x-build-tools/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [plc4x] hutcheb merged pull request #284: Fix/PLC4X 303

2021-11-24 Thread GitBox
hutcheb merged pull request #284: URL: https://github.com/apache/plc4x/pull/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pl

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #12: Bump maven.version from 3.6.3 to 3.8.4

2021-11-25 Thread GitBox
dependabot[bot] opened a new pull request #12: URL: https://github.com/apache/plc4x-build-tools/pull/12 Bumps `maven.version` from 3.6.3 to 3.8.4. Updates `maven-plugin-api` from 3.6.3 to 3.8.4 Commits https://github.com/apache/maven/commit/9b656c72d54e5bacbed989b64718c159fe

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #13: build(deps): bump maven-plugin-plugin from 3.6.1 to 3.6.2

2021-11-28 Thread GitBox
dependabot[bot] opened a new pull request #13: URL: https://github.com/apache/plc4x-build-tools/pull/13 Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.6.1 to 3.6.2. Commits https://github.com/apache/maven-plugin-tools/commit/c813ad9883dce7d449

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #14: build(deps): bump maven-plugin-annotations from 3.6.0 to 3.6.2

2021-11-28 Thread GitBox
dependabot[bot] opened a new pull request #14: URL: https://github.com/apache/plc4x-build-tools/pull/14 Bumps [maven-plugin-annotations](https://github.com/apache/maven-plugin-tools) from 3.6.0 to 3.6.2. Commits https://github.com/apache/maven-plugin-tools/commit/c813ad9883dc

[GitHub] [plc4x] markus-franke opened a new pull request #288: Fix documentation for S7 short address format

2021-12-01 Thread GitBox
markus-franke opened a new pull request #288: URL: https://github.com/apache/plc4x/pull/288 subtle difference making a big change ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #15: build(deps): bump commons-beanutils from 1.9.3 to 1.9.4

2021-12-02 Thread GitBox
dependabot[bot] opened a new pull request #15: URL: https://github.com/apache/plc4x-build-tools/pull/15 Bumps commons-beanutils from 1.9.3 to 1.9.4. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-beanu

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #16: build(deps): bump commons-io from 2.6 to 2.11.0

2021-12-02 Thread GitBox
dependabot[bot] opened a new pull request #16: URL: https://github.com/apache/plc4x-build-tools/pull/16 Bumps commons-io from 2.6 to 2.11.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-io:commons-io

[GitHub] [plc4x] dependabot[bot] opened a new pull request #289: build(deps): bump scala-library from 2.13.6 to 2.13.7

2021-12-02 Thread GitBox
dependabot[bot] opened a new pull request #289: URL: https://github.com/apache/plc4x/pull/289 Bumps [scala-library](https://github.com/scala/scala) from 2.13.6 to 2.13.7. Release notes Sourced from https://github.com/scala/scala/releases";>scala-library's releases. Scala 2.

[GitHub] [plc4x] dependabot[bot] commented on pull request #277: build(deps): bump scala-library from 2.10.7 to 2.13.6

2021-12-02 Thread GitBox
dependabot[bot] commented on pull request #277: URL: https://github.com/apache/plc4x/pull/277#issuecomment-985243901 Superseded by #289. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [plc4x] dependabot[bot] closed pull request #277: build(deps): bump scala-library from 2.10.7 to 2.13.6

2021-12-02 Thread GitBox
dependabot[bot] closed pull request #277: URL: https://github.com/apache/plc4x/pull/277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [plc4x] sruehl commented on pull request #288: Fix documentation for S7 short address format

2021-12-03 Thread GitBox
sruehl commented on pull request #288: URL: https://github.com/apache/plc4x/pull/288#issuecomment-985715226 Thanks for the PR :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [plc4x] sruehl merged pull request #288: Fix documentation for S7 short address format

2021-12-03 Thread GitBox
sruehl merged pull request #288: URL: https://github.com/apache/plc4x/pull/288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl commented on pull request #289: build(deps): bump scala-library from 2.13.6 to 2.13.7

2021-12-03 Thread GitBox
sruehl commented on pull request #289: URL: https://github.com/apache/plc4x/pull/289#issuecomment-985715586 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [plc4x] sruehl commented on pull request #286: Fix/plc4j-protocol-ads

2021-12-03 Thread GitBox
sruehl commented on pull request #286: URL: https://github.com/apache/plc4x/pull/286#issuecomment-985719170 Thanks for the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [plc4x] sruehl merged pull request #286: Fix/plc4j-protocol-ads

2021-12-03 Thread GitBox
sruehl merged pull request #286: URL: https://github.com/apache/plc4x/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl merged pull request #278: build(deps): bump groovy.version from 3.0.8 to 3.0.9

2021-12-03 Thread GitBox
sruehl merged pull request #278: URL: https://github.com/apache/plc4x/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl merged pull request #282: build(deps): bump jaxb-runtime from 2.3.3 to 3.0.2

2021-12-03 Thread GitBox
sruehl merged pull request #282: URL: https://github.com/apache/plc4x/pull/282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl merged pull request #280: build(deps): bump nifi.version from 1.13.2 to 1.14.0

2021-12-03 Thread GitBox
sruehl merged pull request #280: URL: https://github.com/apache/plc4x/pull/280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl merged pull request #279: build(deps): bump jna from 5.8.0 to 5.9.0

2021-12-03 Thread GitBox
sruehl merged pull request #279: URL: https://github.com/apache/plc4x/pull/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl merged pull request #289: build(deps): bump scala-library from 2.13.6 to 2.13.7

2021-12-03 Thread GitBox
sruehl merged pull request #289: URL: https://github.com/apache/plc4x/pull/289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl commented on a change in pull request #265: Subscriptions for ADS in PLC4J

2021-12-03 Thread GitBox
sruehl commented on a change in pull request #265: URL: https://github.com/apache/plc4x/pull/265#discussion_r762143901 ## File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec ## @@ -281,7 +281,8 @@ // 4 bytes The ADS server checks if the value change

[GitHub] [plc4x] sruehl commented on a change in pull request #265: Subscriptions for ADS in PLC4J

2021-12-03 Thread GitBox
sruehl commented on a change in pull request #265: URL: https://github.com/apache/plc4x/pull/265#discussion_r762144476 ## File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec ## @@ -281,7 +281,8 @@ // 4 bytes The ADS server checks if the value change

[GitHub] [plc4x] chrisdutz commented on a change in pull request #265: Subscriptions for ADS in PLC4J

2021-12-03 Thread GitBox
chrisdutz commented on a change in pull request #265: URL: https://github.com/apache/plc4x/pull/265#discussion_r762148676 ## File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec ## @@ -281,7 +281,8 @@ // 4 bytes The ADS server checks if the value cha

[GitHub] [plc4x] chrisdutz commented on a change in pull request #265: Subscriptions for ADS in PLC4J

2021-12-03 Thread GitBox
chrisdutz commented on a change in pull request #265: URL: https://github.com/apache/plc4x/pull/265#discussion_r762149525 ## File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec ## @@ -281,7 +281,8 @@ // 4 bytes The ADS server checks if the value cha

[GitHub] [plc4x] sruehl commented on a change in pull request #265: Subscriptions for ADS in PLC4J

2021-12-03 Thread GitBox
sruehl commented on a change in pull request #265: URL: https://github.com/apache/plc4x/pull/265#discussion_r762151013 ## File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec ## @@ -281,7 +281,8 @@ // 4 bytes The ADS server checks if the value change

[GitHub] [plc4x] rmeister commented on a change in pull request #265: Subscriptions for ADS in PLC4J

2021-12-03 Thread GitBox
rmeister commented on a change in pull request #265: URL: https://github.com/apache/plc4x/pull/265#discussion_r762232280 ## File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec ## @@ -281,7 +281,8 @@ // 4 bytes The ADS server checks if the value chan

[GitHub] [plc4x] chrisdutz commented on a change in pull request #265: Subscriptions for ADS in PLC4J

2021-12-04 Thread GitBox
chrisdutz commented on a change in pull request #265: URL: https://github.com/apache/plc4x/pull/265#discussion_r762417456 ## File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec ## @@ -281,7 +281,8 @@ // 4 bytes The ADS server checks if the value cha

[GitHub] [plc4x] chrisdutz commented on a change in pull request #265: Subscriptions for ADS in PLC4J

2021-12-04 Thread GitBox
chrisdutz commented on a change in pull request #265: URL: https://github.com/apache/plc4x/pull/265#discussion_r762417456 ## File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec ## @@ -281,7 +281,8 @@ // 4 bytes The ADS server checks if the value cha

[GitHub] [plc4x] chrisdutz commented on a change in pull request #265: Subscriptions for ADS in PLC4J

2021-12-04 Thread GitBox
chrisdutz commented on a change in pull request #265: URL: https://github.com/apache/plc4x/pull/265#discussion_r762417456 ## File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec ## @@ -281,7 +281,8 @@ // 4 bytes The ADS server checks if the value cha

[GitHub] [plc4x] sruehl commented on a change in pull request #265: Subscriptions for ADS in PLC4J

2021-12-04 Thread GitBox
sruehl commented on a change in pull request #265: URL: https://github.com/apache/plc4x/pull/265#discussion_r762418132 ## File path: protocols/ads/src/main/resources/protocols/ads/ads.mspec ## @@ -281,7 +281,8 @@ // 4 bytes The ADS server checks if the value change

[GitHub] [plc4x] sruehl merged pull request #265: Subscriptions for ADS in PLC4J

2021-12-04 Thread GitBox
sruehl merged pull request #265: URL: https://github.com/apache/plc4x/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] chrisdutz commented on pull request #287: S7szl

2021-12-04 Thread GitBox
chrisdutz commented on pull request #287: URL: https://github.com/apache/plc4x/pull/287#issuecomment-986018818 LGTM ... only thing I didn't quite understand is why a subscription field has multiple fields inside. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [plc4x] sruehl commented on pull request #287: S7szl

2021-12-04 Thread GitBox
sruehl commented on pull request #287: URL: https://github.com/apache/plc4x/pull/287#issuecomment-986019946 I try to resolve the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [plc4x] sruehl commented on pull request #287: S7szl

2021-12-04 Thread GitBox
sruehl commented on pull request #287: URL: https://github.com/apache/plc4x/pull/287#issuecomment-986024911 ok might be easier to rebase this... Merge was bit hard an I aborted it due to time constraints... -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [plc4x] dependabot[bot] opened a new pull request #290: build(deps): bump jffi from 1.2.17 to 1.3.8

2021-12-05 Thread GitBox
dependabot[bot] opened a new pull request #290: URL: https://github.com/apache/plc4x/pull/290 Bumps [jffi](https://github.com/jnr/jffi) from 1.2.17 to 1.3.8. Commits https://github.com/jnr/jffi/commit/b6ad5c066a6346072ea04f8ffa8177204aadcb13";>b6ad5c0 [maven-release-plugin] pr

[GitHub] [plc4x] glcj commented on pull request #287: S7szl

2021-12-06 Thread GitBox
glcj commented on pull request #287: URL: https://github.com/apache/plc4x/pull/287#issuecomment-986927058 Hello, I do not see the changes in the development branch, is this PR for revision? Grateful for your time, -- This is an automated message from the Apache Git Service. To respo

[GitHub] [plc4x] sruehl commented on pull request #287: S7szl

2021-12-06 Thread GitBox
sruehl commented on pull request #287: URL: https://github.com/apache/plc4x/pull/287#issuecomment-986935364 no I tried the rebase locally and noticed that it might be easier to rebase the changes onto current develop. Due to timeconstraints I couldn't finish it in time. I try to finish it

[GitHub] [plc4x] dependabot[bot] opened a new pull request #291: build(deps): bump activemq-client from 5.15.12 to 5.16.3

2021-12-06 Thread GitBox
dependabot[bot] opened a new pull request #291: URL: https://github.com/apache/plc4x/pull/291 Bumps [activemq-client](https://github.com/apache/activemq) from 5.15.12 to 5.16.3. Commits https://github.com/apache/activemq/commit/50582306a758e37089ff6a4ec948361b032e71ce";>505823

[GitHub] [plc4x] dependabot[bot] opened a new pull request #292: build(deps): bump maven-artifact from 3.6.3 to 3.8.4

2021-12-07 Thread GitBox
dependabot[bot] opened a new pull request #292: URL: https://github.com/apache/plc4x/pull/292 Bumps [maven-artifact](https://github.com/apache/maven) from 3.6.3 to 3.8.4. Commits https://github.com/apache/maven/commit/9b656c72d54e5bacbed989b64718c159fe39b537";>9b656c7 [maven-r

[GitHub] [plc4x] dependabot[bot] opened a new pull request #293: build(deps): bump equalsverifier from 3.7.1 to 3.8

2021-12-07 Thread GitBox
dependabot[bot] opened a new pull request #293: URL: https://github.com/apache/plc4x/pull/293 Bumps [equalsverifier](https://github.com/jqno/equalsverifier) from 3.7.1 to 3.8. Changelog Sourced from https://github.com/jqno/equalsverifier/blob/main/CHANGELOG.md";>equalsverifier's

[GitHub] [plc4x] TorstenU opened a new pull request #294: Fix for empty Passwords

2021-12-08 Thread GitBox
TorstenU opened a new pull request #294: URL: https://github.com/apache/plc4x/pull/294 relates to https://issues.apache.org/jira/browse/PLC4X-303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [plc4x] hutcheb merged pull request #294: Fix for empty Passwords

2021-12-08 Thread GitBox
hutcheb merged pull request #294: URL: https://github.com/apache/plc4x/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pl

[GitHub] [plc4x] dependabot[bot] opened a new pull request #295: build(deps): bump protobuf-java from 3.6.1 to 3.19.1

2021-12-08 Thread GitBox
dependabot[bot] opened a new pull request #295: URL: https://github.com/apache/plc4x/pull/295 Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.6.1 to 3.19.1. Release notes Sourced from https://github.com/protocolbuffers/protobuf/releases";>protobuf-java's

[GitHub] [plc4x] shblue21 opened a new pull request #296: logback vulnerability (1.2.5 -> 1.2.9)

2021-12-22 Thread GitBox
shblue21 opened a new pull request #296: URL: https://github.com/apache/plc4x/pull/296 remote code execution vulnerability - https://cve.report/CVE-2021-42550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [plc4x] dependabot[bot] commented on pull request #290: build(deps): bump jffi from 1.2.17 to 1.3.8

2021-12-25 Thread GitBox
dependabot[bot] commented on pull request #290: URL: https://github.com/apache/plc4x/pull/290#issuecomment-1001040731 Looks like com.github.jnr:jffi:native is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [plc4x] dependabot[bot] closed pull request #293: build(deps): bump equalsverifier from 3.7.1 to 3.8

2021-12-25 Thread GitBox
dependabot[bot] closed pull request #293: URL: https://github.com/apache/plc4x/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [plc4x] dependabot[bot] commented on pull request #295: build(deps): bump protobuf-java from 3.6.1 to 3.19.1

2021-12-25 Thread GitBox
dependabot[bot] commented on pull request #295: URL: https://github.com/apache/plc4x/pull/295#issuecomment-1001040733 Looks like com.google.protobuf:protobuf-java is no longer a dependency, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [plc4x] dependabot[bot] closed pull request #290: build(deps): bump jffi from 1.2.17 to 1.3.8

2021-12-25 Thread GitBox
dependabot[bot] closed pull request #290: URL: https://github.com/apache/plc4x/pull/290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [plc4x] dependabot[bot] closed pull request #295: build(deps): bump protobuf-java from 3.6.1 to 3.19.1

2021-12-25 Thread GitBox
dependabot[bot] closed pull request #295: URL: https://github.com/apache/plc4x/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [plc4x] dependabot[bot] commented on pull request #293: build(deps): bump equalsverifier from 3.7.1 to 3.8

2021-12-25 Thread GitBox
dependabot[bot] commented on pull request #293: URL: https://github.com/apache/plc4x/pull/293#issuecomment-1001040738 Looks like nl.jqno.equalsverifier:equalsverifier is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [plc4x] dependabot[bot] opened a new pull request #297: build(deps): bump kafka.version from 3.0.0 to 7.0.1-ce

2021-12-26 Thread GitBox
dependabot[bot] opened a new pull request #297: URL: https://github.com/apache/plc4x/pull/297 Bumps `kafka.version` from 3.0.0 to 7.0.1-ce. Updates `kafka-clients` from 3.0.0 to 7.0.1-ce Updates `connect-api` from 3.0.0 to 7.0.1-ce Dependabot will resolve any conflicts w

[GitHub] [plc4x] dependabot[bot] commented on pull request #297: build(deps): bump kafka.version from 3.0.0 to 7.0.1-ce

2021-12-27 Thread GitBox
dependabot[bot] commented on pull request #297: URL: https://github.com/apache/plc4x/pull/297#issuecomment-1001574545 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a depend

[GitHub] [plc4x] chrisdutz closed pull request #297: build(deps): bump kafka.version from 3.0.0 to 7.0.1-ce

2021-12-27 Thread GitBox
chrisdutz closed pull request #297: URL: https://github.com/apache/plc4x/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] chrisdutz closed pull request #296: logback vulnerability (1.2.5 -> 1.2.9)

2021-12-27 Thread GitBox
chrisdutz closed pull request #296: URL: https://github.com/apache/plc4x/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] chrisdutz closed pull request #291: build(deps): bump activemq-client from 5.15.12 to 5.16.3

2021-12-27 Thread GitBox
chrisdutz closed pull request #291: URL: https://github.com/apache/plc4x/pull/291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] dependabot[bot] commented on pull request #292: build(deps): bump maven-artifact from 3.6.3 to 3.8.4

2021-12-27 Thread GitBox
dependabot[bot] commented on pull request #292: URL: https://github.com/apache/plc4x/pull/292#issuecomment-1001575219 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor versi

[GitHub] [plc4x] chrisdutz closed pull request #292: build(deps): bump maven-artifact from 3.6.3 to 3.8.4

2021-12-27 Thread GitBox
chrisdutz closed pull request #292: URL: https://github.com/apache/plc4x/pull/292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] dependabot[bot] opened a new pull request #298: build(deps): bump maven-enforcer-plugin from 3.0.0-M3 to 3.0.0

2021-12-28 Thread GitBox
dependabot[bot] opened a new pull request #298: URL: https://github.com/apache/plc4x/pull/298 Bumps [maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.0.0-M3 to 3.0.0. Commits https://github.com/apache/maven-enforcer/commit/b1b22822174bc92857a2e674c9a0240

[GitHub] [plc4x] hutcheb opened a new pull request #299: Add test for syncronized TransactionHandler

2022-01-04 Thread GitBox
hutcheb opened a new pull request #299: URL: https://github.com/apache/plc4x/pull/299 If the submit function in SecureChannelTransactionHandler is called again before the previous thread has finished then a message is added to the queue. As this method relies on it being called again with

[GitHub] [plc4x] hutcheb opened a new pull request #300: Bug/plc4x-330

2022-01-04 Thread GitBox
hutcheb opened a new pull request #300: URL: https://github.com/apache/plc4x/pull/300 I haven't been able to replicate it, but have changed the port number for the subscription handler tests. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [plc4x] dependabot[bot] opened a new pull request #301: build(deps): bump iot-device-client from 1.34.0 to 2.0.0-preview-002

2022-01-04 Thread GitBox
dependabot[bot] opened a new pull request #301: URL: https://github.com/apache/plc4x/pull/301 Bumps [iot-device-client](https://github.com/Azure/azure-iot-sdk-java) from 1.34.0 to 2.0.0-preview-002. Release notes Sourced from https://github.com/Azure/azure-iot-sdk-java/releases";>

[GitHub] [plc4x] dependabot[bot] opened a new pull request #302: build(deps): bump karaf-maven-plugin from 4.3.2 to 4.3.5

2022-01-05 Thread GitBox
dependabot[bot] opened a new pull request #302: URL: https://github.com/apache/plc4x/pull/302 Bumps karaf-maven-plugin from 4.3.2 to 4.3.5. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.karaf.tooli

[GitHub] [plc4x] hutcheb merged pull request #299: Add test for syncronized TransactionHandler

2022-01-06 Thread GitBox
hutcheb merged pull request #299: URL: https://github.com/apache/plc4x/pull/299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pl

[GitHub] [plc4x] dependabot[bot] opened a new pull request #303: build(deps): bump calcite-core.version from 1.28.0 to 1.29.0

2022-01-06 Thread GitBox
dependabot[bot] opened a new pull request #303: URL: https://github.com/apache/plc4x/pull/303 Bumps `calcite-core.version` from 1.28.0 to 1.29.0. Updates `calcite-core` from 1.28.0 to 1.29.0 Commits https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a83

[GitHub] [plc4x] dependabot[bot] opened a new pull request #304: build(deps): bump asciidoctor-maven-plugin from 2.1.0 to 2.2.1

2022-01-09 Thread GitBox
dependabot[bot] opened a new pull request #304: URL: https://github.com/apache/plc4x/pull/304 Bumps [asciidoctor-maven-plugin](https://github.com/asciidoctor/asciidoctor-maven-plugin) from 2.1.0 to 2.2.1. Release notes Sourced from https://github.com/asciidoctor/asciidoctor-maven

[GitHub] [plc4x-build-tools] dependabot[bot] commented on pull request #14: build(deps): bump maven-plugin-annotations from 3.6.0 to 3.6.2

2022-01-18 Thread GitBox
dependabot[bot] commented on pull request #14: URL: https://github.com/apache/plc4x-build-tools/pull/14#issuecomment-1016058301 Superseded by #17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [plc4x-build-tools] dependabot[bot] closed pull request #14: build(deps): bump maven-plugin-annotations from 3.6.0 to 3.6.2

2022-01-18 Thread GitBox
dependabot[bot] closed pull request #14: URL: https://github.com/apache/plc4x-build-tools/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #17: chore(deps): bump maven-plugin-annotations from 3.6.0 to 3.6.4

2022-01-18 Thread GitBox
dependabot[bot] opened a new pull request #17: URL: https://github.com/apache/plc4x-build-tools/pull/17 Bumps [maven-plugin-annotations](https://github.com/apache/maven-plugin-tools) from 3.6.0 to 3.6.4. Commits https://github.com/apache/maven-plugin-tools/commit/33eb6d9df8be

[GitHub] [plc4x] todoubaba opened a new pull request #305: Remove commons-beanutils

2022-01-19 Thread GitBox
todoubaba opened a new pull request #305: URL: https://github.com/apache/plc4x/pull/305 Remove commons-beanutils dependency, because Android does not have class java.beans.PropertyDescriptor. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [plc4x] chrisdutz commented on a change in pull request #305: Remove commons-beanutils

2022-01-21 Thread GitBox
chrisdutz commented on a change in pull request #305: URL: https://github.com/apache/plc4x/pull/305#discussion_r789644825 ## File path: plc4j/spi/src/main/java/org/apache/plc4x/java/spi/configuration/ConfigurationFactory.java ## @@ -178,63 +171,78 @@ private static Object toFi

[GitHub] [plc4x] chrisdutz commented on pull request #305: Remove commons-beanutils

2022-01-21 Thread GitBox
chrisdutz commented on pull request #305: URL: https://github.com/apache/plc4x/pull/305#issuecomment-1018539126 Please have a look at the tweaks I did ... but thank you very much for your PR :-) -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [plc4x] sruehl commented on pull request #305: Remove commons-beanutils

2022-01-21 Thread GitBox
sruehl commented on pull request #305: URL: https://github.com/apache/plc4x/pull/305#issuecomment-1018549163 @todoubaba please have a look on my response on the mailing list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [plc4x] sruehl commented on a change in pull request #305: Remove commons-beanutils

2022-01-21 Thread GitBox
sruehl commented on a change in pull request #305: URL: https://github.com/apache/plc4x/pull/305#discussion_r789702016 ## File path: plc4j/spi/pom.xml ## @@ -48,10 +48,6 @@ netty-transport - Review comment: please check if upstream can fix that.

<    3   4   5   6   7   8   9   10   11   12   >