[GitHub] [plc4x-build-tools] sruehl merged pull request #22: chore(deps): bump maven-javadoc-plugin from 3.3.1 to 3.3.2

2022-03-07 Thread GitBox
sruehl merged pull request #22: URL: https://github.com/apache/plc4x-build-tools/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [plc4x-build-tools] sruehl merged pull request #19: chore(deps): bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2

2022-03-07 Thread GitBox
sruehl merged pull request #19: URL: https://github.com/apache/plc4x-build-tools/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [plc4x-build-tools] sruehl merged pull request #20: chore(deps): bump maven-jar-plugin from 3.2.0 to 3.2.2

2022-03-07 Thread GitBox
sruehl merged pull request #20: URL: https://github.com/apache/plc4x-build-tools/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [plc4x-build-tools] sruehl merged pull request #21: chore(deps): bump maven-release-plugin from 3.0.0-M4 to 3.0.0-M5

2022-03-07 Thread GitBox
sruehl merged pull request #21: URL: https://github.com/apache/plc4x-build-tools/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #24: chore(deps): bump maven-site-plugin from 3.9.1 to 3.11.0

2022-03-07 Thread GitBox
dependabot[bot] opened a new pull request #24: URL: https://github.com/apache/plc4x-build-tools/pull/24 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.9.1 to 3.11.0. Release notes Sourced from https://github.com/apache/maven-site-plugin/releases";>ma

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #25: chore(deps): bump maven-compiler-plugin from 3.8.1 to 3.10.0

2022-03-07 Thread GitBox
dependabot[bot] opened a new pull request #25: URL: https://github.com/apache/plc4x-build-tools/pull/25 Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.8.1 to 3.10.0. Release notes Sourced from https://github.com/apache/maven-compiler-plugin/

[GitHub] [plc4x] oscerd opened a new pull request #331: Upgrade Apache Camel to version 3.14.1

2022-03-07 Thread GitBox
oscerd opened a new pull request #331: URL: https://github.com/apache/plc4x/pull/331 This is just a little upgrade. We are about to release 3.14.2. 3.14.x is an LTS branch, the next LTS will be 3.17.0, so I do think PLC4X will stay on 3.14.x for a while. -- This is an automated message

[GitHub] [plc4x] chrisdutz merged pull request #331: Upgrade Apache Camel to version 3.14.1

2022-03-08 Thread GitBox
chrisdutz merged pull request #331: URL: https://github.com/apache/plc4x/pull/331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] chrisdutz commented on pull request #331: Upgrade Apache Camel to version 3.14.1

2022-03-08 Thread GitBox
chrisdutz commented on pull request #331: URL: https://github.com/apache/plc4x/pull/331#issuecomment-1061539036 chore(plc4j/camel): Updated the camel dependency to 3.14.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [plc4x] oscerd commented on pull request #331: Upgrade Apache Camel to version 3.14.1

2022-03-08 Thread GitBox
oscerd commented on pull request #331: URL: https://github.com/apache/plc4x/pull/331#issuecomment-1061566814 I think the commit message is a bit misleading, it is 3.14.1 not 3.14.2, but I'm going to update. Do I remember correctly PLC4X community would like to donate the component to Apach

[GitHub] [plc4x] dependabot[bot] opened a new pull request #332: build(deps): bump influxdb-client-java from 4.0.0 to 4.3.0

2022-03-08 Thread GitBox
dependabot[bot] opened a new pull request #332: URL: https://github.com/apache/plc4x/pull/332 Bumps [influxdb-client-java](https://github.com/influxdata/influxdb-client-java) from 4.0.0 to 4.3.0. Release notes Sourced from https://github.com/influxdata/influxdb-client-java/releas

[GitHub] [plc4x] dependabot[bot] opened a new pull request #333: build(deps): bump awaitility from 4.1.1 to 4.2.0

2022-03-08 Thread GitBox
dependabot[bot] opened a new pull request #333: URL: https://github.com/apache/plc4x/pull/333 Bumps [awaitility](https://github.com/awaitility/awaitility) from 4.1.1 to 4.2.0. Changelog Sourced from https://github.com/awaitility/awaitility/blob/master/changelog.txt";>awaitility's

[GitHub] [plc4x] chrisdutz merged pull request #332: build(deps): bump influxdb-client-java from 4.0.0 to 4.3.0

2022-03-08 Thread GitBox
chrisdutz merged pull request #332: URL: https://github.com/apache/plc4x/pull/332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] chrisdutz merged pull request #333: build(deps): bump awaitility from 4.1.1 to 4.2.0

2022-03-08 Thread GitBox
chrisdutz merged pull request #333: URL: https://github.com/apache/plc4x/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #26: chore(deps): bump download-maven-plugin from 1.6.7 to 1.6.8

2022-03-09 Thread GitBox
dependabot[bot] opened a new pull request #26: URL: https://github.com/apache/plc4x-build-tools/pull/26 Bumps [download-maven-plugin](https://github.com/maven-download-plugin/maven-download-plugin) from 1.6.7 to 1.6.8. Release notes Sourced from https://github.com/maven-download-

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #27: chore(deps): bump maven-compiler-plugin from 3.8.1 to 3.10.1

2022-03-10 Thread GitBox
dependabot[bot] opened a new pull request #27: URL: https://github.com/apache/plc4x-build-tools/pull/27 Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.8.1 to 3.10.1. Release notes Sourced from https://github.com/apache/maven-compiler-plugin/

[GitHub] [plc4x-build-tools] dependabot[bot] closed pull request #25: chore(deps): bump maven-compiler-plugin from 3.8.1 to 3.10.0

2022-03-10 Thread GitBox
dependabot[bot] closed pull request #25: URL: https://github.com/apache/plc4x-build-tools/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [plc4x-build-tools] dependabot[bot] commented on pull request #25: chore(deps): bump maven-compiler-plugin from 3.8.1 to 3.10.0

2022-03-10 Thread GitBox
dependabot[bot] commented on pull request #25: URL: https://github.com/apache/plc4x-build-tools/pull/25#issuecomment-1064743430 Superseded by #27. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [plc4x] dependabot[bot] opened a new pull request #334: build(deps): bump mockito.version from 4.2.0 to 4.4.0

2022-03-10 Thread GitBox
dependabot[bot] opened a new pull request #334: URL: https://github.com/apache/plc4x/pull/334 Bumps `mockito.version` from 4.2.0 to 4.4.0. Updates `mockito-core` from 4.2.0 to 4.4.0 Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases

[GitHub] [plc4x-build-tools] dependabot[bot] closed pull request #23: chore(deps): bump maven.version from 3.6.3 to 3.8.4

2022-03-13 Thread GitBox
dependabot[bot] closed pull request #23: URL: https://github.com/apache/plc4x-build-tools/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [plc4x-build-tools] dependabot[bot] commented on pull request #23: chore(deps): bump maven.version from 3.6.3 to 3.8.4

2022-03-13 Thread GitBox
dependabot[bot] commented on pull request #23: URL: https://github.com/apache/plc4x-build-tools/pull/23#issuecomment-1066317446 Superseded by #28. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #28: chore(deps): bump maven.version from 3.6.3 to 3.8.5

2022-03-13 Thread GitBox
dependabot[bot] opened a new pull request #28: URL: https://github.com/apache/plc4x-build-tools/pull/28 Bumps `maven.version` from 3.6.3 to 3.8.5. Updates `maven-plugin-api` from 3.6.3 to 3.8.5 Release notes Sourced from https://github.com/apache/maven/releases";>maven-plugin-ap

[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request #29: chore(deps): bump maven-dependency-plugin from 3.2.0 to 3.3.0

2022-03-14 Thread GitBox
dependabot[bot] opened a new pull request #29: URL: https://github.com/apache/plc4x-build-tools/pull/29 Bumps [maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.2.0 to 3.3.0. Commits https://github.com/apache/maven-dependency-plugin/commit/e52

[GitHub] [plc4x] sruehl merged pull request #334: build(deps): bump mockito.version from 4.2.0 to 4.4.0

2022-03-15 Thread GitBox
sruehl merged pull request #334: URL: https://github.com/apache/plc4x/pull/334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] hongjinlin opened a new pull request #335: fix(plc4go/codegen): DefaultPlcWriteRequest interface conversion, cau…

2022-03-17 Thread GitBox
hongjinlin opened a new pull request #335: URL: https://github.com/apache/plc4x/pull/335 …se it not implement 1. Description: When I try to write more than one data, the program panic. > `... writeRequest, err := connection.WriteRequestBuilder().AddQuery("field1", "45:UINT", ui

[GitHub] [plc4x] dependabot[bot] opened a new pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-03-17 Thread GitBox
dependabot[bot] opened a new pull request #336: URL: https://github.com/apache/plc4x/pull/336 Bumps [maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.1.2 to 3.3.0. Commits https://github.com/apache/maven-dependency-plugin/commit/e52bc0248c00d

[GitHub] [plc4x] sruehl merged pull request #335: fix(plc4go/codegen): DefaultPlcWriteRequest interface conversion, cau…

2022-03-22 Thread GitBox
sruehl merged pull request #335: URL: https://github.com/apache/plc4x/pull/335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl commented on pull request #335: fix(plc4go/codegen): DefaultPlcWriteRequest interface conversion, cau…

2022-03-22 Thread GitBox
sruehl commented on pull request #335: URL: https://github.com/apache/plc4x/pull/335#issuecomment-1074945560 thanks for the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [plc4x] dependabot[bot] opened a new pull request #337: build(deps): bump spring-boot.version from 2.6.2 to 2.6.4

2022-03-23 Thread GitBox
dependabot[bot] opened a new pull request #337: URL: https://github.com/apache/plc4x/pull/337 Bumps `spring-boot.version` from 2.6.2 to 2.6.4. Updates `spring-boot-dependencies` from 2.6.2 to 2.6.4 Release notes Sourced from https://github.com/spring-projects/spring-boot/release

[GitHub] [plc4x] hongjinlin opened a new pull request #338: fix(plc4go/codegen): Truly close connection

2022-03-31 Thread GitBox
hongjinlin opened a new pull request #338: URL: https://github.com/apache/plc4x/pull/338 When closing the connection and reconnecting, it keeps reporting "Connection refused" error, and after checking, I found that the Close function does not really close the connection. -- This is an a

[GitHub] [plc4x] chrisdutz commented on pull request #338: fix(plc4go/codegen): Truly close connection

2022-03-31 Thread GitBox
chrisdutz commented on pull request #338: URL: https://github.com/apache/plc4x/pull/338#issuecomment-1084337933 Hi hongjinlin ... just one question ... as at Apache most communication is done via mailinglists ... could you please subscribe to the dev@plc4x.apache.org mailinglis (by sending

[GitHub] [plc4x] chrisdutz merged pull request #338: fix(plc4go/codegen): Truly close connection

2022-03-31 Thread GitBox
chrisdutz merged pull request #338: URL: https://github.com/apache/plc4x/pull/338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] chrisdutz commented on pull request #308: fix communication with LOGO 0AB7 and ISOonTCP tsap configuration

2022-03-31 Thread GitBox
chrisdutz commented on pull request #308: URL: https://github.com/apache/plc4x/pull/308#issuecomment-1084343316 Hi Svenk ... sorry so much for the long time noone did anything here ... had a bit of crazy times ... will try to merge your changes right away. -- This is an automated message

[GitHub] [plc4x] chrisdutz merged pull request #308: fix communication with LOGO 0AB7 and ISOonTCP tsap configuration

2022-03-31 Thread GitBox
chrisdutz merged pull request #308: URL: https://github.com/apache/plc4x/pull/308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [plc4x] hongjinlin commented on pull request #338: fix(plc4go/codegen): Truly close connection

2022-03-31 Thread GitBox
hongjinlin commented on pull request #338: URL: https://github.com/apache/plc4x/pull/338#issuecomment-1084357215 > I'll post when I have time, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [plc4x] hongjinlin commented on pull request #338: fix(plc4go/codegen): Truly close connection

2022-03-31 Thread GitBox
hongjinlin commented on pull request #338: URL: https://github.com/apache/plc4x/pull/338#issuecomment-1084359821 > Hi hongjinlin ... just one question ... as at Apache most communication is done via mailinglists ... could you please subscribe to the [dev@plc4x.apache.org](mailto:dev@plc4x.

[GitHub] [plc4x] hongjinlin removed a comment on pull request #338: fix(plc4go/codegen): Truly close connection

2022-03-31 Thread GitBox
hongjinlin removed a comment on pull request #338: URL: https://github.com/apache/plc4x/pull/338#issuecomment-1084357215 > I'll post when I have time, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [plc4x] sruehl commented on pull request #287: S7szl

2022-03-31 Thread GitBox
sruehl commented on pull request #287: URL: https://github.com/apache/plc4x/pull/287#issuecomment-1084392309 @glcj I propose to close this PR and you reopen a new one based on a branch in this repo (feature/s7_subscription. There you need to apply your changes manually and we try then to g

[GitHub] [plc4x] sruehl commented on pull request #169: Subscription Support for S7 Driver in 0.6.1

2022-03-31 Thread GitBox
sruehl commented on pull request #169: URL: https://github.com/apache/plc4x/pull/169#issuecomment-1084394426 closed because orphaned -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [plc4x] sruehl closed pull request #169: Subscription Support for S7 Driver in 0.6.1

2022-03-31 Thread GitBox
sruehl closed pull request #169: URL: https://github.com/apache/plc4x/pull/169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc

[GitHub] [plc4x] sruehl commented on pull request #257: Feature/nifi record

2022-03-31 Thread GitBox
sruehl commented on pull request #257: URL: https://github.com/apache/plc4x/pull/257#issuecomment-1084395772 setting to draft due to inactivity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [plc4x] sruehl commented on pull request #300: Bug/plc4x-330

2022-03-31 Thread GitBox
sruehl commented on pull request #300: URL: https://github.com/apache/plc4x/pull/300#issuecomment-1084399206 Is this done? Correct me if I'm wrong: I'm not sure if the last state was that you wanted to finish that. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [plc4x] alessandromnc94 opened a new pull request #339: Fix casting to byte for integer greater than 127 (byte is signed numb…

2022-03-31 Thread GitBox
alessandromnc94 opened a new pull request #339: URL: https://github.com/apache/plc4x/pull/339 …er and for string greater than 127 characters it result to NegativeIndexException). Edited only java version -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [plc4x] dependabot[bot] opened a new pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4

2022-03-31 Thread GitBox
dependabot[bot] opened a new pull request #340: URL: https://github.com/apache/plc4x/pull/340 Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 6.5.1 to 7.0.4. Release notes Sourced from https://github.com/jeremylong/DependencyCheck/releases";>dep

[GitHub] [plc4x] ottobackwards commented on pull request #339: Fix casting to byte for integer greater than 127 (byte is signed numb…

2022-04-01 Thread GitBox
ottobackwards commented on pull request #339: URL: https://github.com/apache/plc4x/pull/339#issuecomment-1085750478 Thanks for taking a look at this, can you please add a unit test for the behavior -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [plc4x] hutcheb opened a new pull request, #341: Feature/plc4py bh1

2022-04-04 Thread GitBox
hutcheb opened a new pull request, #341: URL: https://github.com/apache/plc4x/pull/341 Add Pluggy Framework Fixed type hinting issues with the help of mypy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [plc4x] hutcheb commented on pull request #341: Feature/plc4py bh1

2022-04-06 Thread GitBox
hutcheb commented on PR #341: URL: https://github.com/apache/plc4x/pull/341#issuecomment-1090586423 Thanks Otto, The Pluggy stuff definitely needs some work, I'm not happy with having to register the driver manually, kind of misses the point of using Pluggy. I spent a bit of ti

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #342: build(deps): bump slf4j.version from 1.7.32 to 1.7.36

2022-04-06 Thread GitBox
dependabot[bot] opened a new pull request, #342: URL: https://github.com/apache/plc4x/pull/342 Bumps `slf4j.version` from 1.7.32 to 1.7.36. Updates `slf4j-api` from 1.7.32 to 1.7.36 Commits https://github.com/qos-ch/slf4j/commit/e9ee55cca93c2bf26f14482a9bdf961c750d2a56";>e9ee

[GitHub] [plc4x] sruehl merged pull request #342: build(deps): bump slf4j.version from 1.7.32 to 1.7.36

2022-04-07 Thread GitBox
sruehl merged PR #342: URL: https://github.com/apache/plc4x/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org F

[GitHub] [plc4x] sruehl merged pull request #337: build(deps): bump spring-boot.version from 2.6.2 to 2.6.4

2022-04-07 Thread GitBox
sruehl merged PR #337: URL: https://github.com/apache/plc4x/pull/337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org F

[GitHub] [plc4x] sruehl commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-07 Thread GitBox
sruehl commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1091575142 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4

2022-04-07 Thread GitBox
sruehl commented on PR #340: URL: https://github.com/apache/plc4x/pull/340#issuecomment-1091575673 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl merged pull request #339: Fix casting to byte for integer greater than 127 (byte is signed numb…

2022-04-07 Thread GitBox
sruehl merged PR #339: URL: https://github.com/apache/plc4x/pull/339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org F

[GitHub] [plc4x] chrisdutz commented on pull request #266: Feature/modbusrtu

2022-04-07 Thread GitBox
chrisdutz commented on PR #266: URL: https://github.com/apache/plc4x/pull/266#issuecomment-1091593343 @hutcheb ... can this PR be closed and the corresponding branch be deleted? I think develop now has a working RTU driver ... -- This is an automated message from the Apache Git Service. T

[GitHub] [plc4x] chrisdutz commented on pull request #237: Fix/modbus string

2022-04-07 Thread GitBox
chrisdutz commented on PR #237: URL: https://github.com/apache/plc4x/pull/237#issuecomment-1091594296 @hutcheb Is this branch still valid? If yes, we would need to rebase it and port the changes back . -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [plc4x] ottobackwards commented on pull request #341: Feature/plc4py bh1

2022-04-07 Thread GitBox
ottobackwards commented on PR #341: URL: https://github.com/apache/plc4x/pull/341#issuecomment-1091634460 I don't think you have to register them manually, I think that they can register themselves using the setuptools / setup config. So, if we start out with 1 plc4py whl file, it's s

[GitHub] [plc4x] hutcheb closed pull request #266: Feature/modbusrtu

2022-04-07 Thread GitBox
hutcheb closed pull request #266: Feature/modbusrtu URL: https://github.com/apache/plc4x/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [plc4x] hutcheb closed pull request #237: Fix/modbus string

2022-04-07 Thread GitBox
hutcheb closed pull request #237: Fix/modbus string URL: https://github.com/apache/plc4x/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [plc4x] hutcheb commented on pull request #300: Bug/plc4x-330

2022-04-07 Thread GitBox
hutcheb commented on PR #300: URL: https://github.com/apache/plc4x/pull/300#issuecomment-1092057077 Looking at it, there's still a test disabled for OPCUA, which I believe is the cause for the issue in PLC4X-330 ` public void multipleThreads()` However this PR is a failed attem

[GitHub] [plc4x] hutcheb closed pull request #300: Bug/plc4x-330

2022-04-07 Thread GitBox
hutcheb closed pull request #300: Bug/plc4x-330 URL: https://github.com/apache/plc4x/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [plc4x] hutcheb opened a new pull request, #343: Feature/plc4py

2022-04-09 Thread GitBox
hutcheb opened a new pull request, #343: URL: https://github.com/apache/plc4x/pull/343 Merge plc4py into develop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [plc4x] hutcheb commented on pull request #343: Feature/plc4py

2022-04-09 Thread GitBox
hutcheb commented on PR #343: URL: https://github.com/apache/plc4x/pull/343#issuecomment-1094125758 Noting the Plc4Py Interop binding will be remove with this merge. If anyone has a concern we can put it back in if need be. -- This is an automated message from the Apache Git Service

[GitHub] [plc4x] hutcheb merged pull request #343: Feature/plc4py

2022-04-09 Thread GitBox
hutcheb merged PR #343: URL: https://github.com/apache/plc4x/pull/343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #344: build(deps): bump pyyaml from 5.3.1 to 5.4 in /sandbox/plc4py

2022-04-09 Thread GitBox
dependabot[bot] opened a new pull request, #344: URL: https://github.com/apache/plc4x/pull/344 Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4. Changelog Sourced from https://github.com/yaml/pyyaml/blob/master/CHANGES";>pyyaml's changelog. 5.4 (2021-01-19)

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #345: build(deps): bump zip4j from 2.9.1 to 2.10.0

2022-04-09 Thread GitBox
dependabot[bot] opened a new pull request, #345: URL: https://github.com/apache/plc4x/pull/345 Bumps [zip4j](https://github.com/srikanth-lingala/zip4j) from 2.9.1 to 2.10.0. Release notes Sourced from https://github.com/srikanth-lingala/zip4j/releases";>zip4j's releases. v2

[GitHub] [plc4x] hutcheb commented on pull request #341: Feature/plc4py bh1

2022-04-09 Thread GitBox
hutcheb commented on PR #341: URL: https://github.com/apache/plc4x/pull/341#issuecomment-1094148514 Yeah found a way forward with adding the plugins to the poetry config. I've also added an abtract class PlcConnectionLoader, almost feels a bit of a duplicate of the hookspec but I think it

[GitHub] [plc4x] hutcheb merged pull request #345: build(deps): bump zip4j from 2.9.1 to 2.10.0

2022-04-09 Thread GitBox
hutcheb merged PR #345: URL: https://github.com/apache/plc4x/pull/345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] ottobackwards commented on pull request #341: Feature/plc4py bh1

2022-04-10 Thread GitBox
ottobackwards commented on PR #341: URL: https://github.com/apache/plc4x/pull/341#issuecomment-1094288452 sounds great -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [plc4x] hutcheb merged pull request #341: Feature/plc4py bh1

2022-04-10 Thread GitBox
hutcheb merged PR #341: URL: https://github.com/apache/plc4x/pull/341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] hutcheb closed pull request #344: build(deps): bump pyyaml from 5.3.1 to 5.4 in /sandbox/plc4py

2022-04-10 Thread GitBox
hutcheb closed pull request #344: build(deps): bump pyyaml from 5.3.1 to 5.4 in /sandbox/plc4py URL: https://github.com/apache/plc4x/pull/344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [plc4x] dependabot[bot] commented on pull request #344: build(deps): bump pyyaml from 5.3.1 to 5.4 in /sandbox/plc4py

2022-04-10 Thread GitBox
dependabot[bot] commented on PR #344: URL: https://github.com/apache/plc4x/pull/344#issuecomment-1094356452 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0

2022-04-10 Thread GitBox
dependabot[bot] opened a new pull request, #346: URL: https://github.com/apache/plc4x/pull/346 Bumps [build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin) from 3.2.0 to 3.3.0. Release notes Sourced from https://github.com/mojohaus/build-helper-maven-pl

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #347: build(deps): bump maven-site-plugin from 3.9.1 to 3.11.0

2022-04-10 Thread GitBox
dependabot[bot] opened a new pull request, #347: URL: https://github.com/apache/plc4x/pull/347 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.9.1 to 3.11.0. Release notes Sourced from https://github.com/apache/maven-site-plugin/releases";>maven-site-p

[GitHub] [plc4x] chrisdutz closed pull request #347: build(deps): bump maven-site-plugin from 3.9.1 to 3.11.0

2022-04-11 Thread GitBox
chrisdutz closed pull request #347: build(deps): bump maven-site-plugin from 3.9.1 to 3.11.0 URL: https://github.com/apache/plc4x/pull/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [plc4x] dependabot[bot] commented on pull request #347: build(deps): bump maven-site-plugin from 3.9.1 to 3.11.0

2022-04-11 Thread GitBox
dependabot[bot] commented on PR #347: URL: https://github.com/apache/plc4x/pull/347#issuecomment-1095487236 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [plc4x] chrisdutz commented on pull request #347: build(deps): bump maven-site-plugin from 3.9.1 to 3.11.0

2022-04-11 Thread GitBox
chrisdutz commented on PR #347: URL: https://github.com/apache/plc4x/pull/347#issuecomment-1095487191 We can't update the site plugin as the asciidoctor plugin needs an update first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4

2022-04-12 Thread GitBox
dependabot[bot] opened a new pull request, #349: URL: https://github.com/apache/plc4x/pull/349 Bumps [checker-qual](https://github.com/typetools/checker-framework) from 3.10.0 to 3.21.4. Release notes Sourced from https://github.com/typetools/checker-framework/releases";>checker-qu

[GitHub] [plc4x] dependabot[bot] opened a new pull request, #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20

2022-04-12 Thread GitBox
dependabot[bot] opened a new pull request, #350: URL: https://github.com/apache/plc4x/pull/350 Bumps `kotlin.version` from 1.6.10 to 1.6.20. Updates `kotlin-stdlib` from 1.6.10 to 1.6.20 Release notes Sourced from https://github.com/JetBrains/kotlin/releases";>kotlin-stdlib's re

[GitHub] [plc4x] sruehl commented on pull request #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20

2022-04-12 Thread GitBox
sruehl commented on PR #350: URL: https://github.com/apache/plc4x/pull/350#issuecomment-1096905761 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4

2022-04-12 Thread GitBox
sruehl commented on PR #349: URL: https://github.com/apache/plc4x/pull/349#issuecomment-1096905887 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-12 Thread GitBox
sruehl commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1096906486 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0

2022-04-12 Thread GitBox
sruehl commented on PR #346: URL: https://github.com/apache/plc4x/pull/346#issuecomment-1096906163 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4

2022-04-12 Thread GitBox
sruehl commented on PR #340: URL: https://github.com/apache/plc4x/pull/340#issuecomment-1096906343 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] hutcheb commented on pull request #348: Started with the PlcReadRequest

2022-04-12 Thread GitBox
hutcheb commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1097232038 So I've ended up with abstract class such as this which allow you to pass return types, in this case it goes 3 or 4 deep before I create a concrete class. It seems to work but feels a bit clu

[GitHub] [plc4x] hutcheb commented on pull request #348: Started with the PlcReadRequest

2022-04-12 Thread GitBox
hutcheb commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1097270741 I also hate Circular dependancies, running into it with the PlcResponse and PlcRequest classes -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [plc4x] hutcheb commented on pull request #348: Started with the PlcReadRequest

2022-04-12 Thread GitBox
hutcheb commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1097279842 https://softwareengineering.stackexchange.com/questions/369146/how-to-avoid-bidirectional-class-and-module-dependencies -- This is an automated message from the Apache Git Service. To respo

[GitHub] [plc4x] sruehl commented on pull request #350: build(deps): bump kotlin.version from 1.6.10 to 1.6.20

2022-04-13 Thread GitBox
sruehl commented on PR #350: URL: https://github.com/apache/plc4x/pull/350#issuecomment-1097954949 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #349: build(deps): bump checker-qual from 3.10.0 to 3.21.4

2022-04-13 Thread GitBox
sruehl commented on PR #349: URL: https://github.com/apache/plc4x/pull/349#issuecomment-1097955065 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #346: build(deps): bump build-helper-maven-plugin from 3.2.0 to 3.3.0

2022-04-13 Thread GitBox
sruehl commented on PR #346: URL: https://github.com/apache/plc4x/pull/346#issuecomment-1097955199 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #340: build(deps): bump dependency-check-maven from 6.5.1 to 7.0.4

2022-04-13 Thread GitBox
sruehl commented on PR #340: URL: https://github.com/apache/plc4x/pull/340#issuecomment-1097955323 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] sruehl commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-13 Thread GitBox
sruehl commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1097955426 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [plc4x] ottlukas commented on pull request #348: Started with the PlcReadRequest

2022-04-13 Thread GitBox
ottlukas commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1098349503 > https://softwareengineering.stackexchange.com/questions/369146/how-to-avoid-bidirectional-class-and-module-dependencies I liked accepted answer: - Hide it with interfaces

[GitHub] [plc4x] hutcheb commented on pull request #348: Started with the PlcReadRequest

2022-04-13 Thread GitBox
hutcheb commented on PR #348: URL: https://github.com/apache/plc4x/pull/348#issuecomment-1098356403 I think an intermediary 'client' object makes more sense. I've pulled out the PlcResponse and PlcRequest stuff from the opposite class. In the Java version there's a PlcRequestContainer w

[GitHub] [plc4x] Dustone-JavaWeb opened a new pull request, #351: Bug Fix. Open too many files after complete

2022-04-18 Thread GitBox
Dustone-JavaWeb opened a new pull request, #351: URL: https://github.com/apache/plc4x/pull/351 Shutdown the workergroup. remove the final tag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [plc4x] chrisdutz merged pull request #351: Bug Fix. Open too many files after complete

2022-04-19 Thread GitBox
chrisdutz merged PR #351: URL: https://github.com/apache/plc4x/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-19 Thread GitBox
chrisdutz commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1102338322 The newer versions of the dependency-plugin still produce the false negatives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [plc4x] dependabot[bot] commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-19 Thread GitBox
dependabot[bot] commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1102338418 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [plc4x] chrisdutz closed pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-19 Thread GitBox
chrisdutz closed pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0 URL: https://github.com/apache/plc4x/pull/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [plc4x] chrisdutz commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-19 Thread GitBox
chrisdutz commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1102339127 @dependabot ignore this minor version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [plc4x] dependabot[bot] commented on pull request #336: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.3.0

2022-04-19 Thread GitBox
dependabot[bot] commented on PR #336: URL: https://github.com/apache/plc4x/pull/336#issuecomment-1102339191 OK, I won't notify you about version 3.3.x again, unless you re-open this PR or update to a 3.3.x release yourself. -- This is an automated message from the Apache Git Service. To r

<    5   6   7   8   9   10   11   12   13   14   >