sfisque commented on PR #330:
URL: https://github.com/apache/poi/pull/330#issuecomment-1113732083
no worries, i forgot that i forked it under a different user-id. closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sfisque closed pull request #330: Patch averageif
URL: https://github.com/apache/poi/pull/330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pjfanning commented on PR #330:
URL: https://github.com/apache/poi/pull/330#issuecomment-1113731068
I don't have a direct way to close this. I have un ugly way to close it but
may avoid it. It's more important that you verify the apache poi trunk code to
verify it works for you.
--
This
sfisque-synodex commented on PR #330:
URL: https://github.com/apache/poi/pull/330#issuecomment-1113728080
i do not appear to have that privilege. i cannot find the close button.
you have my permission to close it if you have that privilege.
--
This is an automated message from the
pjfanning commented on PR #330:
URL: https://github.com/apache/poi/pull/330#issuecomment-1113722315
Can you close this PR? - all this code is merged to Apache trunk and I have
been fixing your bugs and code formatting issues.
--
This is an automated message from the Apache Git Service.
pjfanning commented on PR #330:
URL: https://github.com/apache/poi/pull/330#issuecomment-1113701291
new code is incorrect - I have provided a pull request to your repo - if the
example2 is left broken, i will remove all the new code
--
This is an automated message from the Apache Git
sfisque-synodex commented on PR #330:
URL: https://github.com/apache/poi/pull/330#issuecomment-1113672581
i was in the process of adding ex.2 to the test. should i continue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pjfanning commented on PR #330:
URL: https://github.com/apache/poi/pull/330#issuecomment-1113671308
I've merged what you've done so far after reformatting the code but with
example2 being tested, the new code is suspect and liable for removal
--
This is an automated message from the
sfisque-synodex commented on PR #330:
URL: https://github.com/apache/poi/pull/330#issuecomment-1113668970
ok. but i'm not aware of "ignoring" the code format request. i moved all
the braces and other bits.
--
This is an automated message from the Apache Git Service.
To respond to the
pjfanning commented on PR #330:
URL: https://github.com/apache/poi/pull/330#issuecomment-1113668092
and you ignored the review comment asking you to respect the code format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pjfanning commented on PR #330:
URL: https://github.com/apache/poi/pull/330#issuecomment-1113667443
could you cover example2 from M$ too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Hello!
Can you help me to discover more about poi?
It's a great api. And I try to find how I can create stacked histograms
like those attached to the letter. But I didn't manage to find this on the
website.
And I would like to know if there are any ways to do this?
pjfanning commented on code in PR #330:
URL: https://github.com/apache/poi/pull/330#discussion_r862012906
##
poi/src/test/java/org/apache/poi/ss/formula/functions/TestAverageIf.java:
##
@@ -0,0 +1,106 @@
+/*
+ *
pjfanning commented on code in PR #330:
URL: https://github.com/apache/poi/pull/330#discussion_r862012906
##
poi/src/test/java/org/apache/poi/ss/formula/functions/TestAverageIf.java:
##
@@ -0,0 +1,106 @@
+/*
+ *
pjfanning commented on code in PR #330:
URL: https://github.com/apache/poi/pull/330#discussion_r862011973
##
poi/src/test/java/org/apache/poi/ss/formula/functions/TestAverageIf.java:
##
@@ -0,0 +1,106 @@
+/*
+ *
sfisque commented on code in PR #330:
URL: https://github.com/apache/poi/pull/330#discussion_r861796135
##
poi/src/test/java/org/apache/poi/ss/formula/functions/TestAverageIf.java:
##
@@ -0,0 +1,106 @@
+/*
+ *
sfisque commented on code in PR #330:
URL: https://github.com/apache/poi/pull/330#discussion_r861796135
##
poi/src/test/java/org/apache/poi/ss/formula/functions/TestAverageIf.java:
##
@@ -0,0 +1,106 @@
+/*
+ *
sfisque commented on code in PR #330:
URL: https://github.com/apache/poi/pull/330#discussion_r861795347
##
poi/src/main/java/org/apache/poi/ss/formula/functions/AverageIf.java:
##
@@ -0,0 +1,133 @@
+/*
+
yes. i figured that out after looking at the other PRs. the gitflow mech that
i'm used to had us working on branches in the same repo, not forks. but after
inspecting other PRs, the difference became apparent. PR has been submitted
for review.
TIA
Stanton Fisque
principal technologist
https://bz.apache.org/bugzilla/show_bug.cgi?id=66039
--- Comment #3 from PJ Fanning ---
also added r1900383 - a javadoc change
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail:
https://bz.apache.org/bugzilla/show_bug.cgi?id=66047
PJ Fanning changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=66047
--- Comment #1 from Fabio ---
Created attachment 38272
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38272=edit
Excel File with rounding issue
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66047
Bug ID: 66047
Summary: Rounding issue in MROUND due to 1897066
Product: POI
Version: 5.2.1-FINAL
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Here is the link in plain text - as it may not link properly in some email
readers.
https://github.com/pjfanning/double-reader-writer
On Friday 29 April 2022, 14:02:39 GMT+2, PJ Fanning
wrote:
Hi everyone,
I've been doing some analysis of alternatives to using the JDK methods for
Hi everyone,
I've been doing some analysis of alternatives to using the JDK methods for
parsing and writing floats and doubles.
See https://github.com/pjfanning/double-reader-writer for some numbers and
links.
The results are pretty good. POI does a lot of double parsing (for example). It
may
https://bz.apache.org/bugzilla/show_bug.cgi?id=66039
--- Comment #2 from PJ Fanning ---
I added r1900375 - a test that shows that setCellFormulaValidation=false can
help stopping the attempted reformatting of the formula.
I think in a lot of cases, users don't want POI to reformat their
https://bz.apache.org/bugzilla/show_bug.cgi?id=66039
--- Comment #1 from PJ Fanning ---
I haven't validated this but the XSSFWorkbook has this method:
```
/**
* Whether a call to {@link XSSFCell#setCellFormula(String)} will validate
the formula or not.
*
* @param value true
pjfanning commented on code in PR #330:
URL: https://github.com/apache/poi/pull/330#discussion_r861502408
##
poi/src/test/java/org/apache/poi/ss/formula/functions/TestAverageIf.java:
##
@@ -0,0 +1,106 @@
+/*
+ *
centic9 commented on code in PR #330:
URL: https://github.com/apache/poi/pull/330#discussion_r861492974
##
poi/src/main/java/org/apache/poi/ss/formula/functions/AverageIf.java:
##
@@ -0,0 +1,133 @@
+/*
+
Hi,
This is the default workflow of Github-repositories. You need to create a
fork of the code into a new repository, create the branch there and then
send a PR to the main repo.
The following might help:
*
30 matches
Mail list logo
