https://bz.apache.org/bugzilla/show_bug.cgi?id=66586
--- Comment #5 from Nabeel Raza ---
Hi Team, Thanks for commenting. I connected with Cloudera and they are working
on it for the fix in the latest version of CDP.
Thanks. I totally understand that there should be a limit for this but
ebourg commented on PR #462:
URL: https://github.com/apache/poi/pull/462#issuecomment-1537195810
I can contribute one for the tests (I've built one for the Jsign tests:
https://github.com/ebourg/jsign/blob/master/jsign-core/src/test/resources/minimal.msi),
but a msi file is really not
pjfanning commented on PR #462:
URL: https://github.com/apache/poi/pull/462#issuecomment-1537194483
I don't think we should merge this without an MSI test. We have zero test
coverage of MSIs.
-1 from me
--
This is an automated message from the Apache Git Service.
To respond to the
ebourg commented on PR #462:
URL: https://github.com/apache/poi/pull/462#issuecomment-1537194290
I did modify the existing tests to ensure the header is properly updated. I
don't think adding an actual msi file will improve the test coverage, it's just
a CFB file like any other one.
--
https://bz.apache.org/bugzilla/show_bug.cgi?id=66586
Dominik Stadler changed:
What|Removed |Added
Resolution|--- |WONTFIX
Status|NEEDINFO
centic9 commented on PR #462:
URL: https://github.com/apache/poi/pull/462#issuecomment-1537183718
Thanks for the changes. Looks good on a brief look.
Can you add a sample .msi-file to directory test-data/poi-fs and a small
unit-test which verifies opening it so we verify the
https://bz.apache.org/bugzilla/show_bug.cgi?id=66590
Dominik Stadler changed:
What|Removed |Added
Severity|normal |enhancement
--
You are receiving
