https://bz.apache.org/bugzilla/show_bug.cgi?id=61033
Dominik Stadler changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bz.apache.org/bugzilla/show_bug.cgi?id=61033
Dominik Stadler changed:
What|Removed |Added
Keywords|
https://bz.apache.org/bugzilla/show_bug.cgi?id=61033
--- Comment #7 from Travis Burtrum ---
Also I've been pushing up my branches here too if it makes it easier to look
at:
https://github.com/moparisthebest/poi/commits/formula_patch
https://bz.apache.org/bugzilla/show_bug.cgi?id=61033
--- Comment #6 from Travis Burtrum ---
Created attachment 34954
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34954=edit
0002-Unit-tests-for-XSSFWorkbook.setCellFormulaValidation.patch
Unit tests for
https://bz.apache.org/bugzilla/show_bug.cgi?id=61033
--- Comment #5 from Travis Burtrum ---
Created attachment 34953
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34953=edit
0001-Add-XSSFWorkbook.setCellFormulaValidation-to-control.patch
Alternative
https://bz.apache.org/bugzilla/show_bug.cgi?id=61033
--- Comment #4 from Javen O'Neal ---
Combinations that need tested:
1. Evaluate formulas=false should not raise an exception when setting an
invalid formula.
2. Evaluate formulas=false should not raise an exception when
https://bz.apache.org/bugzilla/show_bug.cgi?id=61033
--- Comment #3 from Javen O'Neal ---
>From Greg Woolsey on dev@:
Test the positive case too, true + invalid formula allowed, test that the
default is true, test that flipping it from false to true with an invalid
formula in
Test the positive case too, true + invalid formula allowed, test that the
default is true, test that flipping it from false to true with an invalid
formula in place, resulting in an invalid workbook, is somehow handled so
users don't get odd errors later. Maybe validate all formulas then? That
https://bz.apache.org/bugzilla/show_bug.cgi?id=61033
--- Comment #2 from Travis Burtrum ---
It's basically just a setter/getter for a boolean, and then not calling
validation logic if false, I'm not sure of a great way to unit test that,
especially since it only
https://bz.apache.org/bugzilla/show_bug.cgi?id=61033
--- Comment #1 from Javen O'Neal ---
Could you please add some unit tests covering the new functionality?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61033
Travis Burtrum changed:
What|Removed |Added
Attachment #34946|patch
11 matches
Mail list logo