[Bug 66509] NullPointerException when invoking getAnchor() on groups/shapes that are missing the off attribute

2023-03-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66509 --- Comment #5 from Henry Iguaro --- Thank you for your response. I would like to clarify that `XSLFSimpleShape#getAnchor()` already returns `null` in a couple of cases. The current implementation checks for the presence of the `xfrm` element a

[Bug 66509] NullPointerException when invoking getAnchor() on groups/shapes that are missing the off attribute

2023-03-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66509 --- Comment #4 from PJ Fanning --- I'm not sure about this change. The existing methods don't appear to have ever been expected to return null. I'd prefer if any change involved us returning an exception. Since the existing methods don't expose

[Bug 66509] NullPointerException when invoking getAnchor() on groups/shapes that are missing the off attribute

2023-03-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66509 Henry Iguaro changed: What|Removed |Added Version|unspecified |5.2.2-FINAL --- Comment #3 from Henry I

[Bug 66509] NullPointerException when invoking getAnchor() on groups/shapes that are missing the off attribute

2023-03-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66509 --- Comment #2 from PJ Fanning --- Where did the test file come from? We've gotten away without these null checks until now so it appears that it is not common to have the `` tag not appear? Have you run the POI tests with your code changes?

[Bug 66509] NullPointerException when invoking getAnchor() on groups/shapes that are missing the off attribute

2023-03-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66509 --- Comment #1 from Henry Iguaro --- Link to a Pull Request with a potential fix: https://github.com/higuaro/poi/pull/1 -- You are receiving this mail because: You are the assignee for the bug.