[GitHub] [poi] rascmatt commented on pull request #443: [Bug-66532] Improve performance of SheetDataWriter

2023-03-18 Thread via GitHub
rascmatt commented on PR #443: URL: https://github.com/apache/poi/pull/443#issuecomment-1474801750 Thank you, I added this version to the benchmark and it looks good. In addition I added a benchmark for a more integrated setting (https://github.com/rascmatt/poi-benchmark/commit/d7fa4a8b2842

[GitHub] [poi] rascmatt commented on pull request #443: [Bug-66532] Improve performance of SheetDataWriter

2023-03-17 Thread via GitHub
rascmatt commented on PR #443: URL: https://github.com/apache/poi/pull/443#issuecomment-1474419787 https://github.com/rascmatt/poi-benchmark The (updated) benchmark with code and results. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [poi] rascmatt commented on pull request #443: [Bug-66532] Improve performance of SheetDataWriter

2023-03-17 Thread via GitHub
rascmatt commented on PR #443: URL: https://github.com/apache/poi/pull/443#issuecomment-1474314063 The following is a JMH benchmark I ran with 3 different versions. Unfortunately I was unable to get JMH running with Gradle, so I ran this in an external Maven Project. The latest rele