pjfanning commented on PR #586:
URL: https://github.com/apache/poi/pull/586#issuecomment-2117355211
thanks - merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #586: Bug 68183: SXSSFWorkbook should dispose of
temporary files when close() is called
URL: https://github.com/apache/poi/pull/586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
InfiniteLoop90 commented on PR #586:
URL: https://github.com/apache/poi/pull/586#issuecomment-2080211381
Thanks for the feedback.
I made the following changes:
* Changed the
`TestSXSSFWorkbookWithCustomZipEntrySource#validateTempFilesAreEncrypted` test
so that it now passes.
pjfanning commented on PR #586:
URL: https://github.com/apache/poi/pull/586#issuecomment-2078235315
* we can't change this behaviour unless the release is a major release
*
https://github.com/apache/poi/commit/eebb3717e04341aa041be14f8322ac4dd835c286
and related changes would also
centic9 commented on PR #586:
URL: https://github.com/apache/poi/pull/586#issuecomment-2078228482
This seems to break some test-cases, can you try to adjust them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
InfiniteLoop90 commented on PR #586:
URL: https://github.com/apache/poi/pull/586#issuecomment-2068207852
Let me know if there’s anything else needed from me. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
InfiniteLoop90 opened a new pull request, #586:
URL: https://github.com/apache/poi/pull/586
This way consumers can use the workbook in a try-with-resources statement
and the temp files will always be cleaned up without having to remember to
explicitly call SXSSFWorkbook#dispose().
--
