Re: Proposed Public OpenAPI Changes

2025-09-19 Thread Adnan Hemani
Sure, makes sense. I’ve opened a separate PR for it and will tag the issue to it! -Adnan > On Sep 19, 2025, at 3:15 PM, Michael Collado wrote: > > Agree - changes to the status codes should accompany a major version bump. > Maybe log this as an issue and add to a 2.0.0 milestone release? > >

Re: Proposed Public OpenAPI Changes

2025-09-19 Thread Michael Collado
Agree - changes to the status codes should accompany a major version bump. Maybe log this as an issue and add to a 2.0.0 milestone release? On Thu, Sep 18, 2025 at 4:08 PM Adnan Hemani wrote: > Hi Dmitri, > > The change of the response code from 201 to 204 were discussed in Yufei’s > response wi

Re: Proposed Public OpenAPI Changes

2025-09-18 Thread Adnan Hemani
Hi Dmitri, The change of the response code from 201 to 204 were discussed in Yufei’s response within this email chain (and my response to his email as well). I can understand this being considered a “major change” requiring a major version increment. In the interest of time, I can remove that

Re: Proposed Public OpenAPI Changes

2025-09-18 Thread Dmitri Bourlatchkov
Hi Adnan, Changes to response bodies LGTM. However, PR [2603] that references this discussion thread, also changes one of the response codes from 201 to 204 (which was not yet discussed in this thread, if I'm not mistaken). The response code change appears to be meaningful, however, I believe it

Re: Proposed Public OpenAPI Changes

2025-09-17 Thread Adnan Hemani
Hi all, Thanks for the responses - and sorry for the delay, the past few weeks have been quite busy. I agree with all the points presented. * I will start a vote soon for the following endpoints, once I have a draft PR that shows the proposed changes: createCatalog, createPrincipalRole, creat

Re: Proposed Public OpenAPI Changes

2025-09-08 Thread Yufei Gu
Thanks for the proposal, Adnan. Returning representations from the create endpoints makes sense to me and will reduce a follow-up GET in most clients. For addGrantToCatalogRole, the grant itself is more a relationship between entities than entity itself. I understand it returns 201(Created) now,

Re: Proposed Public OpenAPI Changes

2025-09-08 Thread Alexandre Dutra
Hi Adnan, Thanks for bringing this topic to our attention. In general, for operations creating new resources, the event instrumentation logic could rely on the incoming request. E.g. for createCatalog, if the response does not contain the catalog resource, it is generally OK to grab it from the i