Github user mars commented on the issue:
https://github.com/apache/incubator-predictionio/pull/421
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user takezoe commented on the issue:
https://github.com/apache/incubator-predictionio/pull/421
> I addressed all your Scala style & usage suggestions.
ð
> Still need to take care of the threadsafety issue with the singleton
client.
Yes, I'm reviewi
Github user mars commented on the issue:
https://github.com/apache/incubator-predictionio/pull/421
Based on these [Scala Concurrency/Thread Safety
docs](https://twitter.github.io/scala_school/concurrency.html#danger), I
believe simply annotating `@volatile` will cause the synchronizat
GitHub user takezoe opened a pull request:
https://github.com/apache/incubator-predictionio/pull/425
[PIO-110]Refactoring
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takezoe/incubator-predictionio
refactor-common-code
Alter
