[GitHub] incubator-predictionio issue #425: [PIO-110] Refactoring

2017-08-26 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/425 @mars Some of them I suggested are applied by this pull request. But as a result of checking the whole codebase, I thought that I shouldn't apply some of them to the whole. F

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-26 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/425#discussion_r135380673 --- Diff: core/src/main/scala/org/apache/predictionio/controller/PAlgorithm.scala --- @@ -115,15 +115,12 @@ abstract class PAlgorithm[PD, M,