Re: integration tests

2018-10-11 Thread Matteo Merli
Integration tests are now required to be able to merge PRs. -- Matteo Merli On Wed, Oct 10, 2018 at 2:08 PM Matteo Merli wrote: > Created jira: https://issues.apache.org/jira/browse/INFRA-17129 > > On Wed, Oct 10, 2018 at 7:23 AM Ivan Kelly wrote: > >> +1 >> >> On Wed, Oct 10, 2018 at 6:51

Re: [CANCEL] [VOTE] Pulsar Release 2.2.0 Candidate 1

2018-10-11 Thread PengHui Li
> FYI. the issue that Matteo mentioned here is related to the issue you reported yesterday when using 2.2.0-SNAPSHOT artifact. Yes, problem is when i use `java -cp` to run the application. but when i debug by idea, we can’t get the problem. Joe F 于2018年10月12日周五 上午6:56写道: > Given the issue ident

Re: [CANCEL] [VOTE] Pulsar Release 2.2.0 Candidate 1

2018-10-11 Thread PengHui Li
> I think 2759 is merged after Joe started the release process. We can > consider adding it to 2.2.1 @Sijie:Ok, Thanks. Joe F 于2018年10月12日周五 上午6:56写道: > Given the issue identified, this vote is cancelled until > https://github.com/apache/pulsar/issues/2778 is fixed > > Candidate-2 up will be pu

[CANCEL] [VOTE] Pulsar Release 2.2.0 Candidate 1

2018-10-11 Thread Joe F
Given the issue identified, this vote is cancelled until https://github.com/apache/pulsar/issues/2778 is fixed Candidate-2 up will be put up for vote after this fix is completed Thank you Joe -- Forwarded message - From: Matteo Merli Date: Thu, Oct 11, 2018 at 3:30 PM Subject: R

Re: [VOTE] Pulsar Release 2.2.0 Candidate 1

2018-10-11 Thread Sijie Guo
@PengHui Li : FYI. the issue that Matteo mentioned here is related to the issue you reported yesterday when using 2.2.0-SNAPSHOT artifact. - Sijie On Thu, Oct 11, 2018 at 3:30 PM Matteo Merli wrote: > We have found there are some issues with Netty shading in master (that are > also reflected

Re: [VOTE] Pulsar Release 2.2.0 Candidate 1

2018-10-11 Thread Matteo Merli
We have found there are some issues with Netty shading in master (that are also reflected in this candidate). This impacts all clients that have other Netty dependencies in the classpath. Working on a fix. Matteo On Wed, Oct 10, 2018 at 5:16 PM Joe F wrote: > This is the first release candida

Re: [VOTE] Pulsar Release 2.2.0 Candidate 1

2018-10-11 Thread Sijie Guo
Hi Penghui, I think 2759 is merged after Joe started the release process. We can consider adding it to 2.2.1 - Sijie On Wed, Oct 10, 2018 at 5:52 PM PengHui Li wrote: > https://github.com/apache/pulsar//2759 > please include this PR. > > Joe F 于2018年10月11日 周四08:16写道: > > > This is the first re

Re: [DISCUSSION] PIP 24: Simplify memory settings

2018-10-11 Thread Sijie Guo
On Wed, Oct 10, 2018 at 4:13 PM Matteo Merli wrote: > On Wed, Oct 10, 2018 at 4:03 PM Sijie Guo wrote: > > > the proposal looks good to me. > > > > just out of curiosity, why PoolingPolicy only has `UnpooledHeap` and > > `PooledDirect`? > > > > I think these are the 2 that make sense (from my pe