Re: PIP 28: Improve pulsar proxy log messages

2019-01-30 Thread sun yao
Hi Sijie, Matteo and Joe ,     Thanks for your kind and professional opinions .     For performance concern from Joe, what I think is like this, different log levels for different detail outputs and let dev decide which is good for them, and I also mentioned in PIP about we can disable this featu

Re: PIP 28: Improve pulsar proxy log messages

2019-01-30 Thread Joe F
I run Pulsar proxy in production, and the same concern here. I don't think we can get any of these metrics unless we start parsing protocol, and definitely its going to make everything slower, and create additional memory and GC pressures. Joe On Wed, Jan 30, 2019 at 11:08 AM Matteo Merli wrot

Re: PIP 28: Improve pulsar proxy log messages

2019-01-30 Thread Matteo Merli
Missed to comment on this :) One issue might arise from the fact that proxy is not actually parsing each and every request. The proxy only "speaks" Pulsar protocol initial Connect/Connected handshake, in which the proxy forwards the client credentials and route it through the appropriate broker.

Re: PIP 28: Improve pulsar proxy log messages

2019-01-30 Thread Sijie Guo
Yao, Thank you for your proposal! The proposal looks good to me +1. In general, the ASF is using lazy consensus for a lot of things, like adopting PIPs. basically, if there is no objection coming up within a period (typically 1~2 days), you are good to pull the trigger and send PRs :-) - Sijie

Re: Integration test fixes

2019-01-30 Thread Matteo Merli
On Wed, Jan 30, 2019 at 12:34 AM Enrico Olivelli wrote: > Jenkins merges the patch with current master before running tests, doesn't > it? I don't think this is being done by Jenkins, at least with the current configuration. I haven't seen any merge-conflict errors in Jenkins build while the conf

Re: Integration test fixes

2019-01-30 Thread David Kjerrumgaard
Sanjeev, I re-merged last night, and am now getting the above error messages. - David On Wed, Jan 30, 2019 at 8:29 AM Sanjeev Kulkarni wrote: > Could you pl merge master in your branch and try again? Matteo fixed some > bugs in integrated tests that might be affecting this > > On Wed, Jan 30

Re: Integration test fixes

2019-01-30 Thread Sanjeev Kulkarni
Could you pl merge master in your branch and try again? Matteo fixed some bugs in integrated tests that might be affecting this On Wed, Jan 30, 2019 at 7:35 AM David Kjerrumgaard wrote: > I have merged PR-2865 with > master and am not getting the foll

Re: Integration test fixes

2019-01-30 Thread David Kjerrumgaard
I have merged PR-2865 with master and am not getting the following error, which I have never seen before. Is there an additional flag I need to use to run the integration test suite? [INFO] Running TestSuite [ERROR] Tests run: 58, Failures: 3, Errors:

Slack digest for #dev - 2019-01-30

2019-01-30 Thread Apache Pulsar Slack
2019-01-29 23:06:28 UTC - Patrick Johnmeyer: @Patrick Johnmeyer has joined the channel 2019-01-29 23:14:59 UTC - Patrick Johnmeyer: Hello, I've been trying to utilize the pulsar-cpp-client and I am having problems. I downloaded both DEB files from

Re: Integration test fixes

2019-01-30 Thread Enrico Olivelli
Il giorno mer 30 gen 2019, 04:16 Matteo Merli ha scritto: > I just merged https://github.com/apache/pulsar/pull/3412 which contain > a fix for the failures in integration tests that have been plaguing > our CI in the last week. > > Please merge your PRs with master in order to pick up the fix and