Re: [VOTE] PIP-96 Message payload processor for Pulsar client

2021-10-01 Thread Hang Chen
+1 (binding) Thanks, Hang Sijie Guo 于2021年10月2日周六 上午5:11写道: > > +1 binding > > On Thu, Sep 30, 2021 at 2:06 AM PengHui Li wrote: > > > +1 (binding) > > > > Thanks for the great work. > > > > Penghui > > > > On Thu, Sep 30, 2021 at 12:38 PM Enrico Olivelli > > wrote: > > > > > +1 (binding) > >

Re: Correct semantics of producer close

2021-10-01 Thread Joe F
I am with Enrrico on this, and for more or less the same reasons. My vote is to update the doc to say that on close(), there are no guarantees on pending messages. There is no reasonable basis for any user to claim that messages are not getting flushed, because there are no guarantees that the

Re: [VOTE] PIP-97 Asynchronous Authentication Provider

2021-10-01 Thread Sijie Guo
+1 binding On Thu, Sep 30, 2021 at 10:54 AM Matteo Merli wrote: > LGTM +1 > > > -- > Matteo Merli > > > On Mon, Sep 27, 2021 at 1:43 PM Michael Marshall > wrote: > > > > Hi Pulsar Community, > > > > I would like to start a VOTE for PIP-97 Asynchronous Authentication > Provider. > > > > The iss

Re: [VOTE] PIP-96 Message payload processor for Pulsar client

2021-10-01 Thread Sijie Guo
+1 binding On Thu, Sep 30, 2021 at 2:06 AM PengHui Li wrote: > +1 (binding) > > Thanks for the great work. > > Penghui > > On Thu, Sep 30, 2021 at 12:38 PM Enrico Olivelli > wrote: > > > +1 (binding) > > > > Enrico > > > > Il Gio 30 Set 2021, 06:08 Yunze Xu ha > > scritto: > > > > > Hi folks,

Re: Separate topic and partition label for Prometheus metrics in 2.9.0

2021-10-01 Thread Michael Marshall
> I believe that a middle ground option is to set it to 'true' in 2.9. > It is a burden to maintain so many options for us, so I agree that we can > drop it for 2.10. +1, I think Enrico's idea sounds like a good way to ensure a gradual change. By keeping the config in 2.9, we can add a note in th

[GitHub] [pulsar-helm-chart] vitosans edited a comment on issue #84: TLS Authentication in Kubernetes, Pulsar 2.6.1 - Broker crash loop on startup due to 401 in WorkerService.start(..)

2021-10-01 Thread GitBox
vitosans edited a comment on issue #84: URL: https://github.com/apache/pulsar-helm-chart/issues/84#issuecomment-932431670 I did something like this: ``` webServiceUrl: "https://{{ template "pulsar.fullname" . }}-{{ .Values.proxy.component }}:{{ .Values.proxy.ports.https }}/"

[GitHub] [pulsar-helm-chart] vitosans commented on issue #84: TLS Authentication in Kubernetes, Pulsar 2.6.1 - Broker crash loop on startup due to 401 in WorkerService.start(..)

2021-10-01 Thread GitBox
vitosans commented on issue #84: URL: https://github.com/apache/pulsar-helm-chart/issues/84#issuecomment-932431670 I did something like this: tlsEnabled: "true" brokerClientTlsEnabled: "true" brokerClientTrustCertsFilePath: "/pulsar/certs/ca/ca.crt" useTls: true tlsCerti