Re: [VOTE] PIP-149: Making the REST Admin API fully async

Thanks for your participation. Close this vote with 2 (+1) bindings and 3 (+1) non-bindings, 0 (-1). On Wed, 30 Mar 2022 at 07:27, ZhangJian He wrote: > +1 > > Thanks > ZhangJian He > > Zike Yang 于2022年3月29日周二 18:48写道： > > > +1, > > > > Zike Yang > > > > On 2022/03/29 09:22:16 guo jiwei wrote:

[GitHub] [pulsar] kkoderok commented on a diff in pull request #13339: [Issue 10816][Proxy] Refresh client auth token

kkoderok commented on code in PR #13339: URL: https://github.com/apache/pulsar/pull/13339#discussion_r841402861 ## pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithJwtAuthorizationTest.java: ## @@ -363,6 +374,72 @@ public void testProxyAuthorizationWithPrefixS

[GitHub] [pulsar] kkoderok commented on a diff in pull request #13339: [Issue 10816][Proxy] Refresh client auth token

kkoderok commented on code in PR #13339: URL: https://github.com/apache/pulsar/pull/13339#discussion_r841401389 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyClientCnx.java: ## @@ -20,43 +20,93 @@ import io.netty.buffer.ByteBuf; import io.netty.channel.Ev

[GitHub] [pulsar] kkoderok commented on a diff in pull request #13339: [Issue 10816][Proxy] Refresh client auth token

kkoderok commented on code in PR #13339: URL: https://github.com/apache/pulsar/pull/13339#discussion_r841398032 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java: ## @@ -240,16 +253,23 @@ public void channelActive(ChannelHandlerContext ctx) throws Exce

[GitHub] [pulsar] kkoderok commented on a diff in pull request #13339: [Issue 10816][Proxy] Refresh client auth token

kkoderok commented on code in PR #13339: URL: https://github.com/apache/pulsar/pull/13339#discussion_r841398032 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java: ## @@ -240,16 +253,23 @@ public void channelActive(ChannelHandlerContext ctx) throws Exce

[GitHub] [pulsar] kkoderok commented on a diff in pull request #13339: [Issue 10816][Proxy] Refresh client auth token

kkoderok commented on code in PR #13339: URL: https://github.com/apache/pulsar/pull/13339#discussion_r841390236 ## pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java: ## @@ -439,11 +451,65 @@ ClientConfigurationData createClientConfiguration() throws

[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #14985: Add a cache eviction policy：Evicting cache data by the slowest markDeletedPosition

lordcheng10 commented on code in PR #14985: URL: https://github.com/apache/pulsar/pull/14985#discussion_r84115 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java: ## @@ -291,6 +291,185 @@ public void acknowledge1() throws Exception {

[GitHub] [pulsar] Jason918 commented on a diff in pull request #15017: [fix][transaction] Fix transaction REST API redirect issue.

Jason918 commented on code in PR #15017: URL: https://github.com/apache/pulsar/pull/15017#discussion_r841339916 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java: ## @@ -67,216 +67,144 @@ protected void internalGetCoordinatorStats(As

[GitHub] [pulsar-site] momo-jun commented on pull request #36: [feature][doc] Apply the new REST API topic to versioned docs

momo-jun commented on PR #36: URL: https://github.com/apache/pulsar-site/pull/36#issuecomment-1087050743 > @momo-jun why not update docs earlier than 2.7.2? Don't we need to update docs for all versions otherwise users do not have restapi doc entrance? I understand the maintenance rul

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15015: [enh][transaction] Optimize to reuse transaction buffer snapshot writer

Technoboy- commented on code in PR #15015: URL: https://github.com/apache/pulsar/pull/15015#discussion_r841313610 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBaseTxnBufferSnapshotService.java: ## @@ -18,69 +18,168 @@ */ package org.apache.pulsar

[GitHub] [pulsar-dotpulsar] VisualBean commented on issue #101: `AuthenticateUsingToken(Func> tokenFactory)` is not a part of 2.3.0

VisualBean commented on issue #101: URL: https://github.com/apache/pulsar-dotpulsar/issues/101#issuecomment-1086892520 I never found it, but ended up overriding iauthentication instead - which worked great for OAuth using MSAL. -- This is an automated message from the Apache Git Servic