[GitHub] [pulsar-test-infra] tisonkun opened a new pull request, #54: [pulsarbot] trim whitespaces in comments

2022-07-07 Thread GitBox
tisonkun opened a new pull request, #54: URL: https://github.com/apache/pulsar-test-infra/pull/54 Contributors' comments often contains whitespaces and such whitespaces should not affect command validation. See also

[GitHub] [pulsar-client-node] BewareMyPower commented on pull request #219: Add null check for consumer in MessageListenerProxy

2022-07-07 Thread GitBox
BewareMyPower commented on PR #219: URL: https://github.com/apache/pulsar-client-node/pull/219#issuecomment-1178474829 Yeah. And I'll confirm the version from the user -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar-client-node] k2la commented on pull request #219: Add null check for consumer in MessageListenerProxy

2022-07-07 Thread GitBox
k2la commented on PR #219: URL: https://github.com/apache/pulsar-client-node/pull/219#issuecomment-1178472617 @BewareMyPower This fix does not address the root cause. Could you additionally write comments indicating that this modification is workaround? Also, what versions of

[GitHub] [pulsar-site] urfreespace merged pull request #142: Fix tab highlighting error

2022-07-07 Thread GitBox
urfreespace merged PR #142: URL: https://github.com/apache/pulsar-site/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-site] urfreespace commented on pull request #142: Fix tab highlighting error

2022-07-07 Thread GitBox
urfreespace commented on PR #142: URL: https://github.com/apache/pulsar-site/pull/142#issuecomment-1178448819 > @urfreespace could you please review this PR from the technical perspective? Thank you! LGTM -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar-site] Anonymitaet commented on pull request #142: Fix tab highlighting error

2022-07-07 Thread GitBox
Anonymitaet commented on PR #142: URL: https://github.com/apache/pulsar-site/pull/142#issuecomment-1178448239 @urfreespace could you please review this PR from the technical perspective? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message,

[Discuss] remove oauth2/go.mod from pulsar-client-go

2022-07-07 Thread Paul Gier
Hi Everyone! While working on some dependency improvements to pulsar-client-go, I noticed that the oauth2 sub-directory is defined as a go sub-module instead of just a normal sub-directory. This just means it has its own go.mod and go.sum, and it's dependencies are separately managed from the

[GitHub] [pulsar-manager] gurleen-gks commented on a diff in pull request #258: Support https forward

2022-07-07 Thread GitBox
gurleen-gks commented on code in PR #258: URL: https://github.com/apache/pulsar-manager/pull/258#discussion_r916153811 ## src/README.md: ## @@ -45,6 +45,28 @@ spring.datasource.password=postgres ./gradlew -x build -x test ``` +### Enable Https forward + +First, please

[GitHub] [pulsar-manager] gurleen-gks commented on issue #310: Support for TLS Authentication & Authorization

2022-07-07 Thread GitBox
gurleen-gks commented on issue #310: URL: https://github.com/apache/pulsar-manager/issues/310#issuecomment-1178020052 @sijie Is this fixed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [VOTE] [PIP-179] Support the admin API to check unknown request parameters

2022-07-07 Thread Yubiao Feng
The PIP passes with 3 bindings +1: Hang Chen, Penghui Li, and Enrico Olivelli. I will start working, Please help to move to the wiki. Thanks Yubiao Feng On Thu, Jun 30, 2022 at 10:10 AM PengHui Li wrote: > +1 (binding) > > Penghui > > On Thu, Jun 30, 2022 at 12:40 AM Yubiao Feng > wrote: > > >

Re: [DISCUSS] [PIP-179] Support the admin API to check unknown request parameters

2022-07-07 Thread Yubiao Feng
Hi Dave > Is there any intention in the future to change this to the default behaviour, in 3.0.0? There are no plans for that right now > Is that the motivation to feature flag this change, rather than treat it as a bugfix? Yes, the design goal now is that rejection of unknown request

Re: [VOTE] PIP-181: Pulsar Shell

2022-07-07 Thread tison
Great! I will give it a review in this weekend and see whether I can give a review before or after merge :) Best, tison. Nicolò Boschi 于2022年7月7日周四 22:46写道: > The PIP passes with 4 bindings and 6 non-bindings +1. > > Please note the first pull is already ready for review: >

Re: [DISCUSS] [PIP-179] Support the admin API to check unknown request parameters

2022-07-07 Thread Yubiao Feng
Hi Michael Marshall > I think we should go further and add this configuration option to the function worker and possibly the proxy. - Proxy: If the broker rejects a request with unknown parameters, the proxy will behave the same as the broker, so the proxy does not need to do additional support.

Re: [DISCUSS] [PIP-179] Support the admin API to check unknown request parameters

2022-07-07 Thread Yubiao Feng
Hi Haiting > Can we get a warning log on broker, even if this is false. This would be useful for existing clusters to turn on this feature. I think it is a good idea. It may not be easy to implement, but I will try it. I will explain in PR whether this is implemented and why. Thanks Yubiao Feng

Re: [VOTE] PIP-181: Pulsar Shell

2022-07-07 Thread Nicolò Boschi
The PIP passes with 4 bindings and 6 non-bindings +1. Please note the first pull is already ready for review: https://github.com/apache/pulsar/pull/16251 Thanks everyone, Nicolò Boschi Il giorno mer 6 lug 2022 alle ore 04:48 Michael Marshall < mmarsh...@apache.org> ha scritto: > +1

Re: [DISSCUSS]PIP-181: Reduce unnecessary REST call in broker

2022-07-07 Thread Baodi Shi
Hi, that looks good. There are also some REST calls that can be reduced. As: When unloadNamespace, if a bund on this broker, can be directly unloaded. Thanks, Baodi Shi > On Jul 7, 2022, at 15:3330, Enrico Olivelli wrote: > > Xiaoyu Hou, > I support this PIP > > Enrico > > Il giorno gio 7

Re: [ANNOUNCE] New Committer: Zixuan Liu

2022-07-07 Thread Nicolò Boschi
Congrats! Nicolò Boschi Il giorno gio 7 lug 2022 alle ore 13:28 Haiting Jiang < jianghait...@apache.org> ha scritto: > Congratulates, Zixuan! > > BR, > Haiting > > On 2022/07/07 10:03:36 Yu wrote: > > Hi team, > > > > The Project Management Committee (PMC) for Apache Pulsar has invited > >

[GitHub] [pulsar-site] SignorMercurio opened a new pull request, #142: Fix tab highlighting error

2022-07-07 Thread GitBox
SignorMercurio opened a new pull request, #142: URL: https://github.com/apache/pulsar-site/pull/142 Something's different between local `yarn start` site and published site and I haven't figured out why. Hopefully this temporary fix will resolve the style error in tab highlighting. --

Re: [DISCUSS] PIP-180: Shadow Topic, an alternative way to support readonly topic ownership.

2022-07-07 Thread Haiting Jiang
Hi Enrico, Thanks for your feedback. On 2022/07/05 08:03:43 Enrico Olivelli wrote: > I have a couple of additional questions. > > 1. Security > What about security permissions about the shadow topic ? > We are reading from another topic. > I think we must clarify the decisions in the PIP As

Re: [ANNOUNCE] New Committer: Zixuan Liu

2022-07-07 Thread Haiting Jiang
Congratulates, Zixuan! BR, Haiting On 2022/07/07 10:03:36 Yu wrote: > Hi team, > > The Project Management Committee (PMC) for Apache Pulsar has invited > Zixuan Liu (https://github.com/nodece) to become a committer > and we are pleased to announce that he has accepted. > > Being a committer

Re: [DISCUSS] [PIP-179] Support the admin API to check unknown request parameters

2022-07-07 Thread Dave Maughan
Hi Yubiao, +1 Is there any intention in the future to change this to the default behaviour, in 3.0.0? I assume there are going to be some other areas of the code base and integrations that would need to deal with the new failure mode. So it does make sense to phase this in gradually. Is that the

[ANNOUNCE] New Committer: Zixuan Liu

2022-07-07 Thread Yu
Hi team, The Project Management Committee (PMC) for Apache Pulsar has invited Zixuan Liu (https://github.com/nodece) to become a committer and we are pleased to announce that he has accepted. Being a committer enables easier contribution to the project since there is no need to go via the patch

Re: Pull requests potentially blocked by the Documentation Bot workflow

2022-07-07 Thread Yu
Hi team, Sorry for the inconvenience. We're optimizing the Doc Bot, it does not function well sometimes. A quick workaround is to re-trigger the Doc Bot (eg. untick the doc label check box and tick it again in the PR description), then it will work normally. Hi Nicolo, Please do not push your

Re: [DISSCUSS]PIP-181: Reduce unnecessary REST call in broker

2022-07-07 Thread Enrico Olivelli
Xiaoyu Hou, I support this PIP Enrico Il giorno gio 7 lug 2022 alle ore 05:37 Michael Marshall ha scritto: > > Hi Xiaoyu Hou, > > Thank you for your proposal. I agree that this proposal could help > reduce unnecessary overhead by calling the internal broker's methods > directly instead of