Hi Asaf, thank you for the very detailed reply.
> The problem we have today is that while we have sent a request to reset
the subscription position, the broker decides to:
> 1. Close the TCP connection which in turn causes the client to clear any
pending messages it has in the queue.
> 2. Continue
Hi Lin,
Thanks for starting this discussion.
First, I support having code coverage repo for the PR which will provide
the initial impressions of the test coverage to reviewers. Although the
code
coverage report can produce distorted results, the report is not the
supreme indicator, just an auxili
Hi,
I have created PR to support the below functionality, Please provide
feedback.
*Method:* void acknowledgeCumulative(Map
topicToMessageId);
*Pull Request:* https://github.com/apache/pulsar/pull/17577
Thanks & Regards
Tarun.
On Fri, 9 Sept 2022 at 19:55, Xiangying Meng wrote:
> +1
> This
Hi Xiangying,
I totally agree that when new feature or major optimizations are submitted,
it should be in the owner's interest to care about code coverage for their
new feature. The test cases are protection of their code from unintended
side effects from other people's work.
In the case the PR i
