Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 2

2023-02-05 Thread Yunze Xu
This wheel works for me. I tested the following commands on macOS Monterey 12.6: ```bash brew install python@3.7 python3.7 -m pip install pulsar_client-3.1.0-cp37-cp37m-macosx_10_15_universal2.whl ``` Here are the actual versions: ```bash % python3.7 --version

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 2

2023-02-05 Thread Zike Yang
Hi, Yunze When I use the python 3.7.9 to install the whl file. It reports a platform mismatch error. ``` ➜ macos python --version Python 3.7.9 ➜ macos python -m pip install pulsar_client-3.1.0-cp37-cp37m-macosx_10_15_universal2.whl ERROR:

Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-02-05 Thread Baodi Shi
I thought about it for a moment, and this is not a good idea. Using newBuild may be understood by the user as recreating the client object. It is still intuitive to add the `updateXXX` method. Thanks, Baodi Shi 在 2023年2月5日 23:01:57 上,Asaf Mesika 写道: > Can you please write rebuild example?

Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-02-05 Thread Asaf Mesika
Can you please write rebuild example? On Sun, Feb 5, 2023 at 4:05 PM Baodi Shi wrote: > > > > Not completely different IMO. When we want to update the service URL, > > > > we usually want to connect to another cluster. However, the cluster > > > > could have configured authentication, TLS for

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-02-05 Thread Asaf Mesika
On Fri, Feb 3, 2023 at 1:48 PM Yan Zhao wrote: > > If you persisted the message successfully by the producer and the broker > > was terminated before being able to delete the ledger from the metadata > > service? > If the broker is terminated, the consumer won't ack the message, the > message

Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-02-05 Thread Baodi Shi
> > Not completely different IMO. When we want to update the service URL, > > we usually want to connect to another cluster. However, the cluster > > could have configured authentication, TLS for security, but we cannot > > guarantee two clusters share the same TLS certificates or > >

Re: [DISCUSS] Topic name restriction

2023-02-05 Thread Asaf Mesika
Thanks Mattison. I don't understand the idea suggested of making the validation rules configurable. If understand correctly: * "-partition" is not something you want configurable - it should always be validated * System topics - once we agree on a naming convention going forward, it should always

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-02-05 Thread Yan Zhao
On 2023/02/03 20:05:59 Heesung Sohn wrote: > For these internal requesters, > 1. A cursor be removed. > 2. Close the current ledger and create a new ledger. > 3. Consumer ack the message, the slowest cursor move forward. > > How do we prevent these callers from requesting duplicate requests for

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-02-05 Thread Yan Zhao
On 2023/02/03 18:14:53 Heesung Sohn wrote: > There are some cases to trigger it. > 1. A cursor be removed. > 2. Close the current ledger and create a new ledger. > 3. Consumer ack the message, the slowest cursor move forward. > 4. User trigger truncateTopic by admin. > > I see that this pip is