Re: [ANNOUNCE] New committer: Yuri Mizushima

2023-02-26 Thread Horizon
Congrats!

Re: [DISCUSS] Change PIP template

2023-02-26 Thread Enrico Olivelli
+1 great suggestions Enrico Il giorno lun 27 feb 2023 alle ore 02:54 ha scritto: > > +1 > > Best, > Mattison > On Feb 26, 2023, 23:02 +0800, Dave Fisher , wrote: > > Excellent proposal. > > > > Inline below. > > > > Sent from my iPhone > > > > > On Feb 26, 2023, at 3:19 AM, Asaf Mesika wrote:

Re: [ANNOUNCE] New committer: Yuri Mizushima

2023-02-26 Thread Enrico Olivelli
Congrats Yuri well deserved ! Enrico Il giorno lun 27 feb 2023 alle ore 08:47 Nozomi Kurihara ha scritto: > > Hi everyone, > > The Project Management Committee (PMC) for Apache Pulsar > has invited Yuri Mizushima (https://github.com/equanz) to become a > committer and we are pleased > to

[ANNOUNCE] New committer: Yuri Mizushima

2023-02-26 Thread Nozomi Kurihara
Hi everyone, The Project Management Committee (PMC) for Apache Pulsar has invited Yuri Mizushima (https://github.com/equanz) to become a committer and we are pleased to announce that he has accepted. Yuri has been an active contributor for over 3 years. He has constantly sent Pull-Requests for

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-02-26 Thread SiNan Liu
Hi! I updated the PIP issue again. This time I've added some background and some explanations. The compatibility check rules are already written in the Implementation. ProtoBufNative implements the same canRead method as Apache Avro. It does this by checking whether the schema for writing and

Re: [DISCUSS] PIP-247: Notifications for partitions update

2023-02-26 Thread houxiaoyu
Hi Joe and Michael, I think I misunderstood what you replied before. Now I understand and explain it again. Besides the reasons what Asaf mentioned above, there are also some limits for using topic list watcher. For example the `topicsPattern.pattern` must less that `maxSubscriptionPatternLeng`

Re: [questions] Which jakartaEE version we plan for pulsar 3.0.0?

2023-02-26 Thread ZhangJian He
Hi @Enrico Olivelli @Zixuan Liu I'm concerned that this change may create some complex compatibility issues between our client and Springboot. Springboot 2.x uses the package name "javax" while Springboot 3.x uses "jakarta". I'm still not entirely sure about the extent of its impact. Thanks

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-26 Thread ZhangJian He
> Another idea is whether it is possible to generate clients for various languages based on the current pulsar rest swagger files Yes. But I don't think this is a suitable choice for the go client. Due to the existing swagger file not fully complying with the specification, it cannot be used

Re: [questions] Which jakartaEE version we plan for pulsar 3.0.0?

2023-02-26 Thread Zixuan Liu
> IIUC the main pain point is for Custom Servlet developers who will have to migrate to the jakarta.xxx packages is this correct ? Sure! Our web service and some http client depend on the jersey. I checked on jetty and our project. Looks like we can only use the Jakarta EE9. We neet to upgrade

Re: [DISCUSS] PIP-247: Notifications for partitions update

2023-02-26 Thread houxiaoyu
Hi Asaf, > Prefer something more explicit: onTopicPartitionsCountChanged > Maybe we should mark "PartitionsChangedListener" deprecated? > 60 seconds seems like *a lot* to miss an update. Maybe 5-10 sec It looks good to me > Let's think about the case of endless retries We will remove the

Re: [DISCUSS] PIP-247: Notifications for partitions update

2023-02-26 Thread houxiaoyu
Hi Michael, > I think we just need the client to "subscribe" to a topic notification for > "-partition-[0-9]+" to eliminate the polling If pulsar users want to pub/sub a partitioned-topic, I think most of the users would like to create a simple producer or consumer like following: ``` Producer

Re: [DISCUSS] Change PIP template

2023-02-26 Thread mattisonchao
+1 Best, Mattison On Feb 26, 2023, 23:02 +0800, Dave Fisher , wrote: > Excellent proposal. > > Inline below. > > Sent from my iPhone > > > On Feb 26, 2023, at 3:19 AM, Asaf Mesika wrote: > > > > Hi, > > > > I would like to suggest two changes I'd like to make to the PIP design > > template: > >

Re: [DISCUSS] PIP-247: Notifications for partitions update

2023-02-26 Thread Asaf Mesika
Michael, I think the current suggested protocol is more optimized compared to existing regex mechanism: - If the broker sends notification and it's lost due network issues, you'll only know about it due to the client doing constant polling, using its hash to minimize response. -

Re: [DISCUSS]Add an internal class to `TransactionBufferStats` to record the snapshot status uniformly.

2023-02-26 Thread Asaf Mesika
On Fri, Feb 24, 2023 at 5:33 AM Xiangying Meng wrote: > Hi Asaf, > > How are those stats exposed to the user? > IMO, these stats should be exposed to the user. > The users can use it to check if the transaction snapshot is > running correctly. > > My question was "how" - prometheus, Pulsar REST

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-02-26 Thread Asaf Mesika
I'm sorry, but this PIP lacks a lot of background knowledge, so you need to add IMO for people to understand it. You don't need to explain the entire pulsar in this PIP, but at the very least a few paragraphs detailing all you need to know, to put you in context: - Start by saying Pulsar as a

Re: [Discuss] PIP-248: Add backlog eviction metric

2023-02-26 Thread Asaf Mesika
Hi, Pulsar has 2 configurations for the backlog eviction: > backlogQuotaDefaultLimitBytes and backlogQuotaDefaultLimitSecond, if > topic backlog reaches the threshold of any item, backlog eviction will be > triggered. This seems like default values, not the actual values. Can you please provide

Re: [DISCUSS] Change PIP template

2023-02-26 Thread Dave Fisher
Excellent proposal. Inline below. Sent from my iPhone > On Feb 26, 2023, at 3:19 AM, Asaf Mesika wrote: > > Hi, > > I would like to suggest two changes I'd like to make to the PIP design > template: > 1. Remove the form - just have a markdown template fill the issue body as > it is created.

Re: Introducer Pulsar admin api to pulsar-client-go

2023-02-26 Thread Guangning E
Another idea is whether it is possible to generate clients for various languages based on the current pulsar rest swagger files? Thanks, Guangning On Sat, Feb 25, 2023 at 1:44 PM Zixuan Liu wrote: > > I would like to suggest creating a new repository called > "pulsar-admin-go" > > +1, I agreed

Re: [DISCUSS] Change PIP template

2023-02-26 Thread Girish Sharma
Good proposal Asaf. I've also wondered why the PIP creation and discussion process is so separated. The PIP discussion and voting starts off as a GitHub issue, but all of its discussion happens here on the mailing list. Is there scope of improvement in that process as well? Regards On Sun, Feb

Re: [questions] Which jakartaEE version we plan for pulsar 3.0.0?

2023-02-26 Thread Enrico Olivelli
+1 to upgrade. IIUC the main pain point is for Custom Servlet developers who will have to migrate to the jakarta.xxx packages is this correct ? Enrico Il giorno sab 25 feb 2023 alle ore 06:46 Zixuan Liu ha scritto: > > Sounds greate that migrating to jersey 3.x from jersey 2.x. > > Thanks, >

Re: [DISCUSS] Change PIP template

2023-02-26 Thread tison
Hi Asaf, I agree that, generally, a PIP is written as a whole and paste as the body. So +1 for your proposal. Additionally, I'm thinking of moving the doc of procedure (wiki/PIP.md) to the contributions guide and use the new markdown template to supersede the wiki/PIP-template.md. Then we don't

[DISCUSS] Change PIP template

2023-02-26 Thread Asaf Mesika
Hi, I would like to suggest two changes I'd like to make to the PIP design template: 1. Remove the form - just have a markdown template fill the issue body as it is created. 2. Change the PIP template structure == Removing the form Today, when you want to submit a PIP, you are required to fill