Re: [DISCUSS] Why not split `memoryLimit` into `consumerMemoryLimit ` and `producerMemoryLimit `

2023-03-12 Thread Haiting Jiang
Hi Jiaqi, >From what I see, this memory limitation is used for protecting the client from OOM when processing too many messages in the client. So setting a single client limitation is more easy for users and producer and consumer can share the memory. Normally, we should set the limitation number

Re: [DISCUSS] PIP-249: Pulsar website redesign

2023-03-12 Thread tison
Hi Asaf, SGTM. I don't have more comments on the proposal. I'll be glad to review the implementation later :) BTW, Apache mailing list doesn't support inline pictures, so you may share a link to the image? Best, tison. Asaf Mesika 于2023年3月9日周四 18:10写道: > Tison, the rest of the community - an

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-12 Thread Zike Yang
> It's not a regression. This error applies for Python client 3.0.0 as > well. Before 3.0.0, the Python client cannot be interrupted by a > signal.I'd rather treat it as the case that the implementation of > handling the UNIX signals is not so perfect.I'd rather treat it as the case > that the imp

Re: [DISCUSS] PIP 194 : Pulsar client: seek command add epoch

2023-03-12 Thread Baodi Shi
Any updates on this? On 2022/09/11 04:18:07 Qiang Huang wrote: > Hi Asaf, thank you for the very detailed reply. > > > The problem we have today is that while we have sent a request to reset > the subscription position, the broker decides to: > > 1. Close the TCP connection which in turn causes t

Re: Reuse Jetty server between unit test class.

2023-03-12 Thread Yunze Xu
Yeah, we should do that. There are many test classes that use BeforeMethod and AfterMethod for setup and teardown. We should use BeforeClass and AfterClass and take care of each single test to avoid affecting other tests in the same class. Thanks, Yunze On Sat, Mar 11, 2023 at 9:26 PM adobewjl w

Re: [DISCUSS] PIP-254: Support configuring client version at SDK level

2023-03-12 Thread Yunze Xu
> I think we > should consider putting a character limit on the field to prevent > descriptions that are too long. Good suggestion. A long description string is unnecessary and could be used as malicious code. What do you think of limiting the length to 64? I think it's long enough. Thanks, Yunz

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-03-12 Thread Yan Zhao
> > In the LedgerDeletionService start, it will create a producer for sending > > pending delete ledger. When deleting a ledger, the producer sends > > PendingDeleteLedgerInfo to the system-topic. If the sent succeeds, delete > > the ledger id from the whole ledgers and update the ledgers into the

[VOTE] Pulsar Release 2.10.4 Candidate 2

2023-03-12 Thread Xiangying Meng
This is the second release candidate for Apache Pulsar, version 2.10.4. This release contains 105 commits by 34 contributors. https://github.com/apache/pulsar/compare/v2.10.3...v2.10.4-candidate-2 *** Please download, test, and vote on this release. This vote will stay open for at least 72 hours