Re: [VOTE] PIP-265: PR-based system for managing and reviewing PIPs

2023-05-15 Thread Enrico Olivelli
Dave, I don't think that we are dropping the discussion on the mailing list. In that case I would cast a -1. Enrico Il giorno mar 16 mag 2023 alle ore 06:27 Dave Fisher ha scritto: > > -0 (binding) having discussions on the mailing list makes it much easier to > understand decisions years in

Re: [VOTE] PIP-265: PR-based system for managing and reviewing PIPs

2023-05-15 Thread Dave Fisher
-0 (binding) having discussions on the mailing list makes it much easier to understand decisions years in the future. Just yesterday I reviewed email threads in another project from 16 years ago. Best, Dave Sent from my iPhone > On May 10, 2023, at 3:52 AM, Asaf Mesika wrote: > > Hi, > >

Re: [VOTE] PIP-265: PR-based system for managing and reviewing PIPs

2023-05-15 Thread Haiting Jiang
+1 binding Thanks, Haiting On Tue, May 16, 2023 at 10:53 AM Zike Yang wrote: > > +1 (non-binding) > > BR, > Zike Yang > > On Tue, May 16, 2023 at 9:20 AM wrote: > > > > +1 (binding) > > > > Best, > > Mattison > > On May 15, 2023, 15:38 +0800, Enrico Olivelli , wrote: > > > +1 (binding) > > > >

Re: [VOTE] PIP-265: PR-based system for managing and reviewing PIPs

2023-05-15 Thread Zike Yang
+1 (non-binding) BR, Zike Yang On Tue, May 16, 2023 at 9:20 AM wrote: > > +1 (binding) > > Best, > Mattison > On May 15, 2023, 15:38 +0800, Enrico Olivelli , wrote: > > +1 (binding) > > > > The proposal makes sense to me. > > Let's try > > > > Thanks for carrying on with this initative > >

Re: [VOTE] Pulsar Client C++ Release 3.2.0 Candidate 3

2023-05-15 Thread Yunze Xu
Close this vote by 3 binding +1s * Nozomi * Penghui * Mattison 2 non-binding +1s * Baodi * Yuto Thanks, Yunze On Tue, May 16, 2023 at 6:58 AM Yunze Xu wrote: > > Hi Mattison, > > It's not a blocker. It's just because the version of the GTest > dependency you installed is too high. We can

Re: [DISCUSS] Replace stale bot with ping-pong workflow

2023-05-15 Thread Yunze Xu
+1 to me Thanks, Yunze On Sun, May 14, 2023 at 9:28 PM Dave Fisher wrote: > > Hi - > > I have not looked at all your links but I think this is a great idea. This > will help everyone pay attention better. > > Best, > Dave > > Sent from my iPhone > > > On May 14, 2023, at 12:33 AM, tison

Re: [VOTE] PIP-265: PR-based system for managing and reviewing PIPs

2023-05-15 Thread mattisonchao
+1 (binding) Best, Mattison On May 15, 2023, 15:38 +0800, Enrico Olivelli , wrote: > +1 (binding) > > The proposal makes sense to me. > Let's try > > Thanks for carrying on with this initative > Enrico > > Il giorno lun 15 mag 2023 alle ore 05:23 Max Xu ha > scritto: > > > > +1 (non-binding) >

Re: [VOTE] Pulsar Client C++ Release 3.2.0 Candidate 3

2023-05-15 Thread Yunze Xu
Hi Mattison, It's not a blocker. It's just because the version of the GTest dependency you installed is too high. We can support configuring the C++ standard with a higher version (e.g. 14, 17) in future. Thanks, Yunze On Mon, May 15, 2023 at 11:08 PM wrote: > > I found an issue here.

Re: [DISCUSS] PIP-268: Add support of topic stats/stats-internal using client api

2023-05-15 Thread Rajan Dhabalia
Hi Penghui, >> And for the Admin API, we have several supported params Good point regarding the stats/internal-stats params. I think we can pass option-map into below GET API for stats so, we can easily enhance if more options would be added in future and each option data-type can be documented

Re: [VOTE] Pulsar Client C++ Release 3.2.0 Candidate 3

2023-05-15 Thread mattisonchao
I found an issue here. https://github.com/apache/pulsar-client-cpp/issues/268 Could you help confirm if it is a problem? +1 (binding) • Build from source code on MacOS (12.5) with (Intel Core i7) • Ran pulsar-tests under the tests/ dir Best, Mattison On May 15, 2023, 18:43 +0800, PengHui Li ,

Re: [VOTE] PIP-270 Add config to set metadata size threshold for compression

2023-05-15 Thread PengHui Li
It looks good to me. Just a minor suggestion about the name of the configuration. managedLedgerInfoCompressionSizeThreshold -> managedLedgerInfoCompressionThresholdInBytes managedCursorInfoCompressionSizeThreshold -> managedCursorInfoCompressionThresholdInBytes And is it better to introduce a

Re: [DISCUSS] PIP-267: Support multi-topic messageId deserialization to ack messages

2023-05-15 Thread PengHui Li
I think the topic name will not be transmitted to the broker. The client side used the class generated by the protobuf message. Or, we can create another class to avoid coupling issues, but it will introduce more changes and copy data from one structure to another. For the long-term, I think it

Re: [DISCUSS] PIP-268: Add support of topic stats/stats-internal using client api

2023-05-15 Thread PengHui Li
I have no strong objection. Just a few questions. How do we handle the stats/internal-stats of a partitioned topic? As I understand, the client side will combine the stats/internal-stats of the partitions? It's better to clarify in the proposal. Do we need a compatibility section to clarify the

Re: [VOTE] PIP-261: Restructure Getting Started section

2023-05-15 Thread PengHui Li
Hi Asaf, I have updated the wiki page. Thanks, Penghui On Wed, May 10, 2023 at 12:53 AM Asaf Mesika wrote: > Who can help me update in https://github.com/apache/pulsar/wiki > that it has passed? > > > On Tue, May 9, 2023 at 5:01 PM Asaf Mesika wrote: > > > The vote has passed with 4 of

Re: [VOTE] PIP-265: PR-based system for managing and reviewing PIPs

2023-05-15 Thread Enrico Olivelli
+1 (binding) The proposal makes sense to me. Let's try Thanks for carrying on with this initative Enrico Il giorno lun 15 mag 2023 alle ore 05:23 Max Xu ha scritto: > > +1 (non-binding) > > Thanks for driving this helpful proposal! > > Best, > Max Xu > > > On Wed, May 10, 2023 at 6:52 PM Asaf

Re: [DISCUSS] PIP-264: Enhanced OTel-based metric system

2023-05-15 Thread Enrico Olivelli
Asaf, thanks for contributing in this area. Metrics are a fundamental feature of Pulsar. Currently I find it very awkward to maintain metrics, and also I see it as a problem to support only Prometheus. Regarding your proposal, IIRC in the past someone else proposed to support other metrics

Re: [DISCUSS] PIP-268: Add support of topic stats/stats-internal using client api

2023-05-15 Thread Enrico Olivelli
I understand the need for this PIP and I support it, but I have some questions/open points. I wonder if we should define a smaller subset of the stats/internal stats to serve to the clients using this new Request/Response. Maybe it is better to serve only the minimal amount of data that is