Re: [DISCUSS] PIP-273: Enable hostname verification by default

2023-06-07 Thread Michael Marshall
Hi Rajan, > it will cause deployment failures for many users We must consider all users. In addition to the users you describe, there are other users to consider--specifically ones that are not familiar with TLS configurations and just want to get a pulsar cluster up and running quickly. Making i

Re: [DISCUSS] PIP-275: Introduce numWorkerThreadsForPersistentTopic to deprecate numWorkerThreadsForNonPersistentTopic in configuration

2023-06-07 Thread houxiaoyu
Hi Enrico `numWorkersTopicOrderedExecutor` is OK. I have updated the pip Thanks, Xiaoyu Hou Enrico Olivelli 于2023年6月7日周三 15:44写道: > I would call it numWorkersTopicOrderedExecutor and remove > "persistent/non-persistent" from the name. > > Or alternatively we could introduce a topicOrderedExecu

Re: [DISCUSS] PIP-273: Enable hostname verification by default

2023-06-07 Thread Rajan Dhabalia
Hi, I am not sure enabling hostname verification by default is a good idea because it will cause deployment failures for many users. Hostname verification requires x509 cert changes and wildcard SNName in some cases and it's not easy when broker hostname patterns don't match in x509 certs and there

Re: [DISCUSS] PIP-273: Enable hostname verification by default

2023-06-07 Thread Michael Marshall
One late addition that I just discovered is for any pulsar CLI argument that is zero arity, we'll need to make a breaking change to make it have arity 1. For example, the --tls-enable-hostname-verification param here [0] currently works such that it is disabled when the parameter is missing and en

Re: [DISCUSS] PIP-275: Introduce numWorkerThreadsForPersistentTopic to deprecate numWorkerThreadsForNonPersistentTopic in configuration

2023-06-07 Thread Enrico Olivelli
I would call it numWorkersTopicOrderedExecutor and remove "persistent/non-persistent" from the name. Or alternatively we could introduce a topicOrderedExecutor for persistent topics. Unfortunately the topicOrderedExecutor is now used for many things (I also used it the wrong way when I introduced