[VOTE] PIP-267: Support multi-topic messageId deserialization to ack messages

2023-06-19 Thread Rajan Dhabalia
Hi. Pulsar api provides MessageId interface which is generally used by producer and consumer applications to manage topic offset. Sometimes, these applications would like to serialize and deserialize messageIds, specifically consumer app which would like to persist messageId and ack with those me

Re: [DISCUSS] PIP-267: Support multi-topic messageId deserialization to ack messages

2023-06-19 Thread Rajan Dhabalia
> So you say in that sentence that you will add the topic name into MessageIdData. MessageIdData is defined in PulsarApi.proto and is transferred over the wire, so how can you add the topic to this class without changing the wire protocol? Yes, the client creates a separate MessageId while creating

Re: [VOTE] PIP-275: Introduce topicOrderedExecutorThreadNum to deprecate numWorkerThreadsForNonPersistentTopic in configuration

2023-06-19 Thread guo jiwei
+1 (binding) Regards Jiwei Guo (Tboy) On Mon, Jun 19, 2023 at 9:00 PM Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il giorno lun 19 giu 2023 alle ore 14:48 Asaf Mesika > ha scritto: > > > > +1 (non binding) > > > > On Mon, Jun 19, 2023 at 9:19 AM 丛搏 wrote: > > > > > +1(binding) > >

[DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-19 Thread guo jiwei
Hi community: After configuring the geo-replication on Pulsar clusters, the `clusters list` API will return multiple clusters, including the local Pulsar cluster and remote clusters like ``` bin/pulsar-admin clusters list us-west us-east us-cent ``` But in this return, you can't distinguish th

Re: [VOTE] PIP-276: Add metric `pulsar_topic_load_times

2023-06-19 Thread mattisonchao
+1(binding) Best, Mattison On 20 Jun 2023 at 10:45 +0800, PengHui Li , wrote: > +1 (binding) > > Thanks, > Penghui > > On Tue, Jun 20, 2023 at 10:40 AM Yubiao Feng > wrote: > > > Voting +1 (non-binding) > > > > Thanks > > Yubiao Feng > > > > On Mon, Jun 19, 2023 at 5:21 PM Asaf Mesika wrote: > >

Re: [VOTE] PIP-276: Add metric `pulsar_topic_load_times

2023-06-19 Thread PengHui Li
+1 (binding) Thanks, Penghui On Tue, Jun 20, 2023 at 10:40 AM Yubiao Feng wrote: > Voting +1 (non-binding) > > Thanks > Yubiao Feng > > On Mon, Jun 19, 2023 at 5:21 PM Asaf Mesika wrote: > > > Voting +1 (non-binding) > > > > On Fri, Jun 16, 2023 at 12:23 PM guo jiwei wrote: > > > > > @Asaf Th

Re: [VOTE] PIP-276: Add metric `pulsar_topic_load_times

2023-06-19 Thread Yubiao Feng
Voting +1 (non-binding) Thanks Yubiao Feng On Mon, Jun 19, 2023 at 5:21 PM Asaf Mesika wrote: > Voting +1 (non-binding) > > On Fri, Jun 16, 2023 at 12:23 PM guo jiwei wrote: > > > @Asaf Thanks, I have addressed the comment. > > > > Regards > > Jiwei Guo (Tboy) > > > > > > On Fri, Jun 16, 2023

Re: [VOTE] PIP-275: Introduce topicOrderedExecutorThreadNum to deprecate numWorkerThreadsForNonPersistentTopic in configuration

2023-06-19 Thread Enrico Olivelli
+1 (binding) Enrico Il giorno lun 19 giu 2023 alle ore 14:48 Asaf Mesika ha scritto: > > +1 (non binding) > > On Mon, Jun 19, 2023 at 9:19 AM 丛搏 wrote: > > > +1(binding) > > > > Thanks, > > Bo > > > > houxiaoyu 于2023年6月19日周一 14:04写道: > > > > > > Hi, community: > > > > > > This thread is to sta

Re: Improving the usability of the bookie Isolation feature

2023-06-19 Thread Asaf Mesika
I want to add only one step to your plan. If you introduce this flag in Y.X, then in Y.(X+1), let's remove this flag and keep the "true" value as the behavior. On Mon, Jun 19, 2023 at 4:57 AM horizonzy wrote: > Background > > In the Pulsar, it has two features: > >- > >The first feature

Re: [VOTE] PIP-275: Introduce topicOrderedExecutorThreadNum to deprecate numWorkerThreadsForNonPersistentTopic in configuration

2023-06-19 Thread Asaf Mesika
+1 (non binding) On Mon, Jun 19, 2023 at 9:19 AM 丛搏 wrote: > +1(binding) > > Thanks, > Bo > > houxiaoyu 于2023年6月19日周一 14:04写道: > > > > Hi, community: > > > > This thread is to start a vote for PIP-275: Introduce > > topicOrderedExecutorThreadNum to deprecate > > numWorkerThreadsForNonPersistent

Re: [DISCUSS] PIP-267: Support multi-topic messageId deserialization to ack messages

2023-06-19 Thread Asaf Mesika
First, let me add some data that should be added to the Background section of the PIP since I had to reverse engineer the code to understand that, which is the opposite of the goal of a design document. Pulsar Broker has a binary protocol, which allows the client to consume messages, acknowle

Re: [VOTE] PIP-276: Add metric `pulsar_topic_load_times

2023-06-19 Thread Asaf Mesika
Voting +1 (non-binding) On Fri, Jun 16, 2023 at 12:23 PM guo jiwei wrote: > @Asaf Thanks, I have addressed the comment. > > Regards > Jiwei Guo (Tboy) > > > On Fri, Jun 16, 2023 at 3:55 AM Asaf Mesika wrote: > > > -1 (non-binding) > > > > I'm perfectly ok with the idea; just please fix the docu

Re: [DISCUSS] Enable "Always suggest updating pull request branches" for pulsar-site

2023-06-19 Thread Zili Chen
FYI - the proposal is applied https://issues.apache.org/jira/browse/INFRA-24636. On 2023/06/02 02:25:55 Dave Fisher wrote: > I think that INFRA would accept a DISCUSSION that looks for LAZY CONSENSUS. > > Sent from my iPhone > > > On Jun 1, 2023, at 7:18 PM, tison wrote: > > > > While we can