Re: [DISCUSS] Release DotPulsar 3.0.0

2023-08-27 Thread Zike Yang
+1 I am looking forward to this new release. Thanks, Zike Yang On Mon, Aug 28, 2023 at 9:15 AM PengHui Li wrote: > > +1 > > Thanks for driving the release. > > Penghui > > On Fri, Aug 25, 2023 at 9:48 PM David Jensen wrote: > > > Dear Apache PMC and Committers > > > > Me and Daniel Blankenstei

Re: [DISCUSS]PIP-295: Fixing Chunk Message Duplication Issue

2023-08-27 Thread Xiangying Meng
Hi community, After internal discussions and agreement with Penghui and Zike, we've come to a consensus that a small amount of dirty data within the topic can be tolerated. As a result, this proposal has lost its significance. We are now closing this discussion. Thanks to all participants for thei

Re: [VOTE] PIP 296: Introduce the `getLastMessageIds` API to Reader

2023-08-27 Thread Zili Chen
+1 (binding) Thanks for driving the proposal! On 2023/08/25 06:52:38 Xiangying Meng wrote: > Hi Pulsar Community, > > This is the vote thread for PIP 296: > https://github.com/apache/pulsar/pull/21052 > > This PIP will help to improve the flexibility of Reader usage. > > Thanks, > Xiangying >

Re: [DISCUSS] PIP-286: Add findNewestPosition method in the TopicCompactionService API

2023-08-27 Thread Cong Zhao
Hi Penghui, Thanks for the suggestion. First, I changed the method to findFirstEntryMetadata because I think it's more common to look for the first matching entry compared to finding the entry of the last match, e.g. to look for the first position greater than or equal to a specific publish ti

Re: [DISCUSS]PIP-295: Fixing Chunk Message Duplication Issue

2023-08-27 Thread Xiangying Meng
Hi Penghui, >From my understanding. >The message deduplication should only check the last chunk of the message. Yes, I agree. If we only check the first chunk, the third chunk will be dropped. Thanks, Xiangying On Mon, Aug 28, 2023 at 10:08 AM PengHui Li wrote: > > Hi Xiangying, > > Thanks for

Re: [DISCUSS]PIP-295: Fixing Chunk Message Duplication Issue

2023-08-27 Thread PengHui Li
Hi Xiangying, Thanks for driving the proposal. >From my understanding. The message deduplication should only check the last chunk of the message. It doesn't need to care about whether each chunk is duplicated. The client side should handle issues like duplicated chunks. For the example that you h

Re: [VOTE] PIP 296: Introduce the `getLastMessageIds` API to Reader

2023-08-27 Thread Hang Chen
+1 (binding) Regards, Hang 于2023年8月28日周一 08:59写道: > > +1(binding) > > Best, > Mattison > On 28 Aug 2023 at 08:53 +0800, PengHui Li , wrote: > > +1 (binding) > > > > Thanks, > > Penghui > > > > On Fri, Aug 25, 2023 at 8:09 PM Yubiao Feng > > wrote: > > > > > +1 (non-binding) > > > > > > Thanks >

Re: [DISCUSS] PIP-286: Add findNewestPosition method in the TopicCompactionService API

2023-08-27 Thread PengHui Li
Hi Cong, Thanks for driving the proposal. Is it better to use `readNewestCompactedEntry(@Nonnull Predicate condition)` So that you don't need to introduce a new interface, RawEntryMetadata And it's a more general solution for the TopicCompactionService. WDYT? Regards, Penghui On Tue, Jul 25, 2

Re: [DISCUSS] Release DotPulsar 3.0.0

2023-08-27 Thread PengHui Li
+1 Thanks for driving the release. Penghui On Fri, Aug 25, 2023 at 9:48 PM David Jensen wrote: > Dear Apache PMC and Committers > > Me and Daniel Blankensteiner (blankensteiner) would like to announce we are > soon ready to release DotPulsar 3.0.0. > > The release contains breaking changes, th

Re: [VOTE] Pulsar Client Python Release 3.3.0 Candidate 1

2023-08-27 Thread PengHui Li
OS: macOS Ventura Version 13.4.1 (c) (22F770820d) Python: 3.11.4 +1 (binding) - Checked the signature - Build wheel from source - Run examples Regards, Penghui On Mon, Aug 21, 2023 at 10:24 PM Yunze Xu wrote: > +1 (binding) > > - Verified signature and checksums > - Build the wheel from sour

Re: [VOTE] PIP 296: Introduce the `getLastMessageIds` API to Reader

2023-08-27 Thread mattisonchao
+1(binding) Best, Mattison On 28 Aug 2023 at 08:53 +0800, PengHui Li , wrote: > +1 (binding) > > Thanks, > Penghui > > On Fri, Aug 25, 2023 at 8:09 PM Yubiao Feng > wrote: > > > +1 (non-binding) > > > > Thanks > > Yubiao Feng > > > > On Fri, Aug 25, 2023 at 2:53 PM Xiangying Meng > > wrote: > >

Re: [VOTE] PIP 296: Introduce the `getLastMessageIds` API to Reader

2023-08-27 Thread PengHui Li
+1 (binding) Thanks, Penghui On Fri, Aug 25, 2023 at 8:09 PM Yubiao Feng wrote: > +1 (non-binding) > > Thanks > Yubiao Feng > > On Fri, Aug 25, 2023 at 2:53 PM Xiangying Meng > wrote: > > > Hi Pulsar Community, > > > > This is the vote thread for PIP 296: > > https://github.com/apache/pulsar/p