Re: [DISCUSS] PIP-391: Enable batch index ACK by default

2024-11-07 Thread Zixuan Liu
+1 Thanks, Zixuan Yunze Xu 于2024年11月6日周三 20:45写道: > Hi all, > > I wrote a PIP (https://github.com/apache/pulsar/pull/23567) to enable > batch index ACK by default. > > From my experiences, the default ACK semantics are really confusing > and it's hard to explain the implementation details to us

Re: [DISCUSS] PIP-391: Enable batch index ACK by default

2024-11-07 Thread WenZhi Feng
+1. On 2024/11/06 12:44:42 Yunze Xu wrote: > Hi all, > > I wrote a PIP (https://github.com/apache/pulsar/pull/23567) to enable > batch index ACK by default. > > From my experiences, the default ACK semantics are really confusing > and it's hard to explain the implementation details to users. Eve

Re: [DISCUSS] PIP-385 Add rate limit semantics to pulsar protocol and Java client

2024-11-07 Thread Girish Sharma
Hello everything! Thank you for participating in the discussion. It's been over a month now. I will be starting a VOTE thread tomorrow. Regards On Thu, Oct 31, 2024 at 2:28 AM Rajan Dhabalia wrote: > Hi Girish, > > I apologize for the delayed response. I have added my comments on the > proposa

Re: [DISCUSS] PIP-391: Enable batch index ACK by default

2024-11-07 Thread Baodi Shi
+1 Not enabling batchIndexAck will cause confusion for users. In the future, we could even remove the client-maintained bitset to keep the client logic simple. Thanks, Baodi Shi PengHui Li 于2024年11月8日周五 08:26写道: > > +1 > > I also had many questions during the discussion with Pulsar users. >

Re: [DISCUSS] PIP-391: Enable batch index ACK by default

2024-11-07 Thread PengHui Li
+1 I also had many questions during the discussion with Pulsar users. It's not easy to understand why their consumers get a lot of duplicated messages with batch messages without any consumer or broker restarts. Regards Penghui On Wed, Nov 6, 2024 at 4:45 AM Yunze Xu wrote: > Hi all, > > I wro

Re: [DISCUSS] PCIP-1 Add the development process for pulsar-java-contrib project

2024-11-07 Thread Jia Zhai
+1 👍 It is a good start. On Wed, Nov 6, 2024 at 10:26 AM lushiji(apache) wrote: > Hello Pulsar Community, > The development process of the pulsar-java-contrib project was not detailed > before. I proposed a process to simplify the development process and > provide detailed designs and instructio

Re: [DISCUSS] Add Common Integ Test Modules

2024-11-07 Thread Lari Hotari
Yes, it makes sense to start supporting Junit 5 for new tests. This is the reason why we should be moving the infrastructure out of base classes so that the same test infrastructure could be used in TestNG and Junit 5 tests. One example is the PulsarTestContext class which can be used in both ca

Re: Jakarta EE migration

2024-11-07 Thread Lari Hotari
On Thu, 7 Nov 2024 at 07:38, Christian Ortlepp wrote: > > > Semantic versioning is followed. > > Even if no Jakarta Interfaces/Annotations are part of Pulsars public > API, switching to jakarta can (and probably will) mess with the > dependency resolution of everybody who uses the client. So I do