Re: [VOTE] Pulsar Client Go Release 0.16.0 Candidate 1

2025-07-29 Thread Jie crossover
+1 (non-binding) - Verified checksum and signatures - Built from source with go1.23.4 darwin/arm64 - Ran the perf tool -- Best Regards! crossoverJie -- Best Regards! crossoverJie Zike Yang 于2025年7月29日周二 18:28写道: > Hi everyone, > Please review and vote on the release candidate #1 for the versi

Re: [VOTE] PIP-430: Pulsar Broker cache improvements: refactoring eviction and adding a new cache strategy based on expected read count

2025-07-29 Thread PengHui Li
I think my initial question was quite straightforward: Can we allow more time for reviewers to go through critical changes after a proposal is aligned? A few hours are likely not enough, especially considering reviewers may be in different time zones. 2 cents about the configuration: This isn’

Re: [DISCUSS] PIP-423: Add Support for Cancelling Individual Delayed Messages

2025-07-29 Thread PengHui Li
Hi SiNan, LGTM, left a comment about the REST API definition. Regards, Penghui On Thu, Jul 17, 2025 at 7:13 AM SiNan Liu wrote: > The document has been updated, please review it again. > https://github.com/apache/pulsar/pull/24370 > > > Thanks, > sinan > > > PengHui Li 于2025年6月19日周四 07:32写道:

Re: [DISCUSS] Whether to recycle failed recyclable objects

2025-07-29 Thread PengHui Li
I think the question is a more general question about reusing objects, not only for failed recyclable objects. Can we add a reference counter to the recyclable objects (implement the ReferenceCounted interface), There could be some corner cases that were missed in the release of the counter. We can

Re: [VOTE] PIP-434: Expose Netty channel configuration WRITE_BUFFER_WATER_MARK to pulsar conf and pause receive requests when channel is unwritable

2025-07-29 Thread PengHui Li
Hi Yubiao, Thanks for driving the proposal. I have left some comments on the proposal that need clarification or alignment before I can cast my vote. Regards, Penghui On Mon, Jul 28, 2025 at 7:15 PM Tao Jiuming wrote: > +1 nonbinding > > Lari Hotari 于2025年7月26日 周六01:20写道: > > > +1 (binding) >

Re: [DISCUSS]PIP-436:add decryptFailListener to Consumer

2025-07-29 Thread PengHui Li
+1 LGTM. Thanks, Penghui On Mon, Jul 28, 2025 at 12:48 AM Ruimin MA wrote: > Hi everyone, > I've drafted a proposal to add a decryptFailListener feature for the > Consumer (https://github.com/apache/pulsar/pull/24572). > I'd greatly appreciate any feedback, questions, or suggestions you may >

Re: [DISCUSS] Pulsar releases 3.0.13, 3.3.8 and 4.0.6

2025-07-29 Thread Lari Hotari
The issue blocking the release has been resolved and I will start the 3.0.13, 3.3.8 and 4.0.6 release candidates after validating that Pulsar CI status for the maintenance branches looks ok. -Lari On 2025/07/26 13:51:02 Lari Hotari wrote: > Heesung helped resolve the remaining issues with Exten

[VOTE] Pulsar Client Go Release 0.16.0 Candidate 1

2025-07-29 Thread Zike Yang
Hi everyone, Please review and vote on the release candidate #1 for the version 0.16.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This is the first release candidate for Apache Pulsar Go client, version 0.16.0. It fixes the follo