Re: [Discuss] Make docker image default group rootless

2023-08-29 Thread asn
se that follows the OpenShift guidelines [0]. > > Thanks, > Michael > > [0] > https://docs.openshift.com/container-platform/3.11/creating_images/guidelines.html#openshift-specific-guidelines > > > On Tue, Aug 29, 2023 at 5:33 AM asn wrote: > > > > Hi dev, &

[Discuss] Make docker image default group rootless

2023-08-29 Thread asn
Hi dev, Currently, pulsar image uses root group default. To make the image more safe, we can add a group `pulsar`, and then add the default user `pulsar` into this group. The change is located at https://github.com/apache/pulsar/pull/21084 Thanks! yaalsn

Re: [DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-07-10 Thread asn
> > Sent from my iPhone > > > On Jun 29, 2023, at 9:41 PM, asn wrote: > > > > Hi, everyone > > > > Since this PR cherry-picked to branch-2.11, the Docker image build > failed. > > The reason is this script ` > > > https://github.com/apache/puls

Re: [DISCUSS] About cherry-picking `Use Ubuntu 22.04 for Pulsar images (#20475)`

2023-06-29 Thread asn
Hi, everyone Since this PR cherry-picked to branch-2.11, the Docker image build failed. The reason is this script ` https://github.com/apache/pulsar/blob/branch-2.10/docker/pulsar/scripts/install-pulsar-client.sh`, ubuntu 20.04 python version is 3.8, but 22.04 python version is 3.10.

Re: [DISSCUSS] Code coverage report for PRs to master

2022-09-09 Thread asn
Hi, IMO, code coverage is not just a number, 50% or 70% makes no sense except to let us feel that we have more confidence. So what is really important? I think it is the *coverage* itself, we need to see where we need to write tests in the future based the result because only if we have this