Re: [DISCUS] PIP-273: Add metric prefix for `topic_load_times`

Thanks, @Michael. @Asaf > Perhaps add a new metric with correct name and mark that one deprecated. Looks good Regards Jiwei Guo (Tboy) On Mon, Jun 5, 2023 at 4:23 AM Asaf Mesika wrote: > You will break anyone using this from 2017. > Perhaps add a new metric with correct name and mark that on

Re: [DISCUS] PIP-273: Add metric prefix for `topic_load_times`

You will break anyone using this from 2017. Perhaps add a new metric with correct name and mark that one deprecated. Next LTS version it can be removed? How does this things managed? On Sat, Jun 3, 2023 at 2:34 AM Dave Fisher wrote: > There are two PIP-273s. Whichever was last please update. >

Re: [DISCUS] PIP-273: Add metric prefix for `topic_load_times`

There are two PIP-273s. Whichever was last please update. Sent from my iPhone > On Jun 2, 2023, at 2:41 PM, Michael Marshall wrote: > > +1. Can we also add a test to verify that this kind of addition isn't > possible in the future? > > On a procedure note, I created PIP 273 earlier this week.

Re: [DISCUS] PIP-273: Add metric prefix for `topic_load_times`

+1. Can we also add a test to verify that this kind of addition isn't possible in the future? On a procedure note, I created PIP 273 earlier this week. I think this is PIP 274. Thanks, Michael On Fri, Jun 2, 2023 at 2:40 AM Yubiao Feng wrote: > > Hi Jiwei > > +1 > > Thanks > Yubiao Feng > > On

Re: [DISCUS] PIP-273: Add metric prefix for `topic_load_times`

Hi Jiwei +1 Thanks Yubiao Feng On Fri, Jun 2, 2023 at 3:23 PM guo jiwei wrote: > Hi, community: > The metrics are all started with `pulsar_`, so that both users and > operators can quickly find the metrics of the entire system through > this prefix. However, due to some other reasons, it w

Re: [DISCUS] PIP-273: Add metric prefix for `topic_load_times`

So I have opened apache/pulsar#20476 to discuss this. Regards Jiwei Guo (Tboy) Regards Jiwei Guo (Tboy) On Fri, Jun 2, 2023 at 3:22 PM guo jiwei wrote: > Hi, community: > The metrics are all started with `pulsar_`, so that both users and >

[DISCUS] PIP-273: Add metric prefix for `topic_load_times`

Hi, community: The metrics are all started with `pulsar_`, so that both users and operators can quickly find the metrics of the entire system through this prefix. However, due to some other reasons, it was found that `topic_load_times` was missing the prefix, so want to get it right. In mas