Re: [DISCUSS][txn] Move checked exception into builder when newTransaction.

2023-01-30 Thread Nicolò Boschi
+1 Thanks, Nicolò Boschi Il giorno lun 30 gen 2023 alle ore 09:33 Zike Yang ha scritto: > Thanks for your PR. I think this looks good to me. > > Thanks, > Zike Yang > > On Mon, Jan 30, 2023 at 4:23 PM Enrico Olivelli > wrote: > > > > I totally agree. > > There has been little API Design error

Re: [DISCUSS][txn] Move checked exception into builder when newTransaction.

2023-01-30 Thread Zike Yang
Thanks for your PR. I think this looks good to me. Thanks, Zike Yang On Mon, Jan 30, 2023 at 4:23 PM Enrico Olivelli wrote: > > I totally agree. > There has been little API Design error to add that "throws" clause. > > Thanks for the initiative > > Enrico > > Il giorno lun 30 gen 2023 alle ore

Re: [DISCUSS][txn] Move checked exception into builder when newTransaction.

2023-01-30 Thread Enrico Olivelli
I totally agree. There has been little API Design error to add that "throws" clause. Thanks for the initiative Enrico Il giorno lun 30 gen 2023 alle ore 09:16 ha scritto: > > Hello, everyone > > I submitted this PR https://github.com/apache/pulsar/pull/19356 to discuss if > we can accept

[DISCUSS][txn] Move checked exception into builder when newTransaction.

2023-01-30 Thread mattisonchao
Hello, everyone I submitted this PR https://github.com/apache/pulsar/pull/19356 to discuss if we can accept moving this checked exception into the builder to avoid adding more useless try-catch blocks. In practice, we should create the new transaction like this: ```java final