Making a change to formatting is a broad change that cause more harm than
benefit to the Pulsar project currently.
We can reconsider after the maintenance strategy has been revisited.
The discussion about the maintenance strategy is in a separate thread [1].
Even with a different type of mainten
Top
tison 于2023年6月30日周五 09:58写道：
> Hi,
>
> I'd like to propose applying a consistent code style (especially whitespace
> and indent) with an autotool Spotless.
>
> // Background
>
> Over and over we argue contributors reformat their patch manually for
> checkstyle violations, or even whitespace
t;>>>>>> that
> > >>>>>>>> we support.
> > >>>>>>>>
> > >>>>>>>> I think that this is not a good option for Pulsar at this stage.
> > >>>>>>>>
> >
it will add.
> >>>>>>>>>> From my experience, it's fine. The code style
> >>>>>>>>>> is not consistent but doesn't affect my code reading
> >>>>>>>>>> and writing much. But it might introduce risk
rd this direction, it should be picked to branch-3.0
>>>> and
>>>>>>>>> branch-3.1. Earlier versions can be ported on demand and I'm glad
>> to
>>>>>>>>> volunteer doing that.
>>>>>>>>>
>&g
;>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>
> https://github.blog/changelog/2022-03-24-ignore-commits-in-the-blame-view-beta/
> >>&
rn is how much value it will add.
>>>>>>>> From my experience, it's fine. The code style
>>>>>>>> is not consistent but doesn't affect my code reading
>>>>>>>> and writing much. But it might introduce risks and we
>>>>&
t;> and writing much. But it might introduce risks and we
> >>>>>> need to pay much effort to the code review.
> >>>>>>
> >>>>>> Regards,
> >>>>>> Penghui
> >>>>>>
> >>>>>> On We
>>>>>
>>>>>>> ... which seems a GitHub only extension -
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>> https://github.blog/changelog/2022-03-24-ignore-commits-in-the-blame-v
; > > > > > >> My mistake. It looks that for some reason Spotless supports
> > > > > > .editorconfig
> > > > > > >> only for ktlint.
> > > > > > >>
> > > > > > >> Best,
> > > >
; >
> > > > > tison 于2023年7月5日周三 19:38写道：
> > > > >
> > > > > > For the git blame issue, I found also this practice in
> > StreamPark[1].
> > > > > >
> > > > > > cc @Yunze.
> > > > > >
t; > cc @Yunze.
> > > > >
> > > > > Best,
> > > > > tison.
> > > > >
> > > > > [1]
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-streampark/blob/cac931ae289e0753892
n.
> > > >
> > > > [1]
> > > >
> > >
> >
> https://github.com/apache/incubator-streampark/blob/cac931ae289e0753892279336e1c4e70e5f7d7c6/.git-blame-ignore-revs
> > > >
> > > >
> > > > Kiryl Valkovich 于2023年6月30日周五
t;
> > >> It looks like Spotless supports it.
> > >> https://github.com/diffplug/spotless/issues/734
> > >>
> > >> Flink and many other ASF projects use it.
> > >>
> >
> https://github.com/apache/flink/blob/21eba4ca4cb235a218
日周五 13:03写道：
> >
> >> My mistake. It looks that for some reason Spotless supports
> .editorconfig
> >> only for ktlint.
> >>
> >> Best,
> >> Kiryl
> >>
> >> From: Kiryl Valkovich
> >> Date: Friday, June 30, 2023 at 6:
t.
>>
>> Best,
>> Kiryl
>>
>> From: Kiryl Valkovich
>> Date: Friday, June 30, 2023 at 6:45 AM
>> To: dev@pulsar.apache.org
>> Subject: Re: [DISCUSS] Consistent code style (esp. ws/indent) and
>> autotools
>> Hi,
>>
>> tison, a
ome reason Spotless supports .editorconfig
> only for ktlint.
>
> Best,
> Kiryl
>
> From: Kiryl Valkovich
> Date: Friday, June 30, 2023 at 6:45 AM
> To: dev@pulsar.apache.org
> Subject: Re: [DISCUSS] Consistent code style (esp. ws/indent) and autotools
> Hi
My mistake. It looks that for some reason Spotless supports .editorconfig only
for ktlint.
Best,
Kiryl
From: Kiryl Valkovich
Date: Friday, June 30, 2023 at 6:45 AM
To: dev@pulsar.apache.org
Subject: Re: [DISCUSS] Consistent code style (esp. ws/indent) and autotools
Hi,
tison, are you going
code style (esp. ws/indent) and autotools
Hi,
I'd like to propose applying a consistent code style (especially whitespace
and indent) with an autotool Spotless.
// Background
Over and over we argue contributors reformat their patch manually for
checkstyle violations, or even whitespace changes
I would wait to make changes on a branch immediately after the next patch
releases.
Best,
Dave
Sent from my iPhone
> On Jun 29, 2023, at 8:52 PM, tison wrote:
>
> `git blame` can set a start commit [1] so you can actually blame before the
> format commit. It's integrated with IDEA[2] and Gi
`git blame` can set a start commit [1] so you can actually blame before the
format commit. It's integrated with IDEA[2] and GitHub Web UI[3][4] also.
Best,
tison.
[1]
https://stackoverflow.com/questions/5098256/how-can-i-view-prior-commits-with-git-blame
[2]
https://www.jetbrains.com/help/idea/vi
One thing I’m concerned about is that the code reformatting could bring very
wide changes and it’s very unfriendly to the `git blame` command.
The check style plugin was not applied to all modules as well. There were many
PRs to apply the check style plugin for different modules. Take my PR [1] as
> Spotless has an IDEA plugin, but it's for Gradle task only.
I saw this one also 🥲.
> [1] can be used
Nice, IMO having at least one will suffice 👍🏻.
Thanks,
joohyuk
On Fri, Jun 30, 2023 at 11:43 AM tison wrote:
> > IDE
>
> If using the palantir style, [1] can be used. Spotless has an IDEA p
> IDE
If using the palantir style, [1] can be used. Spotless has an IDEA plugin
but it's for Gradle task only.
Best,
tison.
[1] https://plugins.jetbrains.com/plugin/13180-palantir-java-format
Joo Hyuk Kim 于2023年6月30日周五 10:38写道：
> Sounds great.
>
> Another thing is about IDE.
> Pulsar site so
Sounds great.
Another thing is about IDE.
Pulsar site sort of directs contributors to use IntelliJ as shown in
https://pulsar.apache.org/contribute/setup-ide/.
It would be nice if there was IDE support (auto-format, or shortkey-base)
and we can add it to the setup-ide guide also.
Do you know any?
Hi,
I'd like to propose applying a consistent code style (especially whitespace
and indent) with an autotool Spotless.
// Background
Over and over we argue contributors reformat their patch manually for
checkstyle violations, or even whitespace changes that are not detected by
checkstyle. [1]
A
26 matches
Mail list logo
