Re: [DISCUSS] PIP-250: Add proxyVersion to CommandConnect

2023-04-11 Thread Xiangying Meng
Hi Michael, I appreciate your detailed explanation. I agree with your proposal. It seems that sharing version information between the proxy and broker would indeed be beneficial for debugging purposes without creating an unnecessary tight coupling between the two components. I appreciate your wi

Re: [DISCUSS] PIP-250: Add proxyVersion to CommandConnect

2023-04-10 Thread Michael Marshall
Thanks for your feedback Mattison and Xiangying. I'll note that the PIP vote did close already and I have the implementation just about done, but I'm happy to discuss this feature a bit more here. > we should avoid coupling the concepts in the proxy and the broker Sharing version information does

Re: [DISCUSS] PIP-250: Add proxyVersion to CommandConnect

2023-04-08 Thread Xiangying Meng
Dear Michael, I think the intention behind this is excellent, but directly modifying the protocol might be a bit too heavy-handed. This approach may lead to data redundancy. In large-scale clusters, every client connection would need to transmit the extra proxy version information, which might i

Re: [DISCUSS] PIP-250: Add proxyVersion to CommandConnect

2023-04-06 Thread mattisonchao
Sorry for the late response. Why do we need to make the broker aware of the proxy when, by normal software design, we should avoid coupling the concepts in the proxy and the broker? The previous authentication was for historical reasons, but we should not continue to introduce this coupling. T

Re: [DISCUSS] PIP-250: Add proxyVersion to CommandConnect

2023-02-24 Thread Michael Marshall
Great suggestions, Enrico. > It would be interesting to reject connections on the Proxy if the > client tries to set that field. I support making the proxy reject invalid input. We could also have the client reject connections where the client connect command includes `original_principal`, `origi

Re: [DISCUSS] PIP-250: Add proxyVersion to CommandConnect

2023-02-24 Thread Enrico Olivelli
Makes sense. It would be interesting to reject connections on the Proxy if the client tries to set that field. On the broker there is no way to distinguish a proxy from a client, that's fair. But on the proxy it is not expected to see a connection from another proxy. +1 Enrico Il giorno ven 24

Re: [DISCUSS] PIP-250: Add proxyVersion to CommandConnect

2023-02-24 Thread Zike Yang
Hi, Michael Thanks for initiating this PIP. +1 BR, Zike Yang Zike Yang On Fri, Feb 24, 2023 at 12:16 PM Michael Marshall wrote: > > Hi Pulsar Community, > > In talking with Zike Yang on > https://github.com/apache/pulsar/pull/19540, we identified that it > would be helpful for the proxy to f

[DISCUSS] PIP-250: Add proxyVersion to CommandConnect

2023-02-23 Thread Michael Marshall
Hi Pulsar Community, In talking with Zike Yang on https://github.com/apache/pulsar/pull/19540, we identified that it would be helpful for the proxy to forward its own version when connecting to the broker. Here is a related PIP to improve the connection information available to operators. Issue: