Re: [DISCUSS] PIP-313 Support force unsubscribe using consumer api

2023-11-05 Thread Rajan Dhabalia
Hi Penghui, Yes, I agree with all your comments and I will update the PIP by adding that information. Thanks, Rajan On Sun, Oct 29, 2023 at 7:17 PM PengHui Li wrote: > Hi Rajan, > > The proposal looks good to me. > The context and the goal are clear. > > I have 2 comments here > > 1. The chang

Re: [DISCUSS] PIP-313 Support force unsubscribe using consumer api

2023-10-29 Thread PengHui Li
Hi Rajan, The proposal looks good to me. The context and the goal are clear. I have 2 comments here 1. The change will not only affect the shared subscription, but it will also affect the Failover and Key_Shared subscriptions. 2. We should also mention the behavior of other consumers when one co

[DISCUSS] PIP-313 Support force unsubscribe using consumer api

2023-10-26 Thread Rajan Dhabalia
Hi, We have an issue created regarding unsubscription of shared subscription in Pulsar spout at : https://github.com/apache/pulsar/issues/21451 This PIP addresses the issue and allows users to unsubscribe subscription with additional force option. PIP: https://github.com/apache/pulsar/pull/21452/