Re: [DISCUSS] Switch to the Temurin JDK in the Docker image

2022-08-30 Thread Zixuan Liu
I made a PR for this idea, see https://github.com/apache/pulsar/pull/17129 Please help review if you have time, thanks! Zixuan Zixuan Liu 于2022年8月15日周一 13:18写道: > Thank Qiang for your explanation! > > Qiang Huang 于2022年8月14日周日 12:15写道: > >> LGTM. They are very similar. >> The OpenJDK provides

Re: [DISCUSS] Switch to the Temurin JDK in the Docker image

2022-08-14 Thread Zixuan Liu
Thank Qiang for your explanation! Qiang Huang 于2022年8月14日周日 12:15写道: > LGTM. They are very similar. > The OpenJDK provides source-code, and the Temurin JDK provides builds of > the source code. > I would like to point out that they have different licenses. > - The OpenJDK implementation is licen

Re: [DISCUSS] Switch to the Temurin JDK in the Docker image

2022-08-13 Thread Qiang Huang
LGTM. They are very similar. The OpenJDK provides source-code, and the Temurin JDK provides builds of the source code. I would like to point out that they have different licenses. - The OpenJDK implementation is licensed under the GPL-2.0-only with a linking exception. [0] - The Eclipse Temurin™ pr

Re: [DISCUSS] Switch to the Temurin JDK in the Docker image

2022-08-12 Thread Zixuan Liu
Hi tison, Great catch! The Temurin JDK is OpenJDK distribution from Adoptium, the old JDK from Ubuntu, they should all be built on the OpenJDK open source project, so I think should be fully compatible. Each Temurin release has passed the relevant Oracle Java Compatibility Kit (JCK) to demonstra

Re: [DISCUSS] Switch to the Temurin JDK in the Docker image

2022-08-12 Thread tison
+1 Thanks for bringing this topic :) In Pulsar usages, these two distributions should not be quite different. Did you investigate the compatibility more? Best, tison. Zixuan Liu 于2022年8月12日周五 15:17写道: > Hi all, > > I noticed we are using OpenJDK in our Docker image, I suggest that we > switc

Re: [DISCUSS] Switch to the Temurin JDK in the Docker image

2022-08-12 Thread Zixuan Liu
The following versions need to be modified: 2.11, 2.10, 2.9, 2.8, and 2.7. Zixuan Liu 于2022年8月12日周五 15:17写道: > Hi all, > > I noticed we are using OpenJDK in our Docker image, I suggest that we > switch to the Temurin JDK, because our CI runs on the Temurin JDK, we need > to keep the same JDK eve

[DISCUSS] Switch to the Temurin JDK in the Docker image

2022-08-12 Thread Zixuan Liu
Hi all, I noticed we are using OpenJDK in our Docker image, I suggest that we switch to the Temurin JDK, because our CI runs on the Temurin JDK, we need to keep the same JDK everywhere to avoid unexpected problems. Thanks, Zixuan