>I think the RateLimiter can handle it:
https://github.com/apache/pulsar/blob/a1405ea006f175b1bd0b9d28b9444d592fb4a010/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L965-L968
See here. Do you mean we make `maxConcurrentUnloadPerSec` and
`brokerShutdownMaxNumberOfG
> If we want the
maximum concurrency per second to be 1, and set the maximum
concurrency per minute to 60, then the actual maximum concurrency per
second could be up to 60, which is 60 times larger than our expected
maximum concurrency.
I think the RateLimiter can handle it:
https://github.com/apa
Hi Donglai, Heesung
>brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute=60 is the same as
brokerShutdownMaxNumberOfGracefulBundleUnloadPerSec=1 So, the "per-min"
config can be more granular.
I have some doubts about introducing the
`brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute`
conf
Hi Donglai, Mattison
I agree with @Mattison
Thanks
Yubiao Feng
On Mon, Aug 21, 2023 at 8:50 PM wrote:
>
> Hi,
>
> I agree with this change to improve the stability of the pulsar cluster.
>
> Just one concern. it's better to move this discussion to a new PIP.
> because you wanna introduce a new
Hi,
I agree with this change to improve the stability of the pulsar cluster.
Just one concern. it's better to move this discussion to a new PIP. because you
wanna introduce a new broker configuration.
`brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute`
FYI: https://github.com/apache/puls
> `brokerShutdownMaxNumberOfGracefulBundleUnloadPerSec=1` So, the "per-min"
config can be more granular.
Oh, okay. I thought we would end up only using one of
`brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute`
`brokerShutdownMaxNumberOfGracefulBundleUnloadPerSec`
... these two.
If there
> but we should also consider per-minute could be too slow for some.
Could you clarify this part?
`brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute=60` is the same as
`brokerShutdownMaxNumberOfGracefulBundleUnloadPerSec=1` So, the "per-min"
config can be more granular.
Heesung
On Thu, Jul
Hi,
I agree that unloading per-sec might too fast, but we should also consider
per-minute could be too slow for some.
So we might as well add configurability for unload rate (in seconds).But I
am concerend that we might end up having too many parameters 🤔
Thanks,
JooHyukKim(vince)
On Fri, Jul 7,
Hi,
I agree with configuring the `shutdown.unloadNamespaceBundlesGracefully`
behavior by a dynamic config.
Also, I wonder if the better config is
`brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute` to support a
slower rate.
One bundle unloading per sec could be too fast if there are many
top
Thanks, 🙂
JooHyukKim (vince)
On Fri, Jul 7, 2023 at 11:59 AM Joo Hyuk Kim wrote:
> > When Pulsar undergoes a graceful shutdown, it unloads all topics, but
> there is no limit on the rate of unloading
>
> Is it possible that following code might already cover what we need here?
>
>
> https://git
> When Pulsar undergoes a graceful shutdown, it unloads all topics, but
there is no limit on the rate of unloading
Is it possible that following code might already cover what we need here?
https://github.com/apache/pulsar/blob/7636e8989f4d3fc24fce69a356d54e1c550945ed/pulsar-broker/src/main/java/o
Hi -
Interesting. I’m curious to know what Heesung, Lari, and others think.
Best,
Dave
Sent from my iPhone
> On Jul 6, 2023, at 7:01 PM, labuladong wrote:
>
> Dear Apache Pulsar community,
>
>
> When Pulsar undergoes a graceful shutdown, it unloads all topics, but there
> is no limit on t
12 matches
Mail list logo
