Looks there is no objection, I will start the official vote for PIP-122
Regards,
Hang
Michael Marshall 于2022年1月8日周六 07:44写道：
>
> Hi Frank,
>
> You can configure the Load Shedding Strategy in the `broker.conf` file
> using `loadBalancerLoadSheddingStrategy`.
>
> The configuration is missing from
Hi Frank,
You can configure the Load Shedding Strategy in the `broker.conf` file
using `loadBalancerLoadSheddingStrategy`.
The configuration is missing from the document you referenced--it
should be there, though.
There was a recent PR to add documentation describing the different
configuration
This is very cool.
How is `ThresholdShedder` chosen - I don't see if referenced here?
https://pulsar.apache.org/docs/en/reference-configuration/
-F
On Thu, Jan 6, 2022 at 7:45 PM Sijie Guo wrote:
> +1 ThresholdShedder is a much better policy
>
> On Tue, Jan 4, 2022 at 6:24 AM Hang Chen
+1 ThresholdShedder is a much better policy
On Tue, Jan 4, 2022 at 6:24 AM Hang Chen wrote:
> https://github.com/apache/pulsar/issues/13340
>
> Pasted below for quoting convenience.
>
>
> ### Motivation
> The ThresholdShedder load balance policy since Pulsar 2.6.0 by
>
Hi Michael,
Thanks for you review, it will push a PR to add a test for
`ThresholdShedder `.
Best,
Hang
Michael Marshall 于2022年1月5日周三 00:55写道：
>
> Hi Hang Chen,
>
> I support changing the default for 2.10.
>
> However, as far as I can tell, there are unit tests for the
> `OverloadShedder`
Hi Hang Chen,
I support changing the default for 2.10.
However, as far as I can tell, there are unit tests for the
`OverloadShedder` class but not for the `ThresholdShedder` class. I
think we should add unit tests before we change the default.
Regarding integration tests, I assume that we
https://github.com/apache/pulsar/issues/13340
Pasted below for quoting convenience.
### Motivation
The ThresholdShedder load balance policy since Pulsar 2.6.0 by
https://github.com/apache/pulsar/pull/6772. It can resolve many load
balance issues of `OverloadShedder` and works well in many
