Matt-Esch opened a new pull request, #215: URL: https://github.com/apache/pulsar-client-node/pull/215
There appears to be a race condition that causes the close callback to execute twice on close. I believe that a similar issue existed with the old synchronous api call in a async worker, it just materialised slightly differently. There is a proposed fix for it here https://github.com/apache/pulsar/pull/15508 This PR temporarily fixes the problem, though I think a better solution should be decided on. For example - I'm writing to `std::cerr`, I'm not convinced this is generally acceptable, but I cannot guarantee the lifetime of the logger - The behaviour for old pulsar clients should be slightly different to the behaviour once cpp client is fixed, so there probably needs to be a version check. We don't want older clients to segfault, so either we bump the min version supported or we need to actively check the pulsar client version before deciding how to handle the close callback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
