Re: BookieId is broken on 2.10+

2022-09-22 Thread mattison chao
Nice! Best, Mattison On Thu, 22 Sept 2022 at 11:21, Michael Marshall wrote: > Great catch, Enrico. I saw the returned `null` in > `BookieServiceInfoSerde#deserialize`, but I didn't know its impact. > > Thanks, > Michael > > On Wed, Sep 21, 2022 at 8:30 AM Haiting Jiang > wrote: > > > > Sure, I

Re: BookieId is broken on 2.10+

2022-09-21 Thread Michael Marshall
Great catch, Enrico. I saw the returned `null` in `BookieServiceInfoSerde#deserialize`, but I didn't know its impact. Thanks, Michael On Wed, Sep 21, 2022 at 8:30 AM Haiting Jiang wrote: > > Sure, I have added the release label in this PR. > > BTW, the 2.10.2 release is almost ready for RC1 exc

Re: BookieId is broken on 2.10+

2022-09-21 Thread Haiting Jiang
Sure, I have added the release label in this PR. BTW, the 2.10.2 release is almost ready for RC1 except that there is an owasp ci failure on branch-2.10. Please help take a look. https://github.com/apache/pulsar/pull/17765 Thanks, Haiting On Wed, Sep 21, 2022 at 3:18 PM Enrico Olivelli wrote:

BookieId is broken on 2.10+

2022-09-21 Thread Enrico Olivelli
Hello folks, I have found that since Pulsar 2.10 you cannot set a custom BookieId anymore. The fix is easy https://github.com/apache/pulsar/pull/17762 I am pretty sure it worked on Pulsar 2.8 (I sent out a patch for supporting the bookieId on the Helm Chart). I think that we should cherry-pick t