Re: [DISCUSS] PIP-280 : Refactor CLI Argument Parsing Logic for Measurement Units using JCommander's custom converter

2023-07-04 Thread tison
I read the proposal on GitHub and it's clear to reduce code duplication with a middle size refactor. Although I think it may not require a PIP, we can try to proceed in the PIP process and see if the PIP process fits this proposal. cc developers in this domain AFAIK. Best, tison. Joo Hyuk Kim

RE: [DISCUSS] PIP-280 : Refactor CLI Argument Parsing Logic for Measurement Units using JCommander's custom converter

2023-07-01 Thread Joo Hyuk Kim
Hi, community With regards to the refactor work, I made a PR [1] that shows how Command classes will be improved. Any feedback on the PR or the PIP [2] itself will be much appreciated. Links [1] PR : https://github.com/JooHyukKim/pulsar/pull/15 [2] PIP : https://github.com/apache/pulsar/pull/2069