Re: [jira] [Commented] (INFRA-14376) Pulsar GitHub Integration

2017-06-22 Thread Sahaya Andrews
Thank you everyone for taking time to respond. I guess we will wait till the gitbox integration to complete. On Thu, Jun 22, 2017 at 6:06 PM, Matteo Merli wrote: > I think the gitbox integration is still not active. If I go on > https://gitbox.apache.org/setup/ > > I can see that : > > According

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread merlimat
Github user merlimat closed the pull request at: https://github.com/apache/incubator-pulsar/pull/521 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-pulsar issue #521: Fixed problem in starting ZK server for standal...

2017-06-22 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/incubator-pulsar/pull/521 I think if we ever need to do a 1.18.1, this fix should be included. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread merlimat
Github user merlimat closed the pull request at: https://github.com/apache/incubator-pulsar/pull/521 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-pulsar issue #521: Fixed problem in starting ZK server for standal...

2017-06-22 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/incubator-pulsar/pull/521 I think if we ever need to do a 1.18.1, this fix should be included. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [jira] [Commented] (INFRA-14376) Pulsar GitHub Integration

2017-06-22 Thread Matteo Merli
I think the gitbox integration is still not active. If I go on https://gitbox.apache.org/setup/ I can see that : According to LDAP, you will have access to the following repositories: bookkeeper: No repositories for the bookkeeper project served from gitbox yet... incubator: No repositories for

Re: [jira] [Commented] (INFRA-14376) Pulsar GitHub Integration

2017-06-22 Thread Rajan Dhabalia
Hi Dave, > Everyone who has provided an iCLA and has setup their Apache ID to point to their GitHub ID should have Write access as you see. Actually, I have verified that my Apache ID is pointing to GitHub-ID (username) and I have also submitted the iCLA earlier. I think it's same for Andrews as w

Re: [jira] [Commented] (INFRA-14376) Pulsar GitHub Integration

2017-06-22 Thread Dave Fisher
Hi Andrews, > On Jun 22, 2017, at 3:40 PM, Sahaya Andrews wrote: > > When can we expect the setup to be finalized? We are still waiting to > get write access. Some of us who were part of the dev group in the old > repo got write access automatically. But the rest who were part of > admin group d

[GitHub] incubator-pulsar pull request #522: Reduce default producer queue size from ...

2017-06-22 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/incubator-pulsar/pull/522 Reduce default producer queue size from 30K to 1K also for Python ### Motivation Since it the producer queue size was reduced for C++ and Java producer, we should keep it the sam

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/521#discussion_r123651843 --- Diff: pulsar-zookeeper/src/main/java/com/yahoo/pulsar/zookeeper/ZooKeeperServerAspect.java --- @@ -31,15 +31,26 @@ */ @Aspect

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/521#discussion_r123651843 --- Diff: pulsar-zookeeper/src/main/java/com/yahoo/pulsar/zookeeper/ZooKeeperServerAspect.java --- @@ -31,15 +31,26 @@ */ @Aspect

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/521#discussion_r123651694 --- Diff: pulsar-zookeeper/src/main/java/com/yahoo/pulsar/zookeeper/ZooKeeperServerAspect.java --- @@ -31,15 +31,26 @@ */ @Aspect

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/521#discussion_r123651694 --- Diff: pulsar-zookeeper/src/main/java/com/yahoo/pulsar/zookeeper/ZooKeeperServerAspect.java --- @@ -31,15 +31,26 @@ */ @Aspect

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/521#discussion_r123651279 --- Diff: pulsar-zookeeper/src/main/java/com/yahoo/pulsar/zookeeper/ZooKeeperServerAspect.java --- @@ -31,15 +31,26 @@ */ @Aspect

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/521#discussion_r123651279 --- Diff: pulsar-zookeeper/src/main/java/com/yahoo/pulsar/zookeeper/ZooKeeperServerAspect.java --- @@ -31,15 +31,26 @@ */ @Aspect

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/521#discussion_r123650995 --- Diff: pulsar-zookeeper/src/main/java/com/yahoo/pulsar/zookeeper/ZooKeeperServerAspect.java --- @@ -31,15 +31,26 @@ */ @Aspect

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread rdhabalia
Github user rdhabalia commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/521#discussion_r123650995 --- Diff: pulsar-zookeeper/src/main/java/com/yahoo/pulsar/zookeeper/ZooKeeperServerAspect.java --- @@ -31,15 +31,26 @@ */ @Aspect

[GitHub] incubator-pulsar pull request #521: Fixed problem in starting ZK server for ...

2017-06-22 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/incubator-pulsar/pull/521 Fixed problem in starting ZK server for standalone mode ### Motivation In 1.18 release there is a problem in starting the standalone broker. ``` $ bin/pulsar standalo

Re: [jira] [Commented] (INFRA-14376) Pulsar GitHub Integration

2017-06-22 Thread P. Taylor Goetz
Hi Andrews, I completely understand your excitement, which s a good thing! But one of the things you'll learn during incubation is the need to be patient. The infrastructure team has a lot of podlings, TLPs, and other matters to attend to in a largely volunteer organization. You'll also likely

[GitHub] incubator-pulsar pull request #520: Enable to configure webSocketServiceEnab...

2017-06-22 Thread merlimat
Github user merlimat closed the pull request at: https://github.com/apache/incubator-pulsar/pull/520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-pulsar pull request #520: Enable to configure webSocketServiceEnab...

2017-06-22 Thread merlimat
Github user merlimat closed the pull request at: https://github.com/apache/incubator-pulsar/pull/520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-pulsar pull request #517: Reverting commit d990b1 - changing produ...

2017-06-22 Thread merlimat
Github user merlimat closed the pull request at: https://github.com/apache/incubator-pulsar/pull/517 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-pulsar pull request #517: Reverting commit d990b1 - changing produ...

2017-06-22 Thread merlimat
Github user merlimat closed the pull request at: https://github.com/apache/incubator-pulsar/pull/517 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-pulsar pull request #520: Enable to configure webSocketServiceEnab...

2017-06-22 Thread nkurihar
GitHub user nkurihar opened a pull request: https://github.com/apache/incubator-pulsar/pull/520 Enable to configure webSocketServiceEnabled on Standalone ### Motivation When standalone mode, WebSocket service is always enabled. I think it should be configured by `standal

Re: [jira] [Commented] (INFRA-14376) Pulsar GitHub Integration

2017-06-22 Thread Sahaya Andrews
When can we expect the setup to be finalized? We are still waiting to get write access. Some of us who were part of the dev group in the old repo got write access automatically. But the rest who were part of admin group did not :) Andrews. On Wed, Jun 21, 2017 at 4:36 PM, Matteo Merli wrote: > A

Re: Renaming package names and license headers

2017-06-22 Thread Sahaya Andrews
We have merged the pull request https://github.com/apache/incubator-pulsar/pull/519 with the license header change. On Thu, Jun 22, 2017 at 1:34 PM, Matteo Merli wrote: > Ok, got it :) > > I've closed the PR. > > For the record, the steps I did to change the headers were: > > 1. Modify "src/lic

[GitHub] incubator-pulsar pull request #519: Updates headers with ASF source files he...

2017-06-22 Thread jai1
Github user jai1 closed the pull request at: https://github.com/apache/incubator-pulsar/pull/519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-pulsar pull request #519: Updates headers with ASF source files he...

2017-06-22 Thread jai1
Github user jai1 closed the pull request at: https://github.com/apache/incubator-pulsar/pull/519 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-pulsar pull request #519: Updates headers with ASF source files he...

2017-06-22 Thread rdhabalia
GitHub user rdhabalia opened a pull request: https://github.com/apache/incubator-pulsar/pull/519 Updates headers with ASF source files header ### Motivation #518 extending PR: Updated license headers and the license template file that is used to validated the license in

Re: Renaming package names and license headers

2017-06-22 Thread Matteo Merli
Ok, got it :) I've closed the PR. For the record, the steps I did to change the headers were: 1. Modify "src/license-header.txt" with standard ASF header 2. mvn license:format Matteo On Thu, Jun 22, 2017 at 10:51 AM Dave Fisher wrote: > Hi Matteo, > > No - the license header changes mus

[GitHub] incubator-pulsar issue #437: Make cache put watch even when node doesn't exi...

2017-06-22 Thread bobbeyreese
Github user bobbeyreese commented on the issue: https://github.com/apache/incubator-pulsar/pull/437 My previous concerns were address in #460 but the Travis build is failing a test that succeeds for me locally due to timeout. --- If your project is set up for it, you can reply to thi

[GitHub] incubator-pulsar pull request #518: Updates headers with ASF source files he...

2017-06-22 Thread merlimat
Github user merlimat closed the pull request at: https://github.com/apache/incubator-pulsar/pull/518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-pulsar issue #518: Updates headers with ASF source files header.

2017-06-22 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/518 @merlimat In mail discussion it says: > The Yahoo copyright can only be removed by a Yahoo employee as shown by the SGA. Should one of us create this PR? --- If your projec

Re: [GitHub] incubator-pulsar pull request #518: Updates headers with ASF source files he...

2017-06-22 Thread Dave Fisher
Matteo, The Yahoo copyright can only be removed by a Yahoo employee as shown by the SGA. Regards, Dave > On Jun 22, 2017, at 10:54 AM, merlimat wrote: > > GitHub user merlimat opened a pull request: > >https://github.com/apache/incubator-pulsar/pull/518 > >Updates headers with ASF so

[GitHub] incubator-pulsar pull request #518: Updates headers with ASF source files he...

2017-06-22 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/incubator-pulsar/pull/518 Updates headers with ASF source files header. ### Motivation Updated license headers and the license template file that is used to validated the license in source files. You can

Re: Renaming package names and license headers

2017-06-22 Thread Dave Fisher
Hi Matteo, No - the license header changes must be done by someone from Yahoo. That's ASF policy that the changes are done from the SGA org. Package names are ok. Regards, Dave > On Jun 22, 2017, at 10:48 AM, Matteo Merli wrote: > > I'm going to start to send out PRs to update the license he

Renaming package names and license headers

2017-06-22 Thread Matteo Merli
I'm going to start to send out PRs to update the license headers and to rename the Package names. I believe that the renaming should not pose a big trouble on the currently opened PRs, since git is able to follow that without conflicts. For the license headers, there might be some conflicts mark