[GitHub] incubator-pulsar pull request #526: Add managed-ledger admin tool to access ...

2017-06-23 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/526#discussion_r123866446 --- Diff: pulsar-client-admin/src/main/resources/mltool/ManagedLedgerAdminTool.py --- @@ -0,0 +1,261 @@ +#!/usr/bin/env python +

[GitHub] incubator-pulsar pull request #526: Add managed-ledger admin tool to access ...

2017-06-23 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/526#discussion_r123855445 --- Diff: pulsar-client-admin/src/main/resources/mltool/ManagedLedgerAdminTool.py --- @@ -0,0 +1,261 @@ +#!/usr/bin/env python +

[GitHub] incubator-pulsar pull request #526: Add managed-ledger admin tool to access ...

2017-06-23 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/526#discussion_r123855309 --- Diff: pulsar-client-admin/src/main/resources/mltool/ManagedLedgerAdminTool.py --- @@ -0,0 +1,261 @@ +#!/usr/bin/env python +

[GitHub] incubator-pulsar pull request #526: Add managed-ledger admin tool to access ...

2017-06-23 Thread merlimat
Github user merlimat commented on a diff in the pull request: https://github.com/apache/incubator-pulsar/pull/526#discussion_r123854374 --- Diff: pulsar-client-admin/src/main/resources/mltool/MLDataFormats_pb2.py --- @@ -0,0 +1,342 @@ +# Generated by the protocol buffer

[GitHub] incubator-pulsar pull request #525: Updated maven groupId from com.yahoo.pul...

2017-06-23 Thread merlimat
Github user merlimat closed the pull request at: https://github.com/apache/incubator-pulsar/pull/525 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-pulsar issue #526: Add managed-ledger admin tool to access ml bina...

2017-06-23 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/526 We don't have doc for managed-ledger protobuf compilation instruction. If we think it will be helpful then I will create a separate PR to add ML-protobuf location, compilation and will

[GitHub] incubator-pulsar issue #526: Add managed-ledger admin tool to access ml bina...

2017-06-23 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/526 We don't have doc for managed-ledger protobuf compilation instruction. If we think it will be helpful then I will create a separate PR to add ML-protobuf location, compilation and will

[GitHub] incubator-pulsar pull request #526: Add managed-ledger admin tool to access ...

2017-06-23 Thread rdhabalia
GitHub user rdhabalia opened a pull request: https://github.com/apache/incubator-pulsar/pull/526 Add managed-ledger admin tool to access ml binary information ### Motivation After merging #394, broker will start storing managed-ledger data into binary format which can't be

[GitHub] incubator-pulsar issue #524: Package name changes

2017-06-23 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/524 I see.. Sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-pulsar issue #524: Package name changes

2017-06-23 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/incubator-pulsar/pull/524 @rdhabalia I did not squashed them on purpose, to separate the commits with just the renaming and the commits with string changes.. So they depend on each other but better to keep them in

Re: [jira] [Commented] (INFRA-14376) Pulsar GitHub Integration

2017-06-23 Thread Dave Fisher
Hi Matteo. I think that I requested it in the prior ticket. I think we should get on Hip Chat with Daniel and discuss the configuration. https://www.hipchat.com/gOT4aZiMp I am on right now to see if we can set something up, but it is looking like the weekend has started. Let’s get this

[GitHub] incubator-pulsar issue #524: Package name changes

2017-06-23 Thread merlimat
Github user merlimat commented on the issue: https://github.com/apache/incubator-pulsar/pull/524 (pushed with rebase to preserve individual commits) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-pulsar issue #524: Package name changes

2017-06-23 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/524 1. `pulsar-broker/src/test/resources/log4j.properties:log4j.logger.com.yahoo.pulsar=OFF` 2. SCM change: ``` pom.xml: scm:git:ssh://g...@github.com:yahoo/pulsar.git

[GitHub] incubator-pulsar issue #524: Package name changes

2017-06-23 Thread rdhabalia
Github user rdhabalia commented on the issue: https://github.com/apache/incubator-pulsar/pull/524 1. `pulsar-broker/src/test/resources/log4j.properties:log4j.logger.com.yahoo.pulsar=OFF` 2. SCM change: ``` pom.xml: scm:git:ssh://g...@github.com:yahoo/pulsar.git

[GitHub] incubator-pulsar pull request #524: Package name changes

2017-06-23 Thread merlimat
GitHub user merlimat opened a pull request: https://github.com/apache/incubator-pulsar/pull/524 Package name changes ### Motivation Renamed Java package names and references from `com.yahoo.pulsar` to `org.apache.pulsar` You can merge this pull request into a Git

[GitHub] incubator-pulsar issue #523: Max Payload size is validated before compressio...

2017-06-23 Thread sschepens
GitHub user sschepens opened an issue: https://github.com/apache/incubator-pulsar/issues/523 Max Payload size is validated before compression Max Message Payload size is validated by `MessageBuilderImpl` and that happens before producer gets to compress payload. This should be

Re: [jira] [Commented] (INFRA-14376) Pulsar GitHub Integration

2017-06-23 Thread Sahaya Andrews
Thank you everyone for taking time to respond. I guess we will wait till the gitbox integration to complete. On Thu, Jun 22, 2017 at 6:06 PM, Matteo Merli wrote: > I think the gitbox integration is still not active. If I go on > https://gitbox.apache.org/setup/ > > I can see