Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Dave Fisher
Hi Jerry, > On Jul 23, 2018, at 3:05 PM, Jerry Peng wrote: > > +1 for the 5th release candidate for Apache Pulsar, version 2.1.0-incubating > > Source and binary files: > https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/ > > I followed the release can

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Dave Fisher
Hi - > On Jul 23, 2018, at 4:55 PM, Matteo Merli wrote: > > On Mon, Jul 23, 2018 at 11:12 AM Dave Fisher wrote: > >> (3) Pulsar IO Connectors NAR files. >> Signature and checksums pass. >> LICENSE and DISCLAIMER exist in the top level of the package. >> LICENSE and NOTICE plus DEPENDENCIES exi

Build failed in Jenkins: pulsar-master #641

2018-07-23 Thread Apache Jenkins Server
See Changes: [guosijie] Cpp client: add multiTopicsConsumer (#1996) -- [...truncated 1.07 MB...] 2018-07-24 00:14:20.053 INFO ConsumerImpl:168 | [persistent://sample/standal

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Matteo Merli
On Mon, Jul 23, 2018 at 11:12 AM Dave Fisher wrote: > (3) Pulsar IO Connectors NAR files. > Signature and checksums pass. > LICENSE and DISCLAIMER exist in the top level of the package. > LICENSE and NOTICE plus DEPENDENCIES exist in the NAR files. > > ==> DISCLAIMER should be included in the NAR

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Matteo Merli
+1 Environment: MacOS 10.13 Checked: * Signatures, crc * Bin distribution: - NOTICE, README, LICENSE - Start standalone service and producer/consumer test * Src distribution: - NOTICE, README, LICENSE - Compile and unit tests - RAT check - Start standalone servic

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Jerry Peng
+1 for the 5th release candidate for Apache Pulsar, version 2.1.0-incubating Source and binary files: https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-2.1.0-incubating-candidate-5/ I followed the release candidate validation guide: https://github.com/apache/incubator-pulsar/wiki/Re

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Dave Fisher
Hi - +1 (IPMC Binding) Comment #1 - There are many more files to review in this release. :-) (1) Source release. Signature and checksums pass. Builds from source with the option that Sijie provided. Standalone starts NOTICE, LICENSE and DISCLAIMER look good. (2) Binary release Signature and che

Jenkins build is unstable: pulsar-master #639

2018-07-23 Thread Apache Jenkins Server
See

Re: [VOTE] Pulsar Release 2.1.0-incubating Candidate 5

2018-07-23 Thread Ivan Kelly
The git error can be fixed by adding false It already has failOnUnableToExtractRepoInfo as false, which I assumed would cover this case. -Ivan On Mon, Jul 23, 2018 at 6:05 AM, Sijie Guo wrote: > any more review comments? > > - Sijie > > On Fri, Jul 20, 2018 at 1:13 PM Sijie Guo wrote: > >> Oka

Build failed in Jenkins: pulsar-website-build #315

2018-07-23 Thread Apache Jenkins Server
See -- Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on H17 (Hadoop xenial) in workspace